From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
"Clark Wang" <xiaoning.wang@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>, <imx@lists.linux.dev>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel@pengutronix.de>, Frank Li <Frank.Li@nxp.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next v3 03/10] net: fec: add missing header files
Date: Tue, 17 Jun 2025 16:55:19 +0200 [thread overview]
Message-ID: <b6687ad2-1fd9-4cb5-8f5d-8c203599f002@intel.com> (raw)
In-Reply-To: <20250617-fec-cleanups-v3-3-a57bfb38993f@pengutronix.de>
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Tue, 17 Jun 2025 15:24:53 +0200
> The fec.h isn't self contained. Add missing header files, so that it can be
> parsed by language servers without errors.
>
> Reviewed-by: Wei Fang <wei.fang@nxp.com>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> drivers/net/ethernet/freescale/fec.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h
> index ce1e4fe4d492..4098d439a6ff 100644
> --- a/drivers/net/ethernet/freescale/fec.h
> +++ b/drivers/net/ethernet/freescale/fec.h
> @@ -15,7 +15,9 @@
> /****************************************************************************/
>
> #include <linux/clocksource.h>
> +#include <linux/ethtool.h>
> #include <linux/net_tstamp.h>
> +#include <linux/phy.h>
> #include <linux/pm_qos.h>
> #include <linux/bpf.h>
> #include <linux/ptp_clock_kernel.h>
Sort alphabetically while at it? You'd only need to move bpf.h AFAICS.
Thanks,
Olek
next prev parent reply other threads:[~2025-06-17 14:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 13:24 [PATCH net-next v3 00/10] net: fec: general + VLAN cleanups Marc Kleine-Budde
2025-06-17 13:24 ` [PATCH net-next v3 01/10] net: fec: fix typos found by codespell Marc Kleine-Budde
2025-06-17 13:24 ` [PATCH net-next v3 02/10] net: fec: struct fec_enet_private: remove obsolete comment Marc Kleine-Budde
2025-06-17 13:24 ` [PATCH net-next v3 03/10] net: fec: add missing header files Marc Kleine-Budde
2025-06-17 14:55 ` Alexander Lobakin [this message]
2025-06-17 15:07 ` Marc Kleine-Budde
2025-06-18 1:31 ` Wei Fang
2025-06-17 13:24 ` [PATCH net-next v3 04/10] net: fec: rename struct fec_devinfo fec_imx6x_info -> fec_imx6sx_info Marc Kleine-Budde
2025-06-17 13:24 ` [PATCH net-next v3 05/10] net: fec: fec_restart(): introduce a define for FEC_ECR_SPEED Marc Kleine-Budde
2025-06-17 13:24 ` [PATCH net-next v3 06/10] net: fec: fec_enet_rx_queue(): use same signature as fec_enet_tx_queue() Marc Kleine-Budde
2025-06-17 13:24 ` [PATCH net-next v3 07/10] net: fec: fec_enet_rx_queue(): replace manual VLAN header calculation with skb_vlan_eth_hdr() Marc Kleine-Budde
2025-06-17 13:24 ` [PATCH net-next v3 08/10] net: fec: fec_enet_rx_queue(): reduce scope of data Marc Kleine-Budde
2025-06-17 13:24 ` [PATCH net-next v3 09/10] net: fec: fec_enet_rx_queue(): move_call to _vlan_hwaccel_put_tag() Marc Kleine-Budde
2025-06-17 13:25 ` [PATCH net-next v3 10/10] net: fec: fec_enet_rx_queue(): factor out VLAN handling into separate function fec_enet_rx_vlan() Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6687ad2-1fd9-4cb5-8f5d-8c203599f002@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=Frank.Li@nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®