From: "Songwei.Chai" <songwei.chai@oss.qualcomm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
andersson@kernel.org, alexander.shishkin@linux.intel.com,
mike.leach@linaro.org, konrad.dybcio@oss.qualcomm.com,
james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org,
devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
songchai@qti.qualcomm.com, Jie Gan <jie.gan@oss.qualcomm.com>
Subject: Re: [PATCH v18 4/8] qcom-tgu: Add signal priority support
Date: Tue, 17 Nov 2026 11:16:39 +0800 [thread overview]
Message-ID: <b66bd620-e0a2-4869-9cfc-94364f772f64@oss.qualcomm.com> (raw)
In-Reply-To: <c23c116b-063a-4658-a6da-b79146226d4a@arm.com>
On 11/16/2026 7:16 PM, Suzuki K Poulose wrote:
> On 16/11/2026 07:41, Songwei Chai wrote:
>> Like circuit of a Logic analyzer, in TGU, the requirement could be
>> configured in each step and the trigger will be created once the
>> requirements are met. Add priority functionality here to sort the
>> signals into different priorities. The signal which is wanted could
>> be configured in each step's priority node, the larger number means
>> the higher priority and the signal with higher priority will be sensed
>> more preferentially.
>>
>> Reviewed-by: Jie Gan <jie.gan@oss.qualcomm.com>
>> Signed-off-by: Songwei Chai <songwei.chai@oss.qualcomm.com>
>> ---
>> .../ABI/testing/sysfs-bus-amba-devices-tgu | 7 +
>> drivers/hwtracing/qcom/tgu.c | 211 ++++++++++++++++++
>> drivers/hwtracing/qcom/tgu.h | 68 ++++++
>> 3 files changed, 286 insertions(+)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu
>> b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu
>> index 798a0e51e27a..3be0b912c937 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu
>> +++ b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu
>> @@ -7,3 +7,10 @@ Description:
>> Accepts only one of the 2 values - 0 or 1.
>> 0 : disable TGU.
>> 1 : enable TGU.
>> +
>> +What:
>> /sys/bus/amba/devices/<tgu-name>/step[0:7]_priority[0:3]/reg[0:23]
>> +Date: November 2026
>> +KernelVersion: 7.5
>> +Contact: Jinlong Mao <jinlong.mao@oss.qualcomm.com>, Songwei Chai
>> <songwei.chai@oss.qualcomm.com>
>> +Description:
>> + (RW) Set/Get the sensed signal with specific step and
>> priority for TGU.
>> diff --git a/drivers/hwtracing/qcom/tgu.c b/drivers/hwtracing/qcom/tgu.c
>> index 5bae46db4f8c..917d506cddf9 100644
>> --- a/drivers/hwtracing/qcom/tgu.c
>> +++ b/drivers/hwtracing/qcom/tgu.c
>> @@ -16,14 +16,145 @@
>> #include "tgu.h"
>> +struct tgu_attribute {
>> + struct device_attribute attr;
>> + u8 step_index;
>> + u8 priority;
>> + u8 reg_num;
>> +};
>> +
>> +/*
>> + * drvdata->priority is a flat [priority][step][reg] array.
>> + */
>> +static int calculate_array_location(struct tgu_drvdata *drvdata,
>> + int step_index, int priority,
>> + int reg_index)
>> +{
>> + return priority * (drvdata->num_step) * (drvdata->num_reg) +
>> + step_index * (drvdata->num_reg) + reg_index;
>> +}
>> +
>> +static ssize_t tgu_dataset_show(struct device *dev,
>> + struct device_attribute *attr, char *buf)
>> +{
>> + struct tgu_drvdata *drvdata = dev_get_drvdata(dev);
>> + struct tgu_attribute *tgu_attr =
>> + container_of(attr, struct tgu_attribute, attr);
>> + int index;
>> +
>> + index = calculate_array_location(drvdata, tgu_attr->step_index,
>> + tgu_attr->priority,
>> + tgu_attr->reg_num);
>> +
>> + /*
>> + * Serialise against tgu_dataset_store() and tgu_enable(), which
>> read
>> + * and write the same priority array, so the value is not observed
>> + * while being updated concurrently.
>> + */
>> + guard(mutex)(&drvdata->lock);
>> +
>> + return sysfs_emit(buf, "0x%x\n", drvdata->priority[index]);
>> +}
>> +
>> +static ssize_t tgu_dataset_store(struct device *dev,
>> + struct device_attribute *attr,
>> + const char *buf, size_t size)
>> +{
>> + struct tgu_drvdata *tgu_drvdata = dev_get_drvdata(dev);
>> + struct tgu_attribute *tgu_attr =
>> + container_of(attr, struct tgu_attribute, attr);
>> + unsigned long val;
>> + int index;
>> + int ret;
>> +
>> + ret = kstrtoul(buf, 0, &val);
>> + if (ret)
>> + return ret;
>> +
>> + guard(mutex)(&tgu_drvdata->lock);
>> + index = calculate_array_location(tgu_drvdata, tgu_attr->step_index,
>> + tgu_attr->priority,
>> + tgu_attr->reg_num);
>> +
>> + tgu_drvdata->priority[index] = val;
>> +
>> + return size;
>> +}
>> +
>> +static umode_t tgu_node_visible(struct kobject *kobject,
>> + struct attribute *attr,
>> + int n)
>> +{
>> + struct device *dev = kobj_to_dev(kobject);
>> + struct tgu_drvdata *drvdata = dev_get_drvdata(dev);
>> + struct device_attribute *dev_attr =
>> + container_of(attr, struct device_attribute, attr);
>> + struct tgu_attribute *tgu_attr =
>> + container_of(dev_attr, struct tgu_attribute, attr);
>> +
>> + if (tgu_attr->step_index >= drvdata->num_step)
>> + return SYSFS_GROUP_INVISIBLE;
>> +
>> + if (tgu_attr->reg_num >= drvdata->num_reg)
>> + return 0;
>> +
>> + return attr->mode;
>> +}
>> +
>> static void tgu_write_all_hw_regs(struct tgu_drvdata *drvdata)
>> {
>> + int i, j, k, index;
>> +
>> CS_UNLOCK(drvdata->base);
>> + for (i = 0; i < drvdata->num_step; i++) {
>> + for (j = 0; j < MAX_PRIORITY; j++) {
>> + for (k = 0; k < drvdata->num_reg; k++) {
>> + index = calculate_array_location(
>> + drvdata, i, j, k);
>> +
>> + writel(drvdata->priority[index],
>> + drvdata->base +
>> + PRIORITY_REG_STEP(i, j, k));
>> + }
>> + }
>> + }
>> /* Enable TGU to program the triggers */
>> writel(1, drvdata->base + TGU_CONTROL);
>> CS_LOCK(drvdata->base);
>> }
>> +static void tgu_set_dev_caps(struct tgu_drvdata *drvdata)
>> +{
>> + int num_sense_input, num_reg, num_step;
>> + u32 devid;
>> +
>> + devid = readl(drvdata->base + CORESIGHT_DEVID);
>> +
>> + num_sense_input = TGU_DEVID_SENSE_INPUT(devid);
>> + num_reg = (num_sense_input * TGU_BITS_PER_SIGNAL) /
>> LENGTH_REGISTER;
>> +
>> + if ((num_sense_input * TGU_BITS_PER_SIGNAL) % LENGTH_REGISTER)
>> + num_reg++;
>> +
>> + if (num_reg > TGU_MAX_PRIORITY_REGS) {
>> + dev_warn(drvdata->dev,
>> + "DEVID reports %d priority regs, clamping to %d\n",
>> + num_reg, TGU_MAX_PRIORITY_REGS);
>> + num_reg = TGU_MAX_PRIORITY_REGS;
>> + }
>> + drvdata->num_reg = num_reg;
>> +
>> + num_step = TGU_DEVID_STEPS(devid);
>> +
>> + if (num_step > TGU_MAX_STEPS) {
>> + dev_warn(drvdata->dev,
>> + "DEVID reports %d steps, clamping to %d\n",
>> + num_step, TGU_MAX_STEPS);
>> + num_step = TGU_MAX_STEPS;
>> + }
>> + drvdata->num_step = num_step;
>> +}
>> +
>> static void tgu_enable(struct tgu_drvdata *drvdata)
>> {
>> tgu_write_all_hw_regs(drvdata);
>> @@ -103,8 +234,86 @@ static const struct attribute_group
>> tgu_common_grp = {
>> .attrs = tgu_common_attrs,
>> };
>> +#define tgu_dataset_rw(name, step_index, priority,
>> reg_num) \
>> + (&((struct tgu_attribute[]){ { \
>> + __ATTR(name, 0644, tgu_dataset_show, tgu_dataset_store), \
>> + step_index, \
>> + priority, \
>> + reg_num, \
>> + } })[0].attr.attr)
>> +
>> +#define STEP_PRIORITY(step_index, reg_num, priority) \
>> + tgu_dataset_rw(reg##reg_num, step_index, priority, reg_num)
>> +
>> +#define STEP_PRIORITY_LIST(step_index, priority) \
>> + {STEP_PRIORITY(step_index, 0, priority), \
>> + STEP_PRIORITY(step_index, 1, priority), \
>> + STEP_PRIORITY(step_index, 2, priority), \
>> + STEP_PRIORITY(step_index, 3, priority), \
>> + STEP_PRIORITY(step_index, 4, priority), \
>> + STEP_PRIORITY(step_index, 5, priority), \
>> + STEP_PRIORITY(step_index, 6, priority), \
>> + STEP_PRIORITY(step_index, 7, priority), \
>> + STEP_PRIORITY(step_index, 8, priority), \
>> + STEP_PRIORITY(step_index, 9, priority), \
>> + STEP_PRIORITY(step_index, 10, priority), \
>> + STEP_PRIORITY(step_index, 11, priority), \
>> + STEP_PRIORITY(step_index, 12, priority), \
>> + STEP_PRIORITY(step_index, 13, priority), \
>> + STEP_PRIORITY(step_index, 14, priority), \
>> + STEP_PRIORITY(step_index, 15, priority), \
>> + STEP_PRIORITY(step_index, 16, priority), \
>> + STEP_PRIORITY(step_index, 17, priority), \
>> + STEP_PRIORITY(step_index, 18, priority), \
>> + STEP_PRIORITY(step_index, 19, priority), \
>> + STEP_PRIORITY(step_index, 20, priority), \
>> + STEP_PRIORITY(step_index, 21, priority), \
>> + STEP_PRIORITY(step_index, 22, priority), \
>> + STEP_PRIORITY(step_index, 23, priority), \
>> + NULL \
>> + }
>> +
>> +#define PRIORITY_ATTRIBUTE_GROUP_INIT(step, priority)\
>> + (&(const struct attribute_group){\
>> + .attrs = (struct attribute*[])STEP_PRIORITY_LIST(step,
>> priority),\
>> + .is_visible = tgu_node_visible,\
>> + .name = "step" #step "_priority" #priority \
>> + })
>> +
>> static const struct attribute_group *tgu_attr_groups[] = {
>> &tgu_common_grp,
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(0, 0),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(0, 1),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(0, 2),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(0, 3),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(1, 0),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(1, 1),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(1, 2),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(1, 3),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(2, 0),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(2, 1),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(2, 2),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(2, 3),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(3, 0),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(3, 1),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(3, 2),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(3, 3),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(4, 0),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(4, 1),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(4, 2),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(4, 3),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(5, 0),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(5, 1),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(5, 2),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(5, 3),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(6, 0),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(6, 1),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(6, 2),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(6, 3),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(7, 0),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(7, 1),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(7, 2),
>> + PRIORITY_ATTRIBUTE_GROUP_INIT(7, 3),
>> NULL,
>> };
>> @@ -129,6 +338,8 @@ static int tgu_probe(struct amba_device *adev,
>> const struct amba_id *id)
>> if (ret)
>> return ret;
>> + tgu_set_dev_caps(drvdata);
>> +
>> drvdata->enabled = false;
>> ret = sysfs_create_groups(&dev->kobj, tgu_attr_groups);
>> diff --git a/drivers/hwtracing/qcom/tgu.h b/drivers/hwtracing/qcom/tgu.h
>> index c6426b4e3617..d769379b8421 100644
>> --- a/drivers/hwtracing/qcom/tgu.h
>> +++ b/drivers/hwtracing/qcom/tgu.h
>> @@ -6,9 +6,70 @@
>> #ifndef _QCOM_TGU_H
>> #define _QCOM_TGU_H
>> +#include <linux/bitfield.h>
>> +#include <linux/bits.h>
>> +
>> /* Register addresses */
>> #define TGU_CONTROL 0x0000
>> +#define TGU_DEVID_SENSE_INPUT(devid_val) \
>> + ((int)FIELD_GET(GENMASK(17, 10), devid_val))
>> +#define TGU_DEVID_STEPS(devid_val) \
>> + ((int)FIELD_GET(GENMASK(6, 3), devid_val))
>> +
>> +#define TGU_BITS_PER_SIGNAL 4
>> +#define LENGTH_REGISTER 32
>> +
>> +/*
>> + * TGU configuration space Per-step register layout.
>> + * (one step occupies STEP_SIZE bytes) Offsets below are relative to
>> + * the start
>> of that step's block.
>> + * x-------------------------x x-----------------x
>> + * | coresight management | | reserved |
>> + * | registers | |-----------------| +0x1F4
>> + * | | ---> |
>> priority[3] |
>> + * |-------------------------| |
>> |-----------------| +0x194
>> + * | step[7] | | |
>> priority[2] |
>> + * |-------------------------| step[0] + 7*STEP_SIZE |
>> |-----------------| +0x134
>> + * | ... | | |
>> priority[1] |
>> + * |-------------------------| step[0] + 1*STEP_SIZE |
>> |-----------------| +0xD4
>> + * | step[0] |-----------------------| |
>> priority[0] |
>> + * |-------------------------| step[0] (base+0x40)
>> |-----------------| +0x74
>> + * | Control and status | |
>> condition select|
>> + * | space | |-----------------| +0x60
>> + * x-------------------------x base |
>> condition decode|
>> + * |-----------------| +0x50
>> + * |
>> Timer/Counter |
>> + * x-----------------x +0x40
>> + */
>> +#define STEP_SIZE 0x1D8
>
> Something is really weird. STEP_SIZE is 0x1D8, but the diagram above
> shows the "reserved" is at 0x1F4 ? is it because you have added 0x40
> (of the Control and Status space) to the offsets for the step0 ?
>
> Please could we simply define the fields for a step with offset 0 as
> the base for each step ?
>
> i.e., Timer/Counter -> 0x0
> Priority[0]-> 0x34
>
>
confirmed.
> Also, please could you keep the naming consistent.
> STEP_SIZE vs PRIORITY_STRIDE ? I prefer SIZE
>
>
> #define STEP0_BASE 0x40
> #define STEP_SIZE 0x1D8
>
> #define PRIORITY0_BASE 0x34
> #define PRIORITY_SIZE 0x60
>
>
> and
>
> #define STEP_OFFSET(s) (STEP0_BASE + STEP_SIZE * (s))
> #define PRIORITY_OFFSET(p) (PRIORITY0_BASE + PRIORITY_SIZE *(p))
>
> with that we could replace
>
> > +/* Calculate compare step addresses */
> > +#define PRIORITY_REG_STEP(step, priority, reg)\
> > + (PRIORITY0_OFFSET + PRIORITY_STRIDE * priority +\
> > + REG_SIZE * reg + STEP_SIZE * step)
>
> with :
>
> #define PRIORITY_REG_OFFSET(step, prio, reg) \
> (STEP_OFFSET(step) + PRIORITY_OFFSET(prio) + (reg) * REG_SIZE)
>
confirmed.
>
>
>
>> +#define PRIORITY0_OFFSET 0x0074
>> +#define PRIORITY_STRIDE 0x0060
>> +#define REG_SIZE 0x4
>> +
>> +/*
>> + * Upper bounds on the DEVID-derived per-region counts, used to clamp
>> + * whatever the hardware reports so writes never fall outside the
>> + * ioremap()'d window or spill into an adjacent region.
>> + *
>> + * TGU_MAX_STEPS matches the static step0..step7 sysfs
>> tables.
>> + * TGU_MAX_PRIORITY_REGS matches the static reg0..reg23 sysfs tables.
>> + *
>> + * Each priority level's block spans a full PRIORITY_STRIDE (0x60
>> bytes),
>> + * i.e. PRIORITY_STRIDE / REG_SIZE = 24 registers, all of them
>> implemented.
>> + */
>> +
>> +#define TGU_MAX_STEPS 8
>> +#define TGU_MAX_PRIORITY_REGS 24
>> +
>> +/* Maximum priority that TGU supports */
>> +#define MAX_PRIORITY 4
>
> nit: TGU_MAX_PRIORITY for consistency
confirmed.
>> +
>
>> +
>> /**
>> * struct tgu_drvdata - Data structure for a TGU (Trigger
>> Generation Unit)
>> * @base: Memory-mapped base address of the TGU device
>> @@ -16,6 +77,10 @@
>> * @lock: Mutex serialising enable/disable and the associated PM
>> runtime
>> * reference counting against concurrent sysfs access
>> * @enabled: Flag indicating whether the TGU device is enabled
>> + * @priority: Per-step, per-priority-level, per-register values
>> staged by
>> + * sysfs writes and flushed to hardware by tgu_enable()
>> + * @num_reg: Number of priority registers implemented per priority
>> level
>> + * @num_step: Number of steps implemented
>> *
>> * This structure defines the data associated with a TGU device,
>> * including its base address, device pointer, the lock serialising
>> @@ -26,6 +91,9 @@ struct tgu_drvdata {
>> struct device *dev;
>> struct mutex lock;
>> bool enabled;
>> + unsigned int priority[TGU_MAX_STEPS * MAX_PRIORITY *
>> TGU_MAX_PRIORITY_REGS];
>
> Please add a symbol for this
>
> #define TGU_MAX_PRIORITY_REG_SIZE
> (TGU_MAX_STEPS * TGU_MAX_PRIORITY * TGU_MAX_PRIORITY_REGS)
confirmed.
>
> Suzuki
next prev parent reply other threads:[~2026-11-17 6:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 7:41 [PATCH v18 0/8] Provide support for Trigger Generation Unit Songwei Chai
2026-11-16 7:41 ` [PATCH v18 1/8] dt-bindings: arm: Add support for Qualcomm TGU trace Songwei Chai
2026-11-16 7:41 ` [PATCH v18 2/8] coresight: Move CoreSight management register defs to linux/coresight.h Songwei Chai
2026-11-16 7:41 ` [PATCH v18 3/8] qcom-tgu: Add TGU driver Songwei Chai
2026-11-16 7:41 ` [PATCH v18 4/8] qcom-tgu: Add signal priority support Songwei Chai
2026-11-16 11:16 ` Suzuki K Poulose
2026-11-17 3:16 ` Songwei.Chai [this message]
2026-11-16 7:41 ` [PATCH v18 5/8] qcom-tgu: Add TGU decode support Songwei Chai
2026-11-16 11:43 ` Suzuki K Poulose
2026-11-17 6:52 ` Songwei.Chai
2026-11-16 7:41 ` [PATCH v18 6/8] qcom-tgu: Add support to configure next action Songwei Chai
2026-11-16 7:41 ` [PATCH v18 7/8] qcom-tgu: Add timer/counter functionality for TGU Songwei Chai
2026-11-16 7:41 ` [PATCH v18 8/8] qcom-tgu: Add reset node to initialize Songwei Chai
2026-11-16 9:25 ` [PATCH v18 0/8] Provide support for Trigger Generation Unit Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b66bd620-e0a2-4869-9cfc-94364f772f64@oss.qualcomm.com \
--to=songwei.chai@oss.qualcomm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.clark@arm.com \
--cc=jie.gan@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=songchai@qti.qualcomm.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®