From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752443AbcF2KnL (ORCPT ); Wed, 29 Jun 2016 06:43:11 -0400 Received: from server.coly.li ([162.144.45.48]:52665 "EHLO server.coly.li" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752346AbcF2KnI (ORCPT ); Wed, 29 Jun 2016 06:43:08 -0400 X-Greylist: delayed 1552 seconds by postgrey-1.27 at vger.kernel.org; Wed, 29 Jun 2016 06:43:08 EDT Subject: Re: [RESEND PATCH 2/3] bcache: update document info To: Yijing Wang , axboe@fb.com, Kent Overstreet References: <1466561534-17595-1-git-send-email-wangyijing@huawei.com> Cc: Eric Wheeler , Coly Li , linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org From: Coly Li Message-ID: Date: Wed, 29 Jun 2016 18:16:04 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1466561534-17595-1-git-send-email-wangyijing@huawei.com> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.coly.li X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - coly.li X-Get-Message-Sender-Via: server.coly.li: authenticated_id: i@coly.li X-Authenticated-Sender: server.coly.li: i@coly.li X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 16/6/22 ÉÏÎç10:12, Yijing Wang дµÀ: > There is no return in continue_at(), update the documentation. > There are 2 modification of this patch. The first one is about a typo, it is correct. But I doubt your second modification is proper. The line removed in your patch is, > - * continue_at() also, critically, is a macro that returns the calling function. > - * There's good reason for this. > - * I think this is exactly what original author wants to say. It does not mean return a value, it means return to the calling function. And the bellowed lines explains the reason. > Signed-off-by: Yijing Wang > --- > drivers/md/bcache/closure.c | 2 +- > drivers/md/bcache/closure.h | 3 --- > 2 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c > index 9eaf1d6..864e673 100644 > --- a/drivers/md/bcache/closure.c > +++ b/drivers/md/bcache/closure.c > @@ -112,7 +112,7 @@ bool closure_wait(struct closure_waitlist *waitlist, struct closure *cl) > EXPORT_SYMBOL(closure_wait); > > /** > - * closure_sync - sleep until a closure a closure has nothing left to wait on > + * closure_sync - sleep until a closure has nothing left to wait on Yes, this modification is good. > * > * Sleeps until the refcount hits 1 - the thread that's running the closure owns > * the last refcount. > diff --git a/drivers/md/bcache/closure.h b/drivers/md/bcache/closure.h > index 782cc2c..f51188d 100644 > --- a/drivers/md/bcache/closure.h > +++ b/drivers/md/bcache/closure.h > @@ -31,9 +31,6 @@ > * passing it, as you might expect, the function to run when nothing is pending > * and the workqueue to run that function out of. > * > - * continue_at() also, critically, is a macro that returns the calling function. > - * There's good reason for this. > - * > * To use safely closures asynchronously, they must always have a refcount while > * they are running owned by the thread that is running them. Otherwise, suppose > * you submit some bios and wish to have a function run when they all complete: > -- Coly Li