From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EBC5C433B4 for ; Fri, 9 Apr 2021 04:39:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08EFB61106 for ; Fri, 9 Apr 2021 04:39:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231286AbhDIEjt (ORCPT ); Fri, 9 Apr 2021 00:39:49 -0400 Received: from smtprelay0190.hostedemail.com ([216.40.44.190]:60014 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229846AbhDIEjr (ORCPT ); Fri, 9 Apr 2021 00:39:47 -0400 Received: from omf14.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id A1F3A18221879; Fri, 9 Apr 2021 04:39:34 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA id 3C37B268E45; Fri, 9 Apr 2021 04:39:33 +0000 (UTC) Message-ID: Subject: Re: [PATCH v5 2/6] w1: ds2438: fixed if brackets coding style issue From: Joe Perches To: Luiz Sampaio , zbr@ioremap.net Cc: corbet@lwn.net, rikard.falkeborn@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Date: Thu, 08 Apr 2021 21:39:31 -0700 In-Reply-To: <20210409030942.441830-3-sampaio.ime@gmail.com> References: <20210405105009.420924-1-sampaio.ime@gmail.com> <20210409030942.441830-1-sampaio.ime@gmail.com> <20210409030942.441830-3-sampaio.ime@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: 3C37B268E45 X-Stat-Signature: nud8sg9bh3879zaw4tr8y6xixwbmfho7 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/uwvjTT8jKiCt33j8es/sxZ2crVzP6XXQ= X-HE-Tag: 1617943173-62169 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2021-04-09 at 00:09 -0300, Luiz Sampaio wrote: > Since there is only one statement inside the if clause, no brackets are > required. > > Signed-off-by: Luiz Sampaio > --- >  drivers/w1/slaves/w1_ds2438.c | 16 ++++++++-------- >  1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c > index 148921fb9702..56e53a748059 100644 > --- a/drivers/w1/slaves/w1_ds2438.c > +++ b/drivers/w1/slaves/w1_ds2438.c > @@ -287,9 +287,9 @@ static ssize_t iad_read(struct file *filp, struct kobject *kobj, >   if (!buf) >   return -EINVAL; >   > > - if (w1_ds2438_get_current(sl, &voltage) == 0) { > + if (w1_ds2438_get_current(sl, &voltage) == 0) >   ret = snprintf(buf, count, "%i\n", voltage); > - } else > + else >   ret = -EIO; >   > >   return ret; > @@ -338,9 +338,9 @@ static ssize_t temperature_read(struct file *filp, struct kobject *kobj, >   if (!buf) >   return -EINVAL; >   > > - if (w1_ds2438_get_temperature(sl, &temp) == 0) { > + if (w1_ds2438_get_temperature(sl, &temp) == 0) >   ret = snprintf(buf, count, "%i\n", temp); > - } else > + else >   ret = -EIO; >   > >   return ret; > @@ -359,9 +359,9 @@ static ssize_t vad_read(struct file *filp, struct kobject *kobj, >   if (!buf) >   return -EINVAL; >   > > - if (w1_ds2438_get_voltage(sl, DS2438_ADC_INPUT_VAD, &voltage) == 0) { > + if (w1_ds2438_get_voltage(sl, DS2438_ADC_INPUT_VAD, &voltage) == 0) >   ret = snprintf(buf, count, "%u\n", voltage); > - } else > + else >   ret = -EIO; >   > >   return ret; > @@ -380,9 +380,9 @@ static ssize_t vdd_read(struct file *filp, struct kobject *kobj, >   if (!buf) >   return -EINVAL; >   > > - if (w1_ds2438_get_voltage(sl, DS2438_ADC_INPUT_VDD, &voltage) == 0) { > + if (w1_ds2438_get_voltage(sl, DS2438_ADC_INPUT_VDD, &voltage) == 0) >   ret = snprintf(buf, count, "%u\n", voltage); > - } else > + else >   ret = -EIO; >   > >   return ret;