From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2435352-1522381834-2-5707913500234263470 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, FREEMAIL_FORGED_FROMDOMAIN 0.25, FREEMAIL_FROM 0.001, HEADER_FROM_DIFFERENT_DOMAINS 0.249, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.138', Host='smtp1.osuosl.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1522381834; b=lMm5XLY3zdOzLacuMwuWbp9hhzY/JmeRuX/6lp+2lYy7ra4k+G 6nV4SoZO+6ViaXYSfT/8y9mmNciqIFLVivTKW9wYgcdtk6wlnObfdfpw8izDuATk SLG18Rkfb0r03DWFsTFEa7RoTMpMX/XQB4K6+D6ZXX9qcf3h1LqO37kkKM7vN7Al se84EKogrRzzt/EKJrh8P/EKL2jtJwyy7KDwh/pabDrCvOjkrPecNEwt0dYs28KD k93+A/wESw/79CRTMAFNadK/v7s1Aw2lASg/Cxq9InBeFN9qGU7wmatjHRdeZD9u fcbiP5om1IpPY7SX+GTViAUjVN4T93d+Q+fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=subject:to:references:from:message-id :date:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc :content-transfer-encoding:content-type:sender; s=fm2; t= 1522381834; bh=r3Ay/0+s58ibQOm/bXyTvP7OkGpk5Y2yWq1KdylH52M=; b=J 0yQd1hvoh45/rmZDDRrgHOHiXb7OwYMAKX93JfZ01uEMixG4XKLV8dH79FRJ/WpN Qbf+74JNwmROjM+iHuARSr4RdCaGbIDUrhODvG+9jyYlfND3trrhtNwIke2iIQ6M 1saXKhqbhcS44KJKpjxZip3y4h94VU19YcGwMCgMX+QlhJLvvWBt0+Hu+yVx7j5v WDEcHWaoFMEu6RgiBM/xafh+xJ0lqX3Hu3xXF5TjDOAoBxOOsR2DsinciVxrGoeb pRaf9PV1z79TiH2TkAZWNeB+mSVAswykcrPBHzmw36bp13xF4OswWqeFOZLyFy9A a1tkWDmccdmoZ15r0Z+RQ== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered, 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=KYmisP5I x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-cm=none score=0; x-google-dkim=fail (message has been altered, 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=B25EBe6o; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=gmail.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128; x-vs=clean score=0 state=0 Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered, 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=KYmisP5I x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-cm=none score=0; x-google-dkim=fail (message has been altered, 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=B25EBe6o; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=gmail.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128; x-vs=clean score=0 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfLxDsgJCshKtCLpoNXE7O6Pdf7l3bK4SxN4Xd6ChuWTZ5l2h7KqI1y1HKsvqRCFjFpTCY3ugnyyZO2vzOheIMj2vmjWQ8k4zQQtP0Bkepm5v2dhQju8w h6AIWsYpaAbW2VWRWuubJEs8bC7DxaFFNpcsyYqzm3JUM0rGSsQUyOCPi2L/11QRxbWVDY1QZuJQLbqUtWQhd81Sk7k6DxVKOQ7+dPAqyOoMrYVj9R5Saamj +H4FUyFNUYG29T9QMySCQQ== X-CM-Analysis: v=2.3 cv=E8HjW5Vl c=1 sm=1 tr=0 a=28bQ1EhdAjTzU1YDPmtEKw==:117 a=28bQ1EhdAjTzU1YDPmtEKw==:17 a=kj9zAlcOel0A:10 a=x7bEGLp0ZPQA:10 a=tmjX-nCzVX8A:10 a=xqWC_Br6kY4A:10 a=4_-BN3WEXhEA:10 a=v2DPQv5-lfwA:10 a=-uNXE31MpBQA:10 a=jJxKW8Ag-pUA:10 a=DDOyTI_5AAAA:8 a=d7t9H59NRuQhWdtjDVAA:9 a=CjuIK1q_8ugA:10 a=_BcfOz0m4U4ohdxiHPKc:22 cc=dsc X-ME-CMScore: 0 X-ME-CMCategory: none X-Remote-Delivered-To: driverdev-devel@osuosl.org X-Google-Smtp-Source: AIpwx4+BsuRwPF6BDxG3sQERUMZSEsrt2N6u2P2taQFlSXZqE52Ixd2ma/vSk0wHjS/8zEcRpuTkLQ== Subject: Re: [PATCH v3] staging: vt6655: check for memory allocation failures To: Ji-Hun Kim References: <1522377844-23591-1-git-send-email-ji_hun.kim@samsung.com> <20180330033933.GA26489@ubuntu> From: Jia-Ju Bai Message-ID: Date: Fri, 30 Mar 2018 11:50:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20180330033933.GA26489@ubuntu> Content-Language: en-US X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, y.k.oh@samsung.com, gregkh@linuxfoundation.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr, forest@alittletooquiet.net, santhameena13@gmail.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 2018/3/30 11:39, Ji-Hun Kim wrote: > On Fri, Mar 30, 2018 at 11:15:03AM +0800, Jia-Ju Bai wrote: >> >> On 2018/3/30 10:44, Ji-Hun Kim wrote: >>> @@ -1165,10 +1205,18 @@ static int vnt_start(struct ieee80211_hw *hw) >>> } >>> dev_dbg(&priv->pcid->dev, "call device init rd0 ring\n"); >>> - device_init_rd0_ring(priv); >>> - device_init_rd1_ring(priv); >>> - device_init_td0_ring(priv); >>> - device_init_td1_ring(priv); >>> + ret = device_init_rd0_ring(priv); >>> + if (ret) >>> + goto error; >>> + ret = device_init_rd1_ring(priv); >>> + if (ret) >>> + goto error; >>> + ret = device_init_td0_ring(priv); >>> + if (ret) >>> + goto error; >>> + ret = device_init_td1_ring(priv); >>> + if (ret) >>> + goto error; >>> device_init_registers(priv); >>> @@ -1178,6 +1226,8 @@ static int vnt_start(struct ieee80211_hw *hw) >>> ieee80211_wake_queues(hw); >>> return 0; >>> +error: >>> + return ret; >>> } >> This code will lead to memory leaks when device_init_rd1_ring() >> fails, because the memory allocated by device_init_rd0_ring() is not >> freed. >> >> I think this one will be better: >> ret = device_init_rd0_ring(priv); >> if (ret) >> goto error_init_rd0_ring; >> ret = device_init_rd1_ring(priv); >> if (ret) >> goto error_init_rd1_ring; >> ret = device_init_td0_ring(priv); >> if (ret) >> goto error_init_td0_ring; >> ret = device_init_td1_ring(priv); >> if (ret) >> goto error_init_td1_ring; >> ...... >> error_init_td1_ring: >> device_free_td0_ring(priv); >> error_init_td0_ring: >> device_free_rd1_ring(priv); >> error_init_rd1_ring: >> device_free_rd0_ring(priv); >> error_init_rd0_ring: >> return ret; >> >> >> Best wishes, >> Jia-Ju Bai >> >> > But, those freeing function are already placed in the each device_init > functions for allocation fail like below. I think it is okay. I suppose that, for each device_init function, you only free the resources allocated in this function, and do not handle the resources in other functions. > @@ -550,20 +554,29 @@ static void device_init_rd0_ring(struct vnt_private *priv) > + return 0; > +error: > + device_free_rd0_ring(priv); > + return ret; This code is needed to free the resources allocated in this function. Best wishes, Jia-Ju Bai _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel