Re: [PATCH 4/5] bfa: Brocade BFA FC SCSI driver (makefile)

[Jing Huang <jhuang007@gmail.com>]

On Thu, Apr 2, 2009 at 9:36 PM, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
> On Wed, 2009-04-01 at 20:35 -0700, Krishna Gudipati wrote:
>> From: Krishna Chaitanya Gudipati <kgudipat@brocade.com>
>>
>> This patch contains Makefile and Kconfig file for scsi and bfa.Fixed
>> the code review comments from previous submission.
>>
>> Signed-off-by: Krishna Chaitanya Gudipati <kgudipat@brocade.com>
>> ---
>>  Kconfig      |    9 +++++++++
>>  Makefile     |    1 +
>>  bfa/Makefile |   27 +++++++++++++++++++++++++++
>>  3 files changed, 37 insertions(+)
>>
>> diff -urpN orig/drivers/scsi/Kconfig patch/drivers/scsi/Kconfig
>> --- orig/drivers/scsi/Kconfig 2009-04-01 20:08:49.271161000 -0700
>> +++ patch/drivers/scsi/Kconfig        2009-04-01 20:08:44.003822000 -0700
>> @@ -1797,6 +1797,15 @@ config SCSI_SRP
>>         To compile this driver as a module, choose M here: the
>>         module will be called libsrp.
>>
>> +config SCSI_BFA_FC
>> +     tristate "Brocade BFA Fibre Channel Support"
>> +     depends on PCI && SCSI
>> +     help
>> +       This bfa driver supports all Brocade PCIe Fibre Channel host adapters.
>> +
>> +       To compile this driver as a module, choose M here. The module will
>> +       be called bfa.
>> +
>
> You're still not using the FC transport class to export common sysfs FC
> information or to help make your driver smaller.  I thought you were
> going to fix this after this was noted in your first submission to
> linux-scsi on 24 September?
>
> James
>
>

Hi James,

We removed Brocade specific sysfs code after first linux-scsi
submission. Can you please
clarify where we are still not using the FC transport class to export
common sysfs FC
information? We do use the fc transport template to create the common
sysfs FC attributes
(in bfad_attr.c) under /sys/class/fc_host/<host#>

Thanks

Jing