mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
To: "Kiryl Shutsemau (Meta)" <kas@kernel.org>
Cc: Dev Jain <dev.jain@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	David Hildenbrand <david@kernel.org>,
	Mel Gorman <mgorman@techsingularity.net>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>,
	Brendan Jackman <brendan.jackman@linux.dev>,
	Zi Yan <ziy@nvidia.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-team@meta.com
Subject: Re: [PATCH] mm/compaction: sample empty pageblocks again from a random offset
Date: Mon, 16 Nov 2026 12:36:16 +0100	[thread overview]
Message-ID: <b6765576-0db0-498f-8564-3a0ecf420b37@kernel.org> (raw)
In-Reply-To: <avroysmflhyRZ42p@shutemov.name>

On 11/16/26 12:32, Kiryl Shutsemau (Meta) wrote:
> On Mon, Nov 16, 2026 at 09:38:29AM +0100, Vlastimil Babka (SUSE) wrote:
>> > IOW I think the probability this patch is going to have a downside is
>> > more than that of upside.
>> 
>> Agreed. This seems to all be based on a hypothetical scenario, only
>> constructed artificially to demonstrate it. A real-life motivation is needed.
> 
> Fair enough, let's drop it.
> 
> It is not entirely made up, though.
> 
> I stepped on it while testing another series. A fragmentation stress
> test gave bimodal results: no direct reclaim in most runs and hundreds
> to thousands of allocstalls in others.
> 
> It was confusing and looked like a regression in that series.
> 
> It took a bisection to find that the only thing that mattered was where
> the free pages fell relative to the stride grid. The test in the
> changelog was built after that, to show it on purpose.

Yeah I think it's better to make such stress tests randomized instead. Such
regularity might hit even other unintended effects.

> The workload is very artificial, but the fix looked simple enough to
> post.
> 


      reply	other threads:[~2026-11-16 11:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 10:17 Kiryl Shutsemau (Meta)
2026-11-14 18:11 ` Dev Jain
2026-11-16  8:38   ` Vlastimil Babka (SUSE)
2026-11-16 11:32     ` Kiryl Shutsemau (Meta)
2026-11-16 11:36       ` Vlastimil Babka (SUSE) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6765576-0db0-498f-8564-3a0ecf420b37@kernel.org \
    --to=vbabka@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=brendan.jackman@linux.dev \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=kas@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.com \
    --cc=surenb@google.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®