From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87560EB64DD for ; Wed, 2 Aug 2023 02:56:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231801AbjHBC4B (ORCPT ); Tue, 1 Aug 2023 22:56:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231140AbjHBCz5 (ORCPT ); Tue, 1 Aug 2023 22:55:57 -0400 Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3652D26A1 for ; Tue, 1 Aug 2023 19:55:55 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0Vot1lRb_1690944951; Received: from 30.97.48.77(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0Vot1lRb_1690944951) by smtp.aliyun-inc.com; Wed, 02 Aug 2023 10:55:52 +0800 Message-ID: Date: Wed, 2 Aug 2023 10:56:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 3/5] mm/compaction: merge end_pfn boundary check in isolate_freepages_range To: Kemeng Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: mgorman@techsingularity.net, willy@infradead.org, david@redhat.com References: <20230729174354.2239980-1-shikemeng@huaweicloud.com> <20230729174354.2239980-4-shikemeng@huaweicloud.com> From: Baolin Wang In-Reply-To: <20230729174354.2239980-4-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/30/2023 1:43 AM, Kemeng Shi wrote: > From: Kemeng Shi > > Merge the end_pfn boundary check for single page block forward and multiple > page blocks forward to avoid do twice boundary check for multiple page > blocks forward. > > Signed-off-by: Kemeng Shi LGTM. Reviewed-by: Baolin Wang > --- > mm/compaction.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 4a784872565a..65791a74c5e8 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -740,8 +740,6 @@ isolate_freepages_range(struct compact_control *cc, > /* Protect pfn from changing by isolate_freepages_block */ > unsigned long isolate_start_pfn = pfn; > > - block_end_pfn = min(block_end_pfn, end_pfn); > - > /* > * pfn could pass the block_end_pfn if isolated freepage > * is more than pageblock order. In this case, we adjust > @@ -750,9 +748,10 @@ isolate_freepages_range(struct compact_control *cc, > if (pfn >= block_end_pfn) { > block_start_pfn = pageblock_start_pfn(pfn); > block_end_pfn = pageblock_end_pfn(pfn); > - block_end_pfn = min(block_end_pfn, end_pfn); > } > > + block_end_pfn = min(block_end_pfn, end_pfn); > + > if (!pageblock_pfn_to_page(block_start_pfn, > block_end_pfn, cc->zone)) > break;