From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753882AbcJFOIh (ORCPT ); Thu, 6 Oct 2016 10:08:37 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:50222 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbcJFOI3 (ORCPT ); Thu, 6 Oct 2016 10:08:29 -0400 Subject: Re: [PATCH] serial: SERIAL_STM32 should depend on HAS_DMA To: Geert Uytterhoeven , Greg Kroah-Hartman , Jiri Slaby , Maxime Coquelin References: <1475762124-16609-1-git-send-email-geert@linux-m68k.org> CC: , From: Alexandre Torgue Message-ID: Date: Thu, 6 Oct 2016 16:08:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1475762124-16609-1-git-send-email-geert@linux-m68k.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.0.2] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-06_06:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On 10/06/2016 03:55 PM, Geert Uytterhoeven wrote: > If NO_DMA=y: > > drivers/built-in.o: In function `stm32_serial_remove': > stm32-usart.c:(.text+0xcea1a): undefined reference to `bad_dma_ops' > stm32-usart.c:(.text+0xcea7a): undefined reference to `bad_dma_ops' > > Add a dependency on HAS_DMA to fix this. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/tty/serial/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index c7831407a882d2bb..25c1d7bc010043b1 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -1625,6 +1625,7 @@ config SERIAL_SPRD_CONSOLE > config SERIAL_STM32 > tristate "STMicroelectronics STM32 serial port support" > select SERIAL_CORE > + depends on HAS_DMA > depends on ARM || COMPILE_TEST > help > This driver is for the on-chip Serial Controller on > I sent same kind of patch this morning (but mine have a bad copy paste). I will abandon my patch. However for this one: Acked-by: Alexandre Torgue regards Alex