mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>
Subject: Re: [PATCH v2] drm/xlnx/zynqmp-dpsub: Fix dependencies for COMPILE_TEST
Date: Wed, 6 May 2026 11:02:24 +0300	[thread overview]
Message-ID: <b67cc003-9944-4dbe-91ec-c7335dcf5c03@ideasonboard.com> (raw)
In-Reply-To: <20260505094716.1784225-1-wenst@chromium.org>

Hi,

On 05/05/2026 12:47, Chen-Yu Tsai wrote:
> The zynqmp-dpsub driver does not have build time dependencies on the PHY
> or DMA drivers. These are runtime hardware restrictions.
> 
> Make the two dependencies optional if COMPILE_TEST.
> 
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
> Changes since v1:
> - Keep each dependency on a separate line
> 
> IMO the two driver dependencies could be removed altogether, but that
> would be up to the driver and platform maintainers.
> ---
>   drivers/gpu/drm/xlnx/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xlnx/Kconfig b/drivers/gpu/drm/xlnx/Kconfig
> index cfabf5e2a0bb..58c19e5a7e8f 100644
> --- a/drivers/gpu/drm/xlnx/Kconfig
> +++ b/drivers/gpu/drm/xlnx/Kconfig
> @@ -3,8 +3,8 @@ config DRM_ZYNQMP_DPSUB
>   	depends on ARCH_ZYNQMP || COMPILE_TEST
>   	depends on COMMON_CLK && DRM && OF
>   	depends on DMADEVICES
> -	depends on PHY_XILINX_ZYNQMP
> -	depends on XILINX_ZYNQMP_DPDMA
> +	depends on PHY_XILINX_ZYNQMP || COMPILE_TEST
> +	depends on XILINX_ZYNQMP_DPDMA || COMPILE_TEST
>   	select DMA_ENGINE
>   	select DRM_CLIENT_SELECTION
>   	select DRM_DISPLAY_DP_HELPER

Thanks, pushed to drm-misc.

  Tomi


      reply	other threads:[~2026-05-06  8:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-05  9:47 Chen-Yu Tsai
2026-05-06  8:02 ` Tomi Valkeinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b67cc003-9944-4dbe-91ec-c7335dcf5c03@ideasonboard.com \
    --to=tomi.valkeinen@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=ville.syrjala@linux.intel.com \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®