mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jayesh Choudhary <j-choudhary@ti.com>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>,
	<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <c-vankar@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4-evm:quad-port-eth-exp1: Remove duplicate hogs
Date: Fri, 10 Jan 2025 16:20:15 +0530	[thread overview]
Message-ID: <b67cc247-0c96-493c-b048-315db295158a@ti.com> (raw)
In-Reply-To: <ybyexqc4ssjt5lkr76bfiaf7usmq7xto42byyboov5pjkdc4fn@wsj26klcliio>

Hello Siddharth,

Thank you for the review.

On 10/01/25 16:15, Siddharth Vadapalli wrote:
> On Fri, Jan 10, 2025 at 03:48:55PM +0530, Jayesh Choudhary wrote:
> 
> Hello Jayesh,
> 
> In the $subject of this patch, please use the overlay name as-is instead
> of adding the colon which splits the overlay name:
> s/k3-j784s4-evm:quad-port-eth-exp1/k3-j784s4-evm-quad-port-eth-exp1

I will fix this typo.

> 
>> The j784s4-evm board dts now has the gpio hogs for MUX2 after integration
>> of audio support.
>> Remove duplicate gpio-hogs from the overlay dtso to prevent mux probe
>> failures leading to can-phy3 deferred probe:
>> 'gpio-mux mux-controller: probe with driver gpio-mux failed with error -16'
> 
> This appears to be a fix since overlay functionality was broken since
> the commit which introduced audio support. Please add a "Fixes" tag
> to indicate this.
> 

Will add it in v2.

Warm Regards,
Jayesh

>>
>> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> 
> With the above comments addressed,
> 
> Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> 
> Regards,
> Siddharth.

      reply	other threads:[~2025-01-10 10:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 10:18 Jayesh Choudhary
2025-01-10 10:45 ` Siddharth Vadapalli
2025-01-10 10:50   ` Jayesh Choudhary [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b67cc247-0c96-493c-b048-315db295158a@ti.com \
    --to=j-choudhary@ti.com \
    --cc=c-vankar@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®