From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BB9FC433F5 for ; Fri, 7 Sep 2018 14:28:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C2AE2075E for ; Fri, 7 Sep 2018 14:28:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C2AE2075E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728669AbeIGTJd (ORCPT ); Fri, 7 Sep 2018 15:09:33 -0400 Received: from shelob.surriel.com ([96.67.55.147]:45468 "EHLO shelob.surriel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726295AbeIGTJd (ORCPT ); Fri, 7 Sep 2018 15:09:33 -0400 Received: from imladris.surriel.com ([96.67.55.152]) by shelob.surriel.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1fyHjy-0007PH-AR; Fri, 07 Sep 2018 10:28:06 -0400 Message-ID: Subject: Re: [RFC PATCH 1/2] mm: move tlb_table_flush to tlb_flush_mmu_free From: Rik van Riel To: Will Deacon Cc: Nicholas Piggin , Peter Zijlstra , torvalds@linux-foundation.org, luto@kernel.org, x86@kernel.org, bp@alien8.de, jannh@google.com, ascannell@google.com, dave.hansen@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Miller , Martin Schwidefsky , Michael Ellerman , linux-arch@vger.kernel.org Date: Fri, 07 Sep 2018 10:28:05 -0400 In-Reply-To: <20180907134359.GA12187@arm.com> References: <20180823084709.19717-1-npiggin@gmail.com> <20180823084709.19717-2-npiggin@gmail.com> <20180907134359.GA12187@arm.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-IFHu9I6W7+At+9sCwKHu" X-Mailer: Evolution 3.28.5 (3.28.5-1.fc28) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-IFHu9I6W7+At+9sCwKHu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2018-09-07 at 14:44 +0100, Will Deacon wrote: > On Thu, Sep 06, 2018 at 04:29:59PM -0400, Rik van Riel wrote: > > On Thu, 2018-08-23 at 18:47 +1000, Nicholas Piggin wrote: > > > There is no need to call this from tlb_flush_mmu_tlbonly, it > > > logically belongs with tlb_flush_mmu_free. This allows some > > > code consolidation with a subsequent fix. > > >=20 > > > Signed-off-by: Nicholas Piggin > >=20 > > Reviewed-by: Rik van Riel > >=20 > > This patch also fixes an infinite recursion bug > > with CONFIG_HAVE_RCU_TABLE_FREE enabled, which > > has this call trace: > >=20 > > tlb_table_flush > > -> tlb_table_invalidate > > -> tlb_flush_mmu_tlbonly > > -> tlb_table_flush > > -> ... (infinite recursion) > >=20 > > This should probably be applied sooner rather than > > later. >=20 > It's already in mainline with a cc stable afaict. Sure enough, it is. I guess I have too many kernel trees on this system, and was looking at the wrong one somehow. --=20 All Rights Reversed. --=-IFHu9I6W7+At+9sCwKHu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAluSivUACgkQznnekoTE 3oPhFwf/Qd/rrFLYEKAcJENv34o7Gk0YNVmPKKhyg9sj8nteRac1mnyeVpqmXfWW 4yDdUx6glji8FWttmnTcpbb/frJlwsKFYBsoYDxBc/D73sTf+3Q8aAbhYAYGzcDq GNANhQ1BQXNHL5YfEZtpCFha66ZpAAPEMr+1PI6/k4oMWIOW+EqXko92WP+Vwr9I jfYaqKq9UfwFmy/ftaynlXP8yQjlSc2mYTA1SOEuAyiquvBH3TZo2f7bALCA1wP/ i0lLnEPvFwlgxXDg5l2d/aQxbW4j2KnFLZ3AJMZpPhTfcWanSVSpkxOfZlmXQnPp DgV4H7ZrKkvWgRg8+/l1CpXX4ulpRA== =4rvN -----END PGP SIGNATURE----- --=-IFHu9I6W7+At+9sCwKHu--