From: Guenter Roeck <linux@roeck-us.net>
To: Cryolitia PukNgae <cryolitia@uniontech.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
niecheng1@uniontech.com, zhanjun@uniontech.com,
kylon <3252255+kylon@users.noreply.github.com>
Subject: Re: [PATCH] hwmon: (gpd-fan) initialize EC on driver load for Win 4
Date: Sun, 2 Nov 2025 11:08:32 -0800 [thread overview]
Message-ID: <b68d88b8-0eaf-4f9a-a847-befd95659c5c@roeck-us.net> (raw)
In-Reply-To: <20251030-win4-v1-1-c374dcb86985@uniontech.com>
On Thu, Oct 30, 2025 at 10:30:06PM +0800, Cryolitia PukNgae wrote:
> From: Cryolitia PukNgae <cryolitia@uniontech.com>
>
> The original implement will re-init the EC when it reports a zero
> value, and it's a workaround for the black box buggy firmware.
>
> Now a contributer test and report that, the bug is that, the firmware
> won't initialize the EC on boot, so the EC ramains in unusable status.
> And it won't need to re-init it during runtime. The original implement
> is not perfect, any write command will be ignored until we first read
> it. Just re-init it unconditionally when the driver load could work.
>
> Fixes: 0ab88e239439 ("hwmon: add GPD devices sensor driver")
> Co-developed-by: kylon <3252255+kylon@users.noreply.github.com>
> Signed-off-by: kylon <3252255+kylon@users.noreply.github.com>
> Link: https://github.com/Cryolitia/gpd-fan-driver/pull/20
> Signed-off-by: Cryolitia PukNgae <cryolitia@uniontech.com>
Applied.
Thanks,
Guenter
prev parent reply other threads:[~2025-11-02 19:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 14:30 Cryolitia PukNgae via B4 Relay
2025-11-02 19:08 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b68d88b8-0eaf-4f9a-a847-befd95659c5c@roeck-us.net \
--to=linux@roeck-us.net \
--cc=3252255+kylon@users.noreply.github.com \
--cc=cryolitia@uniontech.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niecheng1@uniontech.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®