Re: [PATCH v13,0/3] Add dpi output format control for MT8186

["Xinlei Lee (李昕磊)" <Xinlei.Lee@mediatek.com>]

On Tue, 2022-11-08 at 19:27 +0100, Matthias Brugger wrote:
> Hi Xinlei,
> 
> Somehow b4 broke with your thread but I was able to apply patch 1 and
> 2 by hand.
> 
> Thanks
> Matthias
> 
> On 24/10/2022 04:04, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > 
> > Base on the branch of linus/master v6.1 rc1.
> > 
> > Change since v12:
> > 1. Add MT8186_ prefix to variables added in mt8186-mmsys.h file.
> > 
> > Change since v11:
> > 1. Rebase on v6.1-rc1. Change nothing.
> > 
> > Change since v10:
> > 1. Modify patch title and add review tag.
> > 
> > Change since v9:
> > 1. Modify the location of the mmsys_dev member variable.
> > 
> > Change since v8:
> > 1. Modified the title and some description information.
> > 
> > Changes since v7:
> > 1. This series is based on the following patch:
> >     [1] soc: mediatek: Add mmsys func to adapt to dpi output for
> > MT8186
> >     
> > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/1663161662-1598-2-git-send-email-xinlei.lee@mediatek.com/__;!!CTRNKA9wMg0ARbw!3tXTL3P6SgcP8Q_rcyCro64dxIXE6VuVbcNftU0ZnX6TNtU1akXwd96YfnoJs_fEig$
> >  
> > 2. Modify the DPI_FORMAT_MASK macro definition to GENMASK(1, 0);
> > 3. Add all settings to mtk_mmsys_ddp_dpi_fmt_config;
> > 4. Modify the commit title to Add mt8186 dpi compatibles and
> > platform
> > data.
> > 
> > Changes since v6:
> > 1. Different from other ICs, when mt8186 DPI changes the output
> > format,
> > the mmsys_base+400 register needs to be set to be valid at the same
> > time.
> >     In this series, all the situations that mmsys need to be set up
> > are
> > perfected (not necessarily used in practice).
> > 2. Put the value that controls the mmsys function in mtk-mmsys.h.
> > 3. Encountered the sink ic switched between dual edge and single
> > edge,
> > perfected setting and clearing mmsys bit operations in mtk_dpi.c.
> > 
> > Changes since v5:
> > 1. Separate the patch that adds edge_cfg_in_mmsys from the patch
> > that
> > adds mt8186 dpi support.
> > 2. Move the mmsys register definition to mmsys driver.
> >   
> > Changes since v4:
> > 1. This series of cancellations is based on the following patches:
> >     [1] Add MediaTek SoC(vdosys1) support for mt8195
> >     
> > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/cover/20220711075245.10492-1-nancy.lin@mediatek.com/__;!!CTRNKA9wMg0ARbw!3tXTL3P6SgcP8Q_rcyCro64dxIXE6VuVbcNftU0ZnX6TNtU1akXwd96Yfnqv0_QYpg$
> >  
> >     [2] Add MediaTek SoC DRM (vdosys1) support for mt8195
> >     
> > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/cover/20220804072827.22383-1-nancy.lin@mediatek.com/__;!!CTRNKA9wMg0ARbw!3tXTL3P6SgcP8Q_rcyCro64dxIXE6VuVbcNftU0ZnX6TNtU1akXwd96YfnoZMZ_peA$
> >  
> > 2. Added mtk_mmsys_update_bits function in mtk-mmsys.c;
> > 3. MMSYS 0x400 register is modified to
> > MT8186_MMSYS_DPI_OUTPUT_FORMAT;
> > 4. Fix formatting issues.
> > 
> > Changes since v3:
> > 1. Fix formatting issues;
> > 2. Modify the edge output control name & description;
> > 3. Fix the threading problem.
> > 
> > Changes since v2:
> > 1. Modify key nouns in the description;
> > 2. Add the label of jitao to Co-developed-by;
> > 3. Macro definition address lowercase problem and function naming;
> > 4. Add missing a description of this property in the mtk_dpi_conf.
> > 
> > Change since v1:
> > 1. Modify mt8186 compatiable location.
> > 2. Modify MT8186_DPI_OUTPUT_FORMAT name.
> > 
> > When MT8186 outputs dpi signal, it is necessary to add dual edge
> > output
> > format control in mmsys.
> > 
> > Xinlei Lee (3):
> >    soc: mediatek: Add all settings to mtk_mmsys_ddp_dpi_fmt_config
> > func
> >    drm: mediatek: Set dpi format in mmsys
> >    drm: mediatek: Add mt8186 dpi compatibles and platform data
> > 
> >   drivers/gpu/drm/mediatek/mtk_dpi.c     | 32
> > ++++++++++++++++++++++++++
> >   drivers/gpu/drm/mediatek/mtk_drm_drv.c |  2 ++
> >   drivers/soc/mediatek/mt8186-mmsys.h    |  8 ++++---
> >   drivers/soc/mediatek/mtk-mmsys.c       | 27 +++++++++++++++++--
> > ---
> >   include/linux/soc/mediatek/mtk-mmsys.h |  7 ++++++
> >   5 files changed, 67 insertions(+), 9 deletions(-)
> > 

Hi Matthias:

Is your problem solved?

I tried to pull the series in link[1] to the kernel 6.1-rc1 version, 
the patches are all successfully applied, and the patch in link[1] 
looks complete.

If you still think there is something wrong, please let me know and I 
can send a new version to try to fix it.

[1]: 
https://patchwork.kernel.org/project/linux-mediatek/cover/1666577099-3859-1-git-send-email-xinlei.lee@mediatek.com/

Best Regards!
xinlei