From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932615AbeCLGzE (ORCPT ); Mon, 12 Mar 2018 02:55:04 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:52852 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932575AbeCLGzC (ORCPT ); Mon, 12 Mar 2018 02:55:02 -0400 Subject: Re: [PATCH][rds-next] rds: make functions rds_info_from_znotifier and rds_message_zcopy_from_user static To: Colin King , "David S . Miller" , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180311170340.27696-1-colin.king@canonical.com> From: "santosh.shilimkar@oracle.com" Organization: Oracle Corporation Message-ID: Date: Sun, 11 Mar 2018 23:54:56 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180311170340.27696-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8829 signatures=668690 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=607 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803120081 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/11/18 10:03 AM, Colin King wrote: > From: Colin Ian King > > Functions rds_info_from_znotifier and rds_message_zcopy_from_user are > local to the source and do not need to be in global scope, so make them > static. > > Cleans up sparse warnins: > net/rds/message.c:70:27: warning: symbol 'rds_info_from_znotifier' was > not declared. Should it be static? > net/rds/message.c:358:5: warning: symbol 'rds_message_zcopy_from_user' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King > --- > net/rds/message.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Acked-by: Santosh Shilimkar