From: Guenter Roeck <linux@roeck-us.net>
To: remy@demangeot.net, "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Eugene Shalygin <eugene.shalygin@gmail.com>
Cc: Armin Wolf <W_Armin@gmx.de>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2 0/2] ACPI: EC / hwmon: (asus-ec-sensors) use ec.c for the MAXIMUS IX EXTREME second EC
Date: Thu, 29 Oct 2026 11:41:04 -0700 [thread overview]
Message-ID: <b694a150-6bca-4070-a025-ab3520bc2a87@roeck-us.net> (raw)
In-Reply-To: <20261029-m9e-ec2-v2-0-e9c4e2ba8415@demangeot.net>
On 10/29/26 00:48, Remy Demangeot via B4 Relay wrote:
> This replaces patch 3/3 of the series "hwmon: (asus-ec-sensors) more
> MAXIMUS IX EXTREME sensors" [1]. Patches 1/3 and 2/3 of that series
> only use the main EC and are unchanged.
>
> Eugene asked to operate the second EC through drivers/acpi/ec.c rather
> than re-implementing the EC protocol in the driver [2]. Patch 1 adds a
> small API to ec.c for an EC that is not described in the ACPI tables:
> acpi_ec_create_polled() / acpi_ec_destroy_polled() and byte accessors.
> Such an EC only uses busy polling: no GPE, no IRQ, no query events and
> no address space handler. Patch 2 uses it in asus-ec-sensors.
>
> To answer Armin's question [3]: no, this EC is not described in the
> ACPI tables of this board (BIOS 1501). There is no PNP0C09 device for
> it; only the WMI method \_SB.AMW0.WLDF writes to ports 0x68/0x6c
> directly, without taking any lock. The other PNP0C09 device, H_EC, is
> a reference-code stub whose _STA returns 0.
>
> Guenter, please drop v1 3/3: it sorted the sensor banks as signed
Dropped, but please next time provide the patch subject. I understand you
know what that was, but I already had 80 patches queued for 7.5, including
five for this driver. I dropped what I _think_ was patch 3/3, which is
the water temperature patch. If that is not what you intended, please resend
everything that is not already in the mainline kernel.
Guenter
> values, so the second EC bank came first, the second EC was never set
> up, and no sensor of the board could be read anymore. This is fixed in
> patch 2 and was found while testing this series.
>
> Both patches were tested on a MAXIMUS IX EXTREME with Secure Boot
> enabled: the four water temperatures read correctly, 300
> consecutive reads gave no error, and the I/O ports are released and
> requested again when the module is reloaded.
>
> Patch 1 needs an ack from the ACPI side; patch 2 depends on it.
>
> [1] https://lore.kernel.org/r/20261026-b4-m9e-ext-sensors-v1-0-644d389b2de1@demangeot.net
> [2] https://lore.kernel.org/r/CAB95QAQaogxV6KO5kpv9RBpzhhmH_N3Dvvy=nqWHOG6qAQB_aw@mail.gmail.com
> [3] Armin Wolf, reply to v1 3/3, 28 Oct 2026
>
> ---
> Remy Demangeot (2):
> ACPI: EC: allow drivers to create a polled EC
> hwmon: (asus-ec-sensors) add water temperatures for MAXIMUS IX EXTREME
>
> drivers/acpi/ec.c | 89 ++++++++++++++++++++++++++++++++-
> drivers/hwmon/asus-ec-sensors.c | 108 ++++++++++++++++++++++++++++++++++------
> include/linux/acpi.h | 8 +++
> 3 files changed, 189 insertions(+), 16 deletions(-)
> ---
> base-commit: b27578907b9dd74db5e9b397bf063c43719c162b
> change-id: 20261029-m9e-ec2-68fad8c08d5a
>
> Best regards,
prev parent reply other threads:[~2026-10-29 18:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 7:48 Remy Demangeot via B4 Relay
2026-10-29 7:48 ` [PATCH v2 1/2] ACPI: EC: allow drivers to create a polled EC Remy Demangeot via B4 Relay
2026-10-29 7:48 ` [PATCH v2 2/2] hwmon: (asus-ec-sensors) add water temperatures for MAXIMUS IX EXTREME Remy Demangeot via B4 Relay
2026-10-29 18:41 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b694a150-6bca-4070-a025-ab3520bc2a87@roeck-us.net \
--to=linux@roeck-us.net \
--cc=W_Armin@gmx.de \
--cc=eugene.shalygin@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=remy@demangeot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®