mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] video: fbdev: omap: Remove unnecessary print function dev_err()
Date: Wed, 24 Aug 2022 21:56:22 +0200	[thread overview]
Message-ID: <b696b6cc-7cd4-4f62-6289-6f29c1e40214@gmx.de> (raw)
In-Reply-To: <20220824114455.5167-1-jiapeng.chong@linux.alibaba.com>

On 8/24/22 13:44, Jiapeng Chong wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> ./drivers/video/fbdev/omap/omapfb_main.c:1653:2-9: line 1653 is redundant because platform_get_irq() already prints an error.
> ./drivers/video/fbdev/omap/omapfb_main.c:1646:2-9: line 1646 is redundant because platform_get_irq() already prints an error.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1957
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

applied.

Thanks!
Helge

> ---
>  drivers/video/fbdev/omap/omapfb_main.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
> index fbb3af883d4d..17cda5765683 100644
> --- a/drivers/video/fbdev/omap/omapfb_main.c
> +++ b/drivers/video/fbdev/omap/omapfb_main.c
> @@ -1643,14 +1643,12 @@ static int omapfb_do_probe(struct platform_device *pdev,
>  	}
>  	fbdev->int_irq = platform_get_irq(pdev, 0);
>  	if (fbdev->int_irq < 0) {
> -		dev_err(&pdev->dev, "unable to get irq\n");
>  		r = ENXIO;
>  		goto cleanup;
>  	}
>
>  	fbdev->ext_irq = platform_get_irq(pdev, 1);
>  	if (fbdev->ext_irq < 0) {
> -		dev_err(&pdev->dev, "unable to get irq\n");
>  		r = ENXIO;
>  		goto cleanup;
>  	}


      reply	other threads:[~2022-08-24 19:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-24 11:44 Jiapeng Chong
2022-08-24 19:56 ` Helge Deller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b696b6cc-7cd4-4f62-6289-6f29c1e40214@gmx.de \
    --to=deller@gmx.de \
    --cc=abaci@linux.alibaba.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®