From: Paolo Bonzini <pbonzini@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>, Alexander Graf <agraf@suse.de>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
linux-mips@linux-mips.org, linux-arm-kernel@lists.infradead.org,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"James Hogan" <james.hogan@imgtec.com>,
"Christoffer Dall" <cdall@linaro.org>,
"Paul Mackerras" <paulus@ozlabs.org>,
"David Hildenbrand" <david@redhat.com>
Subject: Re: [PATCH RFC 0/2] KVM: use RCU to allow dynamic kvm->vcpus array
Date: Thu, 17 Aug 2017 11:16:59 +0200 [thread overview]
Message-ID: <b69bc1e0-9d7b-5412-ba56-a5261d539a5b@redhat.com> (raw)
In-Reply-To: <20170817093612.024cc4bc.cohuck@redhat.com>
On 17/08/2017 09:36, Cornelia Huck wrote:
>> What if we just sent a "vcpu move" request to all vcpus with the new
>> pointer after it moved? That way the vcpu thread itself would be
>> responsible for the migration to the new memory region. Only if all
>> vcpus successfully moved, keep rolling (and allow foreign get_vcpu again).
>>
>> That way we should be basically lock-less and scale well. For additional
>> icing, feel free to increase the vcpu array x2 every time it grows to
>> not run into the slow path too often.
>
> I'd prefer the rcu approach: This is a mechanism already understood
> well, no need to come up with a new one that will likely have its own
> share of problems.
What Alex is proposing _is_ RCU, except with a homegrown
synchronize_rcu. Using kvm->srcu seems to be the best of both worlds.
Paolo
next prev parent reply other threads:[~2017-08-17 9:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 19:40 Radim Krčmář
2017-08-16 19:40 ` [PATCH RFC 1/2] KVM: remove unused __KVM_HAVE_ARCH_VM_ALLOC Radim Krčmář
2017-08-21 13:48 ` Christian Borntraeger
2017-08-16 19:40 ` [PATCH RFC 2/2] KVM: RCU protected dynamic vcpus array Radim Krčmář
2017-08-17 8:07 ` Cornelia Huck
2017-08-17 11:14 ` David Hildenbrand
2017-08-17 16:50 ` Radim Krčmář
2017-08-17 16:54 ` Paolo Bonzini
2017-08-17 7:04 ` [PATCH RFC 0/2] KVM: use RCU to allow dynamic kvm->vcpus array Alexander Graf
2017-08-17 7:36 ` Cornelia Huck
2017-08-17 9:16 ` Paolo Bonzini [this message]
2017-08-17 9:28 ` Cornelia Huck
2017-08-17 9:44 ` Paolo Bonzini
2017-08-17 9:55 ` David Hildenbrand
2017-08-17 10:18 ` Paolo Bonzini
2017-08-17 10:20 ` David Hildenbrand
2017-08-17 10:23 ` Paolo Bonzini
2017-08-17 10:31 ` David Hildenbrand
2017-08-17 14:54 ` Radim Krčmář
2017-08-17 19:17 ` Alexander Graf
2017-08-18 14:10 ` Radim Krčmář
2017-08-18 14:22 ` Marc Zyngier
2017-08-17 7:29 ` David Hildenbrand
2017-08-17 7:37 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b69bc1e0-9d7b-5412-ba56-a5261d539a5b@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cdall@linaro.org \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=paulus@ozlabs.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®