From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753134AbeAIJsV (ORCPT + 1 other); Tue, 9 Jan 2018 04:48:21 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33487 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752613AbeAIJsP (ORCPT ); Tue, 9 Jan 2018 04:48:15 -0500 X-Google-Smtp-Source: ACJfBos6u+soud6NITP9va91HihLhSZnt2vwRC2RUGHTFpiOkjg9OotVGmQX1NTSUqytiVqvzvEddg== Subject: Re: [PATCH 2/2] slimbus: qcom-ctrl: Fix devm_ioremap_resource() error handling To: Dan Carpenter Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Greg Kroah-Hartman References: <20180109092644.wa4ubwxkcvc3lyza@mwanda> From: Srinivas Kandagatla Message-ID: Date: Tue, 9 Jan 2018 09:48:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20180109092644.wa4ubwxkcvc3lyza@mwanda> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 09/01/18 09:26, Dan Carpenter wrote: > devm_ioremap_resource() returns error pointers, not NULL so the check > needs to be fixed. > > Fixes: ad7fcbc308b0 ("slimbus: qcom: Add Qualcomm Slimbus controller driver") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c > index 3ab59209cbdc..6bf95bf33299 100644 > --- a/drivers/slimbus/qcom-ctrl.c > +++ b/drivers/slimbus/qcom-ctrl.c > @@ -528,9 +528,9 @@ static int qcom_slim_probe(struct platform_device *pdev) > > slim_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ctrl"); > ctrl->base = devm_ioremap_resource(ctrl->dev, slim_mem); > - if (!ctrl->base) { > + if (IS_ERR(ctrl->base)) { > dev_err(&pdev->dev, "IOremap failed\n"); > - return -ENOMEM; > + return PTR_ERR(ctrl->base); > } > > sctrl->set_laddr = qcom_set_laddr; > Already fixed at: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1575797.html