From: "Jeff Chua" <jeff.chua.linux@gmail.com>
To: "Jean-Marc Valin" <Jean-Marc.Valin@usherbrooke.ca>
Cc: "Jeremy Fitzhardinge" <jeremy@goop.org>,
"Linux Kernel" <linux-kernel@vger.kernel.org>,
cpufreq@lists.linux.org.uk
Subject: Re: Suspend to RAM regression tracked down
Date: Mon, 3 Jul 2006 14:08:55 +0800 [thread overview]
Message-ID: <b6a2187b0607022308k361c9664uef9d521db10f4d08@mail.gmail.com> (raw)
In-Reply-To: <1151880764.5358.32.camel@idefix.homelinux.org>
Can you try 2.6.17 with this patch from Greg. I had same problem on my
IBM X60s, as you mentioned ... sometimes, can't resume after a few
suspend/resume cycles. But this patch seems to do the trick even if I
don't load USB modules sometimes.
Subject: USB: get USB suspend to work again
Yeah, it's a hack, but it is only temporary until Alan's patches
reworking this area make it in. We really should not care what devices
below us are doing, especially when we do not really know what type of
devices they are. This patch relies on the fact that the endpoint
devices do not have a driver assigned to us.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/usb/core/usb.c | 2 ++
1 file changed, 2 insertions(+)
--- gregkh-2.6.orig/drivers/usb/core/usb.c
+++ gregkh-2.6/drivers/usb/core/usb.c
@@ -991,6 +991,8 @@ void usb_buffer_unmap_sg (struct usb_dev
static int verify_suspended(struct device *dev, void *unused)
{
+ if (dev->driver == NULL)
+ return 0;
return (dev->power.power_state.event == PM_EVENT_ON) ? -EBUSY : 0;
}
On 7/3/06, Jean-Marc Valin <Jean-Marc.Valin@usherbrooke.ca> wrote:
> > There was a race in ondemand and conservative which made them lock up on
> > resume (possibly only on SMP systems though). There's a patch for that
> > in current -mm, but I suspect there's another problem (still haven't had
> > any time to track it down).
>
> Any link to the patch and the thread about the problem (if any)? Also,
> was the race introduced in 2.6.12-rc5-git6? If not, it's a completely
> different problem because my machine worked fine with 2.6.12-rc5-git5.
next prev parent reply other threads:[~2006-07-03 6:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-02 10:47 Jean-Marc Valin
2006-07-02 18:06 ` Jeremy Fitzhardinge
2006-07-02 22:52 ` Jean-Marc Valin
2006-07-03 6:02 ` Jeremy Fitzhardinge
2006-07-03 6:31 ` Jean-Marc Valin
2006-07-03 6:08 ` Jeff Chua [this message]
2006-07-07 11:25 ` Jean-Marc Valin
2006-07-07 16:21 ` Dave Jones
2006-07-07 22:48 ` Jean-Marc Valin
2006-07-08 6:23 ` Dave Jones
2006-07-08 22:55 ` Jean-Marc Valin
2006-07-09 3:21 ` Dave Jones
2006-07-09 5:28 ` Jean-Marc Valin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6a2187b0607022308k361c9664uef9d521db10f4d08@mail.gmail.com \
--to=jeff.chua.linux@gmail.com \
--cc=Jean-Marc.Valin@usherbrooke.ca \
--cc=cpufreq@lists.linux.org.uk \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®