commit 64ff3b938ec6782e6585a83d5459b98b0c3f6eb8 breaks rlogin

[Jeff Chua <jeff.chua.linux@gmail.com>]

The following commit breaks "rlogin". Symptom is the terminal just
hangs before login to the remote machine. No error, just the cursor
never come back. "~." or type "exit" will exit from remote session.
Only happens "sometimes". Happens more often if you try many times.

I've reverted the commit, and rlogin works now.

Thanks,
Jeff.



commit 64ff3b938ec6782e6585a83d5459b98b0c3f6eb8
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date:   Thu Dec 25 17:12:58 2008 -0800

    tcp: Always set urgent pointer if it's beyond snd_nxt

    Our TCP stack does not set the urgent flag if the urgent pointer
    does not fit in 16 bits, i.e., if it is more than 64K from the
    sequence number of a packet.

    This behaviour is different from the BSDs, and clearly contradicts
    the purpose of urgent mode, which is to send the notification
    (though not necessarily the associated data) as soon as possible.
    Our current behaviour may in fact delay the urgent notification
    indefinitely if the receiver window does not open up.

    Simply matching BSD however may break legacy applications which
    incorrectly rely on the out-of-band delivery of urgent data, and
    conversely the in-band delivery of non-urgent data.