From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 265A0C2BB41 for ; Tue, 16 Aug 2022 10:07:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233276AbiHPKHt (ORCPT ); Tue, 16 Aug 2022 06:07:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232542AbiHPKHN (ORCPT ); Tue, 16 Aug 2022 06:07:13 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 307A858B5A for ; Tue, 16 Aug 2022 02:23:31 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id e15so14117542lfs.0 for ; Tue, 16 Aug 2022 02:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=xqmZkTjqkBszJr4LKjJt2ehtVUvSW3sFkYgqkkGWDf4=; b=yj+1nFMppjyZXIpFnjKZvFDRpcKZwm+a4RWh+1tgO9xkQqZ5ouieOYtGDdckwPCLkD uFNRzJohXUEtJkdoEMQud0/N66NTYI0UV0uWL9W2sOWN2DPcWtt6PVdBw5MjNIDJIYgz 7z1qS3BhvROOXNwNVdMCiNBn+hCwboOkqh+EliX/jOaVubo4IIFegvDhncPRP9id2YSy zJ2KMbORQuM3hcHWwWAxXLHMYeN11+ZOS0NSe132Auln0y3rEuRGL4zv++iOnJSGhjZc kbibfmoOvPb7P4Gyx7pJH4QHOwiW9cdScaGQsSqohEUl4AfB3xEzQnP61EQFQQFRh6Y2 8OPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=xqmZkTjqkBszJr4LKjJt2ehtVUvSW3sFkYgqkkGWDf4=; b=2Qgk4RxK1Y3XCHljSiAGlvCZC7kS0l33h4ev6p4jWxQQ2D5jg38lLvjk+Mj1/B8W+0 fYLWPBquuC4o8VETxusweLsrgaNkytEcaUT9biG55ZLF6mHIv6JjFwBTwdRABOjrhbxK HycN8vqiShZiSm+TnpVnyxk8BWskdEgNFlBCMpAD5CkDAFzGKKkd/TQB5gx4kOpdZyRg Ox3UajaeV0zqFnHFiqdvFbtfVpYTpf2v9ri8earI1PIgyd6tPhGi8fEBZjuwez0+rYnA KevfuTLnPd9kzNeQ9KZfz2UIjdJswi6/f6RIOOvJ4zGnjpQT8QW0erMG9qBStbabKfKy 2tIw== X-Gm-Message-State: ACgBeo2vH27nnxM08jhaQXgGIXYCBFMz4vrbhNxnSQ8E55vumv/NNEIW lS+eAmjxeKoq9i5lRHR08qv7Aw== X-Google-Smtp-Source: AA6agR5+nNwI8d3IuOAHqLUOx1QI0JR8HQgP2AKO07DOADBkCQC3TdTrDgt0+LLhBk+z2F6rApxi6Q== X-Received: by 2002:a19:5e02:0:b0:48b:1870:dc4 with SMTP id s2-20020a195e02000000b0048b18700dc4mr7462376lfb.4.1660641809597; Tue, 16 Aug 2022 02:23:29 -0700 (PDT) Received: from ?IPV6:2001:14bb:ae:539c:1782:dd68:b0c1:c1a4? (d15l54g8c71znbtrbzt-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1782:dd68:b0c1:c1a4]) by smtp.gmail.com with ESMTPSA id x25-20020a056512131900b0048a0e948c34sm1325631lfu.195.2022.08.16.02.23.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 02:23:29 -0700 (PDT) Message-ID: Date: Tue, 16 Aug 2022 12:23:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before registering them Content-Language: en-US From: Krzysztof Kozlowski To: Saravana Kannan , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , Linus Walleij Cc: kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220727013349.3056826-1-saravanak@google.com> <49e4f45a-51da-ec4c-9ebb-dfa022bf8a88@linaro.org> In-Reply-To: <49e4f45a-51da-ec4c-9ebb-dfa022bf8a88@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/07/2022 11:32, Krzysztof Kozlowski wrote: > On 27/07/2022 03:33, Saravana Kannan wrote: >> As soon as a gpio is registered, it should be usable by a consumer. So, >> do all the initialization before registering the gpios. Without this >> change, a consumer can request a GPIO IRQ and have the gpio to IRQ >> mapping fail. >> >> Signed-off-by: Saravana Kannan > > Looks good. > > Linus, > It's too late for me to pick it up, so make you could grab it directly? > > Reviewed-by: Krzysztof Kozlowski > > Otherwise it will wait for merge window to finish. Applied. Best regards, Krzysztof