From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95DFC18E77E; Tue, 20 Aug 2024 15:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724166809; cv=none; b=UYTtyZxh1CniaaaPU6xO11+L9aTV9ZB0vKp9seKmBWASO/qmjM3/+Ui4Lyl1HyXVYTNnzmQJI75mMPdDrnZYh5z9TDEvNv7VDLOyU9I1Lm17BZJCy41SjXiwUDCZ058Dn/bbMF+tkyelavotqis7s5WtVVxSSvGvYEYuuZVt42I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724166809; c=relaxed/simple; bh=nx9vrFwlguPTFdqzU9bhEKj89KFYe5EAZmmSAToxOts=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=TburPOSpv30XdEVR6SyDLem/gDJ3zBV3476MuyDypYDz+KuX/d+aWoXDXcZlgrGPZ2pkAheHEMJuw6So9G3Djq+pjc44NoalV4UeUcJxc5RQ7cn3lcXqDcBPCIohZwTMBJGKlPNMaEW+LSaMVyF/qkOEf9yXLrDf54rM4BAW5os= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=FvkDKqSZ; arc=none smtp.client-ip=198.47.19.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="FvkDKqSZ" Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 47KFDL2S012088; Tue, 20 Aug 2024 10:13:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1724166801; bh=A3/76qLgq/8QK9n1BPUq/kYGt62Cg6kwN2Elf5HOzG4=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=FvkDKqSZ4s/jh7Qbm+cDsVx/GwNOrQdkvDnVDwLOMqv3AmKXa/kjUesv/gcMCjUoS 0hXjrClVQrb2YXWi3aIAO5Ipbll9unGWh5b4tohZ5DY5l7WTiGTMjP2il4bVhpdTzT Wv9wlpCZnIXwd2eDU1DoCY1Q5PEhxWeXWNQa/6kc= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 47KFDLJn014437 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 20 Aug 2024 10:13:21 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 20 Aug 2024 10:13:20 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 20 Aug 2024 10:13:20 -0500 Received: from [10.249.42.149] ([10.249.42.149]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 47KFDKx7047995; Tue, 20 Aug 2024 10:13:20 -0500 Message-ID: Date: Tue, 20 Aug 2024 10:13:20 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] arm64: dts: k3-am62a-wakeup: Add R5F device node To: Hari Nagalla , , , , , , , CC: , , References: <20240820104034.15607-1-hnagalla@ti.com> <20240820104034.15607-4-hnagalla@ti.com> Content-Language: en-US From: Andrew Davis In-Reply-To: <20240820104034.15607-4-hnagalla@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 On 8/20/24 5:40 AM, Hari Nagalla wrote: > From: Devarsh Thakkar > > AM62A SoCs have a single R5F core in waekup domain. This core is also > used as a device manager for the SoC. > > Signed-off-by: Devarsh Thakkar > Signed-off-by: Hari Nagalla > --- > arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi | 23 +++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi > index f5ac101a04df..c4319986e660 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi > @@ -76,6 +76,29 @@ wkup_rti0: watchdog@2b000000 { > status = "reserved"; > }; > > + wkup_r5fss0: r5fss@78000000 { > + compatible = "ti,am62-r5fss"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x78000000 0x00 0x78000000 0x8000>, > + <0x78100000 0x00 0x78100000 0x8000>; > + power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>; Need newline here. > + wkup_r5fss0_core0: r5f@78000000 { > + compatible = "ti,am62-r5f"; > + reg = <0x78000000 0x00008000>, > + <0x78100000 0x00008000>; > + reg-names = "atcm", "btcm"; > + ti,sci = <&dmsc>; > + ti,sci-dev-id = <121>; > + ti,sci-proc-ids = <0x01 0xff>; > + resets = <&k3_reset 121 1>; > + firmware-name = "am62-wkup-r5f0_0-fw"; resets and firmware-name should go before vendor specific properties. Andrew > + ti,atcm-enable = <1>; > + ti,btcm-enable = <1>; > + ti,loczrama = <1>; > + }; > + }; > + > wkup_vtm0: temperature-sensor@b00000 { > compatible = "ti,j7200-vtm"; > reg = <0x00 0xb00000 0x00 0x400>,