From: Ed Tomlinson <edt@aei.ca>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Ed Tomlinson <edt@aei.ca>, "Greg KH <gregkh@linuxfoundation.org>,
Zhang, Jerry" <Jerry.Zhang@amd.com>,
<linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
<torvalds@linux-foundation.org>, <stable@vger.kernel.org>,
<lwn@lwn.net>, Jiri Slaby <jslaby@suse.cz>
Subject: Re: Linux 4.13.4
Date: Sat, 30 Sep 2017 11:14:42 -0400 [thread overview]
Message-ID: <b6b41c30-8cdd-42e3-a229-d07a9e519815@aei.ca> (raw)
In-Reply-To: <20170930142417.GA10658@kroah.com>
Hi
I did things old school via patch -R. This is what I reverted:
---
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index 4083be61b328..6417febe18b9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -95,9 +95,8 @@ int psp_wait_for(struct psp_context *psp, uint32_t
reg_index,
int i;
struct amdgpu_device *adev = psp->adev;
- val = RREG32(reg_index);
-
for (i = 0; i < adev->usec_timeout; i++) {
+ val = RREG32(reg_index);
if (check_changed) {
if (val != reg_val)
return 0;
diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
index c98d77d0c8f8..6f80ad8f588b 100644
--- a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
+++ b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
@@ -237,11 +237,9 @@ int psp_v3_1_bootloader_load_sos(struct psp_context
*psp)
/* there might be handshake issue with hardware which needs delay
*/
mdelay(20);
-#if 0
ret = psp_wait_for(psp, SOC15_REG_OFFSET(MP0, 0,
mmMP0_SMN_C2PMSG_81),
RREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_81),
0, true);
-#endif
return ret;
}
---
Thanks
Ed
On Saturday, September 30, 2017 10:24:17 AM EDT, Greg KH wrote:
> On Sat, Sep 30, 2017 at 09:49:28AM -0400, Ed Tomlinson wrote:
>> Hi,
>>
>> This build causes very annoying flickering on my display. I
>> am using the in
>> kernel amdgpu module to drive a RX480 with 4G via display port. When X is
>> started (kde) I get flickers that are extrememly distracting. The linux
>> install is arch stable and is up to date. Nothing interesting
>> in dmesg. ...
>
> What was the git commit id that you reverted to fix the issue?
> Is the issue in 4.14-rc2?
>
> thanks,
>
> greg k-h
>
>
next prev parent reply other threads:[~2017-09-30 15:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 8:33 Greg KH
2017-09-28 8:33 ` Greg KH
2017-09-30 13:49 ` Ed Tomlinson
2017-09-30 14:24 ` Greg KH
2017-09-30 15:14 ` Ed Tomlinson [this message]
2017-09-30 15:31 ` Greg KH
2017-09-30 15:48 ` Ed Tomlinson
2017-09-30 16:37 ` Ed Tomlinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6b41c30-8cdd-42e3-a229-d07a9e519815@aei.ca \
--to=edt@aei.ca \
--cc=Jerry.Zhang@amd.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=lwn@lwn.net \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®