From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752299AbdGRUAL (ORCPT <rfc822;w@1wt.eu>);
        Tue, 18 Jul 2017 16:00:11 -0400
Received: from mail-pg0-f42.google.com ([74.125.83.42]:33098 "EHLO
        mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752182AbdGRUAJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 18 Jul 2017 16:00:09 -0400
Subject: Re: [PATCH 1/4] rtc-lib: Add rtc_show_time(const char *prefix_msg)
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: linux-kernel@vger.kernel.org, rjw@rjwysocki.net, len.brown@intel.com,
        pavel@ucw.cz, linux-pm@vger.kernel.org, a.zummo@towertech.it,
        linux-rtc@vger.kernel.org
References: <20170718172525.114514-1-salyzyn@android.com>
 <20170718175224.xccqnv4zjggn4shu@piout.net>
From: Mark Salyzyn <salyzyn@android.com>
Message-ID: <b6bce88c-a13c-8504-18ac-242f637f4d13@android.com>
Date: Tue, 18 Jul 2017 13:00:07 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170718175224.xccqnv4zjggn4shu@piout.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/18/2017 10:52 AM, Alexandre Belloni wrote:
> Hi,
>
> On 18/07/2017 at 10:25:23 -0700, Mark Salyzyn wrote:
>> . . .
> Apart from using rtc_time_to_tm (and you should probably use
> rtc_time64_to_tm), none of this is actually related to the RTC
> subsystem. I feel like you should find another place to put that, maybe
> timekeeping_debug.c?
Makes a lot of sense!

-- Mark