From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED2BA352C33 for ; Mon, 2 Mar 2026 05:46:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772430376; cv=none; b=n7agC10DRH9MKHyV8HdiGdt7F0hSgdmF7k5KODsc2mXLCXh0BApZgzTMWf3ZTg9zrZrOkRv16V8RWw7c36N63jPGt+bn8rmzBO7vn63XMyo7cY+08Kh8KFpEzkiv7K9VlO66kVN5D7XgCn1ta/iILeGwFkRBQiBNv/ZHRW8UU1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772430376; c=relaxed/simple; bh=KaqISgrwu2MKxADy/Rr0sxdzUpKhO4Cq7F7VZa4FLr4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uSiQJ/fKupgs4nmmwiLoVW7RPv3KYIBHm6z6A8g56Ud87Ywu8L34WCnJMJKqsSnq+u3dnlw75Cx3FrRxVQ+H1X7jPa16qlzqd88a9quQJ32CJERob7KXKYB2T0WTbZPXbkk34EZjrGEVkDVmTYMbP+yvoZeiX7AYkpFIR7B2Afw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Z+hZzoN8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=a4T8Cma4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Z+hZzoN8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="a4T8Cma4" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6223Rmed4148349 for ; Mon, 2 Mar 2026 05:46:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DusOGrOv7n6Wk8Fc5KUX/o+ALeHBDXbnbHPx/a24gZc=; b=Z+hZzoN89/5xp1ql 8ypwSqhqyYP6H+stuk7GIjJPskaUWff9t+TYIhhLVMAK8SceYvz7tulQZW9XdeOC jUR0sKHUa/94DeToMxIFLKBC6RYARmpqS/lYB7ipG5m8DCzDEY8rv1PEjYGWECdX C8S3CAPOD1GGAh2Xb5XUMOWbmIzgFq57gZGCbRgf7zJbBsoJ3GZtBfurLms30BB/ 1FcAHzJRAlaLXMTIpmXRms6r/xzerRHSJGElg4vP558uCvqdusKlf+zoftpSUB6n 16eQmkBQuA1Z8WhVW/ZNPbARZO9iKJzELCyJjuFtZrA1cxHOeFqqmqSW6PBQX01x /icWFg== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cksg741w5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 05:46:11 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b6097ca315bso21195539a12.3 for ; Sun, 01 Mar 2026 21:46:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772430371; x=1773035171; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DusOGrOv7n6Wk8Fc5KUX/o+ALeHBDXbnbHPx/a24gZc=; b=a4T8Cma498P5e5K8lTGQb5shvkYUU05WwlNKKFiTqJWAVFZagDQpTHXlfwNCfb7oC2 BGZSc9n/9RdGKnGbzTBRVe2drNYs0Z+WLbYx7a9TmwOz+/XUmqU2VolyXWvn+y3DYZY1 x0AVGARGLSCfwVCAl7WgkBs9BwoLCXOEslCUWKX7eMpny4BgOkkpCi2hQtyznWblqaKd 2kGJ+lbTwl6eTu4t45O5C2f5n/i2hYNMGBJtPlrEnmDzj33Z23e7n24cPj083RD2TPWQ RRrt7II66mcEV8Ks6j2yel+fPg5MXupQqJeexhKrItVN1kCVtq7bz7bPdodoTp9Og/xf me0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772430371; x=1773035171; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DusOGrOv7n6Wk8Fc5KUX/o+ALeHBDXbnbHPx/a24gZc=; b=NRxFVrtLrdKkkHTyu8VjZAqh8uUq2owDfTxd7wVNVQfNW+xiGgB9RWv7mWEdfWMQUS Tvr357syBMHvveKg9yWSd83IXvQW9tFFv9UHCG/sam/8LVf0QX10NoYdmqftq9gsdj1b e+eibnciUscz20zEjG8hlZIzE8Zh7xZ4Ck2DrsPlPJjaNaW7isQ/1sMyMiCHzkwVNnQY UZZqc/H07/CT22ewgWD8VcWEjHqWp6OvNg5eTBVVg5gdiK1HvOTKwbsAX76INrnoyKjx XrxWbo125W7cMMl+2uNgZKJvU8vXqpp1u5VFRLR8lEtEZrZBoYfH2Eueh/EqrX4opK4i AwtA== X-Forwarded-Encrypted: i=1; AJvYcCUrVYRzszYo+TPitij0ADYXgW9y84IL1MjgDXZoLuBLvh2X0HMfReaRtwc/Ntivmk4IOYAoK0rbqwLJPd8=@vger.kernel.org X-Gm-Message-State: AOJu0YzSVpFnOZN4lVnIB+ioyvR5xfh9IZ5WRzcFMPX7XBrwHkrO7o2u qOp0iQ4CsEElmYQcJcOuoyZRzsOxc3gJGmBnCK5vliiGLBrdo5COf/kZiLUPJ7Q132DEgSAuXL9 9B+mpL2Flf1q6jMnzwGRkrQnuEpWkf2K8ziR7entrBSaIkT1zwb/ZLgMvVBwc6yk4Nss= X-Gm-Gg: ATEYQzxi0Z/dSWe3TA3eUIzoKXq3gxsIwSTkR5so6llu6GXA5uthArG4NCKHL3xGBid rcyxYh+zKXJDH5RTII9Bsb39UWuhTJxvzfmDepFbckot3SoO3dqaxrxHrRrCgjxeRV47wo30VUb zKKOJjtZfG4uOYWwft5pBSCULF+hz0iuIRkksvgTs5aNJ6LHOCFb9+RCQH0d/6XkOaMkOIcNO3Z wmDnweWVqzLK6DjWooOUfdtT9UCxPtd2eLvteRZvHkE8UApVDdrLG52SLEBf6rX6tTqB/79TzZ8 I6V4yzOVjB5+lEMnv+frGfeW0xgBR907vxCKjfb2SC7HQTh6ZVB2lvLtMaXRSHCh7sVhrNAiBNn eKskB2Z0tjnww92a8Yf0QjNuKNhjaIpGVJeMEu7Q85Dod/W4= X-Received: by 2002:a05:6a00:17a5:b0:7e8:4433:8fb9 with SMTP id d2e1a72fcca58-8274da7a6c0mr8934781b3a.65.1772430370680; Sun, 01 Mar 2026 21:46:10 -0800 (PST) X-Received: by 2002:a05:6a00:17a5:b0:7e8:4433:8fb9 with SMTP id d2e1a72fcca58-8274da7a6c0mr8934760b3a.65.1772430370176; Sun, 01 Mar 2026 21:46:10 -0800 (PST) Received: from [192.168.0.102] ([183.193.18.168]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739db4955sm12361703b3a.29.2026.03.01.21.46.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Mar 2026 21:46:09 -0800 (PST) Message-ID: Date: Mon, 2 Mar 2026 13:46:06 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/11] scsi: ufs: core: Add debugfs entries for TX Equalization params To: Bart Van Assche , avri.altman@wdc.com, beanhuo@micron.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , open list References: <20260227160809.2620598-1-can.guo@oss.qualcomm.com> <20260227160809.2620598-6-can.guo@oss.qualcomm.com> <3d5a65c9-c5ae-4547-a55c-f7554df62553@acm.org> Content-Language: en-US From: Can Guo In-Reply-To: <3d5a65c9-c5ae-4547-a55c-f7554df62553@acm.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: xL4hvlk1CkztDfWD-NIeor9q23s42BFE X-Proofpoint-GUID: xL4hvlk1CkztDfWD-NIeor9q23s42BFE X-Authority-Analysis: v=2.4 cv=FaA6BZ+6 c=1 sm=1 tr=0 ts=69a52423 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=4/OApUm1v7sVY8kc7hZvWg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=nnAcbMzM97FTqBoIYUsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDA0OCBTYWx0ZWRfXwnfMim8qh/6R 6525WWREwdLSetZAA4eiL5OUG35vmYgACKmdoKbIjfvN5d2/TbMNWCvRohnDKXSkkVqTFNpNJoo O4St/ROPiZQrFjS2Z9dXU3NLYbFIvJGtiJTLSIT5ZnTbayNgEPs1oeWNBiNmj4XYlvkn4/kYRgF F8FGlMGw04omkrRdVo3Sklo4AvloV0ybPvMDx4OimaXE4L7UhEhodG7eTOjlyv1ze8AtyOTvpdv Bmzl5RiUSNvxBz4fzjDhxJAiKnGfgTjuuN9IjTotbvuHzMe/R3cUin/tX3PLy4y3Fwd54uafZeV ZphqBZSPBzoapccXGzKYJTYKoWct106UZYXkjm6kovCsjTM0kLR8uZA0Ouis2ORtvvM1WtRXEUR Y3bGSPPV1U1r+xG1OQlfsBVjXqvQvvE8zkWNlhwHXy/J9mJXa+6ZgYKZ51fEYcHO0ZLnIfzvBQv v/lyPGATU4qJ4x1FaWg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_02,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020048 Hi Bart, On 2/28/2026 5:49 AM, Bart Van Assche wrote: > On 2/27/26 8:08 AM, Can Guo wrote: >> @@ -230,6 +427,15 @@ void ufs_debugfs_hba_init(struct ufs_hba *hba) >>                   hba, &ee_usr_mask_fops); >>       debugfs_create_u32("exception_event_rate_limit_ms", 0600, >> hba->debugfs_root, >>                  &hba->debugfs_ee_rate_limit_ms); >> + >> +    if (!(hba->caps & UFSHCD_CAP_TX_EQUALIZATION)) >> +        return; >> +    hba->debugfs_tx_eq_gear = UFS_HS_GEAR_MAX - 1; >> +    debugfs_create_file("tx_eq_gear_sel", 0600, hba->debugfs_root, hba, >> +                &tx_eq_gear_fops); >> +    for (attr = ufs_tx_eq_attrs; attr->name; attr++) >> +        debugfs_create_file(attr->name, attr->mode, root, (void *)attr, >> +                    attr->fops); >>   } > > So the 'tx_eq_gear_sel` is an attribute that controls what output is > shown in the other debugfs attributes? I don't think that is acceptable. > Please make sure that there is one set of debugfs attributes for every > valid 'gear' value, e.g. by creating one directory per gear. Will create the debugfs entries on a per-gear basis in next version. Thanks, Can Guo. > > Thanks, > > Bart.