From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55C01C433FE for ; Mon, 3 Oct 2022 19:17:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229715AbiJCTRF (ORCPT ); Mon, 3 Oct 2022 15:17:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229615AbiJCTRB (ORCPT ); Mon, 3 Oct 2022 15:17:01 -0400 Received: from smtp.smtpout.orange.fr (smtp07.smtpout.orange.fr [80.12.242.129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A12D399DA for ; Mon, 3 Oct 2022 12:16:59 -0700 (PDT) Received: from [192.168.1.18] ([86.243.100.34]) by smtp.orange.fr with ESMTPA id fQvwoZeRokifIfQvwokOwJ; Mon, 03 Oct 2022 21:16:56 +0200 X-ME-Helo: [192.168.1.18] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Mon, 03 Oct 2022 21:16:56 +0200 X-ME-IP: 86.243.100.34 Message-ID: Date: Mon, 3 Oct 2022 21:16:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] HID: alps: Simplify the .remove function Content-Language: en-US To: Marcus Folkesson Cc: Jiri Kosina , Benjamin Tissoires , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-input@vger.kernel.org References: <33cf94ec234b88ffc79eb4496c640093aa8c5e70.1664721476.git.christophe.jaillet@wanadoo.fr> From: Christophe JAILLET In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 03/10/2022 à 17:40, Marcus Folkesson a écrit : > Hi Christophe! > > On Sun, Oct 02, 2022 at 04:38:26PM +0200, Christophe JAILLET wrote: >> If the .remove function of a 'hid_driver' is NULL, the default behavior is >> to call hid_hw_stop(). >> >> So alps_remove() can be removed here, it is just hand-writing what >> already exists. >> >> Signed-off-by: Christophe JAILLET >> --- > > > There is already a patch out there :-) Great, But I always find it funny when something that is there since many years (819d64e51d62 - 2016-06-23) is fixed twice in a row from unrelated work! CJ > > https://lore.kernel.org/all/20220915123438.520775-1-marcus.folkesson@gmail.com/ > > Best regards, > Marcus Folkesson