From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B6882EAEA; Wed, 23 Oct 2024 15:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729698128; cv=none; b=N9zxDWXO+4Z4sv3Mt0X+boggUEbMg1mKPjQd4PW3TsgusgPLDbKwDq9UNiqKiU7spxpeSEMQA/fgc86T0t+F2XXqjO8S3lQZbyLjZAoLbDcJgyj6ieGvUffNSeht5gc78cmzCM+OUFhVwcFLfurCtYA/TYEhQD3kpKibE4mnn4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729698128; c=relaxed/simple; bh=oRzebAgWxDGd+jZWWHdVlWB9VsltfF8Fs6igx86te0g=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=c1odBLbvj1NaS7WUtbTbn1qSE4djbvOjnFpSC7+yKdmdtJpC6NLnRqjIYkcYSerhl1Cn4YxoJxw6jFNlZaVEHIRSzzIAxUL1l7jM9UxXDzgEx/qhg1GF5vGY6CxMQSNcOn3Du3Qr1OJy8YSemr4c2XH/XVokN5T7C75UdKiHlUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nsshWBvR; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nsshWBvR" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-20ce5e3b116so55620795ad.1; Wed, 23 Oct 2024 08:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729698125; x=1730302925; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=1IZNGY4vDjRIRwIdOWiybxIO0837tQlwIzSyK2AgLhs=; b=nsshWBvRAn5qUC853yAiQO34OVhyfkaNfzLF8lg3JDbOLnIEZySOU3l2gtLKhMXXtg KgnE4GYDY9TMXCA5TWdJ80LAJEUL/mpRaV5KTlTlvZep1Ez08dFAvuYeJYLcedA3VtmE cyJBdm0QY8o6dRedZt+m5piOkeHpK0cTwMvNB7wi5/eaoF1HFfUynxrXKeIY/HWVqBoA SoMig46DaXgLh0e2yY4caxIb/79n/TdbGd0nqYt1hrhac29UAutYubyV7l2gUF786Ihm 711jGaJc7jvWiWL0JKBxmYQv/5qvUHwlvQJ42wm3fKBP+8AKQYfI7UrbzsH1yz0cGh8o hdkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729698125; x=1730302925; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1IZNGY4vDjRIRwIdOWiybxIO0837tQlwIzSyK2AgLhs=; b=OTddutdbT2Y190myzVY/92YkBaodBUDVyEBaQ5SC1xZkqXbTDhNBjaifA+dLum3+NA QptehuE5r/ASFMVfYgiuaA6sX7fLqz1gCKoHXnZ0gqH19YhrX4bExZAQbo2A4/UivrK5 R9WLJOBQ9v2D9WzRwIjGs2DFqe6ufoH72bwoPXiHyrIyS5ljC0IMClnrRpv4CYgBQ9Z9 9s5aqmvvN/kRZNTiJcplJLoKfxIODOSxociC9wsFkEwXYH77cmXBU6MEjf3BfFyJre1A 8+VFJ7ks/jooQyGBetBCz5JmscDMAWh/v2AVX3Cz3SzX5GHNQN6GCsMguxGE4G4x81cZ EPeA== X-Forwarded-Encrypted: i=1; AJvYcCXIoZDuUUEXWf4QUGosLjSfZT0klXTodaaw1Q5DnnMG2WkKImLtynPnJ1g/WFUqTmELmxS3pQ6wEYZf3w==@vger.kernel.org, AJvYcCXKqlwBX/G9Ig6KZHpLbCaDySq7j1oDMtvYMHCX6UlXa5C3J0keU5vI/iP+05JWr51oAxNKw1HmCM5xu0qo@vger.kernel.org X-Gm-Message-State: AOJu0Yy+3S/IOm/amwN5nXAtDQT+cyPXpenMoxk372kRvwL344Vap5/j yyM8tMyjRXMu6k82cwuslhpsnl8/pg9yVm0R/hKdFjY38uYJ/u6J X-Google-Smtp-Source: AGHT+IHJ1MSAlbYsONoYA4T4mVppJWmjY8/XMmRspaM3qukr8CjaHj2czmXaOe+03O6ttoLUgaacWw== X-Received: by 2002:a17:902:eccd:b0:20b:a10c:9be3 with SMTP id d9443c01a7336-20fa9e26271mr42699345ad.21.1729698125349; Wed, 23 Oct 2024 08:42:05 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e7f0bf197sm59103155ad.150.2024.10.23.08.42.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Oct 2024 08:42:04 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Wed, 23 Oct 2024 08:42:02 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] hwmon: (it87) Add support for IT8625E To: Ahmad Khalifa , Frank Crawford , Ai Chao , jdelvare@suse.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241022091319.82503-1-aichao@kylinos.cn> <6cab565f05820eb2e1a1c55644be057427ecdf2e.camel@crawford.emu.id.au> <300383ee-3ead-439e-893e-895f3ed49805@roeck-us.net> <103a68d6-d0b8-4e6f-ac8f-c6186b340f81@khalifa.ws> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <103a68d6-d0b8-4e6f-ac8f-c6186b340f81@khalifa.ws> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/23/24 05:41, Ahmad Khalifa wrote: > On 22/10/2024 14:40, Guenter Roeck wrote: >> On 10/22/24 03:13, Frank Crawford wrote: >>> On Tue, 2024-10-22 at 17:13 +0800, Ai Chao wrote: >>>> Add support for IT8625E on Centerm P410. > ... >>> Can I just add that it isn't a good idea to use the same type for >>> different chips.  There are some specific differences between the >>> chips, which mean that it should have its own entry in >>> >>> static const struct it87_devices it87_devices[] >>> >>> even if currently they are very similar. >> >> According to the information I have, the ADC voltage is different, >> and 8628 supports PECI but 8625 doesn't. Most importantly, 8625 >> has multiple register banks. There are also some differences in >> fan control; 8628 can explicitly turn fans off using register bits. >> >> Just mapping the chip to it8628 may be convenient, but it is not >> acceptable. > > Side question here. The standard for an acceptable chip driver is pretty > high (and rightfully so). But a common use case centres around readonly > display of information: temp/fan/in readings. Even just 2-3 readings are > better than nothing. > > Example, I still have to use Frank's out of tree it87 for my IT8688. > It works perfectly fine for me, but still not possible to merge that > device into hwmon's it87. > This IT8625 is another example. The NCT6701D-R will be one more shortly. > For the most part you can use the kernel driver with force_id parameter. That is no different than your suggested patch. Nuvoton is usually very supportive, so I don't see a problem adding support for NCT6701D-R if someone is willing to spend the time to write a driver (or adding support to an existing driver if the chip is similar). > A readonly driver that is configurable from userspace would help in that > use case. It can be configured for known devices without datasheets or > for testing new devices. Wouldn't even need to access superio config > space. > > Filesystem has fuse, i2c has i2c-dev, input has evdev, ... > Would something similar be acceptable for hwmon? > I would have to details of a proposal, but It seems unlikely. After all, chip details have to be sufficiently known to provide any driver, even a userspace one. Also, the hwmon ABI (i.s., its set of sysfs entries) isn't that special that it would warrant such a kernel infrastructure. If at all, it might make more sense to add support for this, for example, to libsensors. Guenter