From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3CC13C10BB; Wed, 15 Jul 2026 22:25:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784154313; cv=none; b=mn3BJMWVpkvXWRDCthMl99twiNrfpnIyR8VRGglX5RSae1fhWYIGAix8qi//sMUxiNHMzOZ/eNaZljaWs/tT2Kut1kaAkr7qsfIocZQDdZEU3y3W846vQM4KhsEp6hj2mkyRPpIcIDfsrDeZoobFPQr8RmYpxOOKcJtbZwpAbX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784154313; c=relaxed/simple; bh=0KoUoh9NEy9NsPiK7s1BVgTjkAxQ16jz3k4PiORO6Oo=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=TVytv1Y+T2qI/pcUsXd1pV66BPHEhJ1ykQw6W0kUznaAboQKv5LC3oWcvkM6kuODSvyyRgu9wK3LOIWPeb//tz5rpZP7P3ZsdrjP6dblkeywD2Jc6AYoHUs71vDL8cBnAsmxxR7cnK3zkiXGaxQs1bnwrHdvIWZI+OpEAbrp7t8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=XfgJAIF6; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="XfgJAIF6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1784154309; bh=0KoUoh9NEy9NsPiK7s1BVgTjkAxQ16jz3k4PiORO6Oo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=XfgJAIF6AG64UFq9/qxt08Z7qWpwrJzNQAdyZmWQ7GPCX0tVsyXj9T852XAJ0uN4z RvrUCyh/1RQnrSD8CjkIMXWvSH+N2v5G/73DgGsaoxV8g3Q3d73dsuI6W6yuqI/oHD 12ux10hUvANrTx99dX120tvZOJOgNPvajc+nXxyHFQXrbJqPyhskWWjFiI4D+UChFM Utf66gX1fSWUXHIZaNQKjyEGuvhuG27t3pSY94tYFTXQb0R/PfwtfcENM6pyzyGTBF OIXFZqRqya0nrrMvJcuZrvZp59F2BpTEUvHXFgMZdK2vQ2PAifKJwJQZvr6iU3s3Ue jLQ3iDNlvHNTA== Received: from [100.64.0.214] (unknown [100.64.0.214]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by bali.collaboradmins.com (Postfix) with ESMTPSA id 7456917E010F; Thu, 16 Jul 2026 00:25:08 +0200 (CEST) Message-ID: Subject: Re: [PATCH v2 1/3] media: rkvdec: hevc: tighten EXT SPS RPS control dimensions From: Nicolas Dufresne To: Michael Bommarito , Detlev Casanova , Ezequiel Garcia , Mauro Carvalho Chehab Cc: Hans Verkuil , Heiko Stuebner , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Wed, 15 Jul 2026 18:25:06 -0400 In-Reply-To: <20260527194737.1999409-2-michael.bommarito@gmail.com> References: <20260513181922.2075438-1-michael.bommarito@gmail.com> <20260527194737.1999409-1-michael.bommarito@gmail.com> <20260527194737.1999409-2-michael.bommarito@gmail.com> Autocrypt: addr=nicolas.dufresne@collabora.com; prefer-encrypt=mutual; keydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD /e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA cCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo CGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN abIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z nJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4 AWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ smBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC AAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF iEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw ECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8 bRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ Organization: Collabora Canada Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ny5mJslQQjxRcG9W1xHo" User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --=-ny5mJslQQjxRcG9W1xHo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le mercredi 27 mai 2026 =C3=A0 15:47 -0400, Michael Bommarito a =C3=A9crit= =C2=A0: > The VDPU381 HEVC driver registers V4L2_CID_STATELESS_HEVC_EXT_SPS_ST_RPS > and V4L2_CID_STATELESS_HEVC_EXT_SPS_LT_RPS with .cfg.dims =3D { 65 }, but > the HEVC spec caps num_short_term_ref_pic_sets at 64 (ITU-T H.265 7.4.8) > and num_long_term_ref_pics_sps at 32 (7.4.3.2.1). The hardware descriptor > table (struct rkvdec_rps) sizes match those spec limits: refs[32] and > short_term_ref_sets[64]. >=20 > Reduce the dims to { 64 } and { 32 } respectively so the V4L2 control > framework rejects oversized payloads before any driver code runs. >=20 > Fixes: c9a59dc2acc7 ("media: rkvdec: Add HEVC support for the VDPU381 > variant") > Cc: stable@vger.kernel.org > Suggested-by: Detlev Casanova > Assisted-by: Claude:claude-opus-4-7 > Signed-off-by: Michael Bommarito Reviewed-by: Nicolas Dufresne > --- > =C2=A0drivers/media/platform/rockchip/rkvdec/rkvdec.c | 4 ++-- > =C2=A01 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec.c > b/drivers/media/platform/rockchip/rkvdec/rkvdec.c > index 1d1e9bfef8e96..4fd06f4c04db0 100644 > --- a/drivers/media/platform/rockchip/rkvdec/rkvdec.c > +++ b/drivers/media/platform/rockchip/rkvdec/rkvdec.c > @@ -278,12 +278,12 @@ static const struct rkvdec_ctrl_desc > vdpu38x_hevc_ctrl_descs[] =3D { > =C2=A0 { > =C2=A0 .cfg.id =3D V4L2_CID_STATELESS_HEVC_EXT_SPS_ST_RPS, > =C2=A0 .cfg.ops =3D &rkvdec_ctrl_ops, > - .cfg.dims =3D { 65 }, > + .cfg.dims =3D { 64 }, > =C2=A0 }, > =C2=A0 { > =C2=A0 .cfg.id =3D V4L2_CID_STATELESS_HEVC_EXT_SPS_LT_RPS, > =C2=A0 .cfg.ops =3D &rkvdec_ctrl_ops, > - .cfg.dims =3D { 65 }, > + .cfg.dims =3D { 32 }, > =C2=A0 }, > =C2=A0}; > =C2=A0 --=-ny5mJslQQjxRcG9W1xHo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCalgIwgAKCRDZQZRRKWBy 9HxEAP9wfCCEd20ut44QQMcy3HEL1pcFySIAWFzjiQm3lQ+xMwEAzhK3KvVUgYEe VxlKnrmbdIelPZZb9AqPGybtVc6h3wI= =rJ5m -----END PGP SIGNATURE----- --=-ny5mJslQQjxRcG9W1xHo--