From: "Bob Copeland" <me@bobcopeland.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, snakebyte@gmx.de
Subject: Re: __getblk infinite loop
Date: Fri, 5 Sep 2008 10:58:55 -0400 [thread overview]
Message-ID: <b6c5339f0809050758r8ba7559k4ebe56531f5556e6@mail.gmail.com> (raw)
In-Reply-To: <20080904223836.54fbabb1.akpm@linux-foundation.org>
On Fri, Sep 5, 2008 at 1:38 AM, Andrew Morton <akpm@linux-foundation.org> wrote:
> That loop does lock up on people occasionally - last time was in isofs,
> because it had done an insane set_blocksize() earlier on.
>
> Yes, it's always a case of garbage in, garbage out (or nothing out, as
> the case may be).
>
> No, it's not particularly programmer-friendly behaviour.
Ok, I think I get it now - sector_t 0x1d4000004 is in the addressable
range (by one bit) since we can address 4G blocks of PAGE_SIZE and the
FS is using a block size of 2048. grow_buffers() always returns 0
because find_or_create_page() fails adding a page with that huge
offset into the pagecache (?), so we try to free memory and try again.
Your patch here:
http://marc.info/?l=linux-kernel&m=117202372525279&w=2
doesn't apply to the situation since index is still technically a
valid page offset.
So, I guess the answer is to deal with it in fsck and tell people
"don't do that."
--
Bob Copeland %% www.bobcopeland.com
prev parent reply other threads:[~2008-09-05 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 3:24 Bob Copeland
2008-09-05 5:38 ` Andrew Morton
2008-09-05 9:20 ` Eric Sesterhenn
2008-09-10 12:33 ` Bob Copeland
2008-09-05 14:58 ` Bob Copeland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6c5339f0809050758r8ba7559k4ebe56531f5556e6@mail.gmail.com \
--to=me@bobcopeland.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®