On 4/15/25 01:25, Kirill A. Shutemov wrote: >> #ifdef CONFIG_X86_32 >> - if (!SHARED_KERNEL_PMD) { >> + { >> struct page *page; >> >> list_for_each_entry(page, &pgd_list, lru) { > Removing the condition, but leaving the block looks sloppy. > > Maybe convert #ifdef to IS_ENABLED() while you are there, so it would > justify the block? It does, and it's right at the beginning of the function. Simplifying the code here also made it _less_ self-documenting so it needs a better comment too. I'll tack the attached patch on to the end of the series.