From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Frank Lee <tiny.windzz@gmail.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clocksource/drivers/integrator-ap: add of_node_put()
Date: Thu, 22 Nov 2018 15:51:38 +0100 [thread overview]
Message-ID: <b6c8bdc9-d43a-5884-0678-b34176292909@linaro.org> (raw)
In-Reply-To: <CAEExFWvOG9YmUdJjJ-d-acHLU9DrS9ccRWs-u1wMOJocQhXZSw@mail.gmail.com>
On 22/11/2018 15:48, Frank Lee wrote:
> On Thu, Nov 22, 2018 at 10:43 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>
>> On 22/11/2018 15:39, Frank Lee wrote:
>>> On Thu, Nov 22, 2018 at 10:37 PM Daniel Lezcano
>>> <daniel.lezcano@linaro.org> wrote:
>>>>
>>>> On 22/11/2018 15:33, Frank Lee wrote:
>>>>> On Thu, Nov 22, 2018 at 10:26 PM Daniel Lezcano
>>>>> <daniel.lezcano@linaro.org> wrote:
>>>>>>
>>>>>> On 20/11/2018 14:18, Yangtao Li wrote:
>>>>>>> use of_node_put() to release the refcount.
>>>>>>>
>>>>>>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>>>>>>
>>>>>> Applied, thanks!
>>>>> Hi Daniel:
>>>>>
>>>>> This patch is a bit small, I will resend。
>>>>
>>>> What do you mean by 'small' ?
>>> pri_node = of_find_node_by_path(path);
>>> if (node == pri_node){
>>> of_node_put(pri_node);
>>>
>>> /* The primary timer lacks IRQ, use as clocksource */
>>> return integrator_clocksource_init(rate, base);
>>> }
>>>
>>> sec_node = of_find_node_by_path(path);
>>>
>>> Under my revision, pri_node and sec_nodeare the same thing.
>>
>> Oh, right. Missed it :/
> Daniel ,
>
> Have you mde the patch merged?
> Which git is the patch in?
> I hope that you can revert it and I‘ll resend new one
> or I'll resend patch based on the modify.
I can drop it, resend a new one.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2018-11-22 14:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 13:18 Yangtao Li
2018-11-22 14:16 ` Daniel Lezcano
2018-11-22 14:22 ` Linus Walleij
2018-11-22 14:26 ` Daniel Lezcano
2018-11-22 14:26 ` Daniel Lezcano
2018-11-22 14:33 ` Frank Lee
2018-11-22 14:36 ` Frank Lee
2018-11-22 14:37 ` Daniel Lezcano
2018-11-22 14:39 ` Frank Lee
2018-11-22 14:41 ` Daniel Lezcano
2018-11-22 14:43 ` Daniel Lezcano
2018-11-22 14:48 ` Frank Lee
2018-11-22 14:51 ` Daniel Lezcano [this message]
2018-11-22 14:52 ` Frank Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6c8bdc9-d43a-5884-0678-b34176292909@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®