From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD4D61474B5 for ; Thu, 8 Aug 2024 16:47:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=44.202.169.39 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723135668; cv=none; b=fwNZivW8alLGwDdHbx3cGLj+qIIGPeG1W/r18B+3Rd77AUBT6M1ChV5UmF2Q38O8Euh50TlmQGiEfYs95661Swl7vqP2w5SZilgYVdNq0zU/eivYNG5iX31nNMT6ncenVuBlno2gA32dOOK8dlY83CVrWmOW8xNH/SNDiCCAupM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723135668; c=relaxed/simple; bh=RajS3Iv3t7XxfZVVa/qqKpOf5NV/TKtvi18u1+/kUNo=; h=Subject:From:To:Cc:References:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=VEbY6y0hK6KjoXmLPAW/Nj7vXaeV4bSWWTyTfU75iQPzHs7JVTX1V+3cm/CfiZ50YnD4mmHPf9WcJ3cpTMG7h8MDw57u4ATKM4usVt0vpwkWzc9gzxt9in2n4nM0g+RS+Igw3JwzevzL3dtH6Cy4ZL7AZmxpYs1sXSnz+NbhQag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=w6rz.net; spf=pass smtp.mailfrom=w6rz.net; dkim=pass (2048-bit key) header.d=w6rz.net header.i=@w6rz.net header.b=TDR04Xer; arc=none smtp.client-ip=44.202.169.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=w6rz.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=w6rz.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=w6rz.net header.i=@w6rz.net header.b="TDR04Xer" Received: from eig-obgw-6009a.ext.cloudfilter.net ([10.0.30.184]) by cmsmtp with ESMTPS id ba7dsFf3UnNFGc6HAsTOSp; Thu, 08 Aug 2024 16:46:08 +0000 Received: from box5620.bluehost.com ([162.241.219.59]) by cmsmtp with ESMTPS id c6H9sg0AV0K4nc6H9sRl81; Thu, 08 Aug 2024 16:46:08 +0000 X-Authority-Analysis: v=2.4 cv=RsjDLjmK c=1 sm=1 tr=0 ts=66b4f650 a=30941lsx5skRcbJ0JMGu9A==:117 a=30941lsx5skRcbJ0JMGu9A==:17 a=IkcTkHD0fZMA:10 a=yoJbH4e0A30A:10 a=VwQbUJbxAAAA:8 a=s2I88z9o6i3GcfhhhlwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=hTR6fmoedSdf3N0JiVF8:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=w6rz.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version: Date:Message-ID:References:Cc:To:From:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=LSgTUSHkIv7hXmHEcrbfOGnyRbNeawZhTZ0yhaq4pDg=; b=TDR04Xer/BoIPT/JyZo7g6PH/D VabLFL+AaG1SIxKwtR+6lhw/UzXGD5J5DByg0pPBXQh51rF8CNVbigE/6X/nknW7CMslpQnwFVyTt 7hs6kRpPGjmenXm32aRVPaeQ6G8wtRlSXUo9FxrLiRUpwXWwQDN1sut+IyfOJ8x/uyadNktzsZ2nb dcIu6TpYMhLqUD+uEr/2mkZDccr+clCdfRK8TFhS/EDyFsFD+nwB/+weC7B0Le0bWV34r2e9t5lqB sGsqkSWQM+LrGxhv/lu67e6dAStisnDkDJawD+noDeTBc1jJ+vuyl9QwDPEmao1prVs/gfSXhAVCw 0YOPIaYg==; Received: from c-73-223-253-157.hsd1.ca.comcast.net ([73.223.253.157]:33544 helo=[10.0.1.47]) by box5620.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.2) (envelope-from ) id 1sc6H4-0016rU-2L; Thu, 08 Aug 2024 10:46:02 -0600 Subject: Re: [PATCH 6.1 00/86] 6.1.104-rc2 review From: Ron Economos To: Greg Kroah-Hartman , stable@vger.kernel.org Cc: patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org, allen.lkml@gmail.com, broonie@kernel.org References: <20240808091131.014292134@linuxfoundation.org> <96b86f9b-c516-9742-5e33-e5cbfbed10b3@w6rz.net> Message-ID: Date: Thu, 8 Aug 2024 09:45:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux armv7l; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5620.bluehost.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - w6rz.net X-BWhitelist: no X-Source-IP: 73.223.253.157 X-Source-L: No X-Exim-ID: 1sc6H4-0016rU-2L X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: c-73-223-253-157.hsd1.ca.comcast.net ([10.0.1.47]) [73.223.253.157]:33544 X-Source-Auth: re@w6rz.net X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: d3NpeHJ6bmU7d3NpeHJ6bmU7Ym94NTYyMC5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfAt6XccMINh+TAaWsiTQojSLR7MJ0zXiHJJ8GKEe6bH8Xv0c936NhKmsp5fAeQ7VGzQs/+fLCHqeV1NQExy+BE7U4vVMZFFBbN7mpjJ4SUHHPmHsOm4Z +bTeedOtDPV4ZD3HzBW9yomRXWcWvvZMrTrz4v9SyQTTKovw+SFzMRd33oqokK21+/4PbK/UMARDZ/I3AM33gi5bZo/iwLAa+rY= On 8/8/24 7:43 AM, Ron Economos wrote: > On 8/8/24 4:55 AM, Ron Economos wrote: >> On 8/8/24 2:11 AM, Greg Kroah-Hartman wrote: >>> This is the start of the stable review cycle for the 6.1.104 release. >>> There are 86 patches in this series, all will be posted as a response >>> to this one.  If anyone has any issues with these being applied, please >>> let me know. >>> >>> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000. >>> Anything received after that time might be too late. >>> >>> The whole patch series can be found in one patch at: >>>     https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz >>> >>> or in the git tree and branch at: >>>     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git >>> linux-6.1.y >>> and the diffstat can be found below. >>> >>> thanks, >>> >>> greg k-h >>> >> I'm seeing a build failure. >> >> sound/pci/hda/patch_conexant.c:273:10: error: ‘const struct >> hda_codec_ops’ has no member named ‘suspend’ >>   273 |         .suspend = cx_auto_suspend, >>       |          ^~~~~~~ >> sound/pci/hda/patch_conexant.c:273:20: error: initialization of ‘void >> (*)(struct hda_codec *, hda_nid_t,  unsigned int)’ {aka ‘void >> (*)(struct hda_codec *, short unsigned int,  unsigned int)’} from >> incompatible pointer type ‘int (*)(struct hda_codec *)’ >> [-Werror=incompatible-pointer-types] >>   273 |         .suspend = cx_auto_suspend, >>       |                    ^~~~~~~~~~~~~~~ >> sound/pci/hda/patch_conexant.c:273:20: note: (near initialization for >> ‘cx_auto_patch_ops.set_power_state’) >> sound/pci/hda/patch_conexant.c:274:10: error: ‘const struct >> hda_codec_ops’ has no member named ‘check_power_status’; did you mean >> ‘set_power_state’? >>   274 |         .check_power_status = snd_hda_gen_check_power_status, >>       |          ^~~~~~~~~~~~~~~~~~ >>       |          set_power_state >> sound/pci/hda/patch_conexant.c:274:31: error: >> ‘snd_hda_gen_check_power_status’ undeclared here (not in a function); >> did you mean ‘snd_hda_check_power_state’? >>   274 |         .check_power_status = snd_hda_gen_check_power_status, >>       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>       |                               snd_hda_check_power_state >> >> This is triggered because my config does not include CONFIG_PM. But >> the error is caused by upstream patch >> 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda: codec: Reduce >> CONFIG_PM dependencies" being missing. This patch removes the #ifdef >> CONFIG_PM in the hda_codec_ops structure. So if CONFIG_PM is not set, >> some structure members are missing and the the build fails. >> >> > Same failure occurs in 6.6.45-rc1 if CONFIG_PM is not set. > > Note: Both upstream 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda: codec: Reduce CONFIG_PM dependencies" and 6c8fd3499423fc3ebb735f32d4a52bc5825f6301 "ALSA: hda: generic: Reduce CONFIG_PM dependencies" are required to fix the build if CONFIG_PM is not set.