From: German Gomez <german.gomez@arm.com>
To: James Clark <james.clark@arm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
acme@kernel.org
Cc: broonie@kernel.org, leo.yan@linaro.org,
mathieu.poirier@linaro.org, john.garry@huawei.com,
Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/5] perf tools: arm64: Use perf's copy of kernel headers
Date: Wed, 25 May 2022 16:59:30 +0100 [thread overview]
Message-ID: <b6cf9d34-313e-6b7d-3781-a8a5af203cd6@arm.com> (raw)
In-Reply-To: <20220525154114.718321-2-james.clark@arm.com>
On 25/05/2022 16:41, James Clark wrote:
> Fix this include path to use perf's copy of the kernel header
> rather than the one from the root of the repo.
>
> This fixes build errors when only applying the perf tools
> part of a patchset rather than both sides.
>
> Reported-by: German Gomez <german.gomez@arm.com>
> Signed-off-by: James Clark <james.clark@arm.com>
Without this change "make -C tools/perf" was failing if kernel-side changes weren't applied
Tested-by: German Gomez <german.gomez@arm.com>
Thanks,
German
> ---
> tools/perf/util/libunwind/arm64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/libunwind/arm64.c b/tools/perf/util/libunwind/arm64.c
> index 15f60fd09424..014d82159656 100644
> --- a/tools/perf/util/libunwind/arm64.c
> +++ b/tools/perf/util/libunwind/arm64.c
> @@ -24,7 +24,7 @@
> #include "unwind.h"
> #include "libunwind-aarch64.h"
> #define perf_event_arm_regs perf_event_arm64_regs
> -#include <../../../../arch/arm64/include/uapi/asm/perf_regs.h>
> +#include <../../../arch/arm64/include/uapi/asm/perf_regs.h>
> #undef perf_event_arm_regs
> #include "../../arch/arm64/util/unwind-libunwind.c"
>
next prev parent reply other threads:[~2022-05-25 15:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 15:41 [PATCH v3 0/5] perf: arm64: Tools support for Dwarf unwinding through SVE functions James Clark
2022-05-25 15:41 ` [PATCH v3 1/5] perf tools: arm64: Use perf's copy of kernel headers James Clark
2022-05-25 15:59 ` German Gomez [this message]
2022-06-02 18:08 ` Ian Rogers
2022-05-25 15:41 ` [PATCH v3 2/5] perf tools: arm64: Copy perf_regs.h from the kernel James Clark
2022-05-25 15:41 ` [PATCH v3 3/5] perf tools: Use dynamic register set for Dwarf unwind James Clark
2022-05-25 15:41 ` [PATCH v3 4/5] perf tools: arm64: Decouple Libunwind register names from Perf James Clark
2022-05-25 15:41 ` [PATCH v3 5/5] perf tools: arm64: Add support for VG register James Clark
2022-05-26 15:23 ` [PATCH v3 0/5] perf: arm64: Tools support for Dwarf unwinding through SVE functions Arnaldo Carvalho de Melo
2022-09-23 10:34 ` James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6cf9d34-313e-6b7d-3781-a8a5af203cd6@arm.com \
--to=german.gomez@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=broonie@kernel.org \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®