From: Vlastimil Babka <vbabka@suse.cz>
To: Hugh Dickins <hughd@google.com>
Cc: Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Harry Yoo <harry.yoo@oracle.com>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <jackmanb@google.com>, Zi Yan <ziy@nvidia.com>,
Eric Biggers <ebiggers@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/11] mempool: factor out a mempool_alloc_from_pool helper
Date: Tue, 25 Nov 2025 12:32:58 +0100 [thread overview]
Message-ID: <b6d035e1-9b29-4a3f-89bd-5f556005d07b@suse.cz> (raw)
In-Reply-To: <8d043756-b59c-f604-f859-3f4803bbcd23@google.com>
On 11/24/25 00:04, Hugh Dickins wrote:
>
> You are completely right: it was me who was missing that the second
> pool->alloc is with the full gfp, so not an identical repeat of the
> the first; and so it is correct not to wait after the first attempt,
> so you are right to call with gfp_temp instead of gfp_mask there.
>
> (And this also addresses my slight concern, of whether it was
> appropriate to be doing a pool->alloc after waiting for a mempool
> free: your way, there is no such wait, at least not that most
> important first->second time: the wait would instead be inside
> the pool->alloc probably, reclaiming.)
>
> Yes, your fixup is better in all ways than mine, please go ahead.
>
> Thanks,
> Hugh
Thanks, Hugh!
next prev parent reply other threads:[~2025-11-25 11:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 8:39 mempool_alloc_bulk and various mempool improvements v3 Christoph Hellwig
2025-11-13 8:39 ` [PATCH 01/11] fault-inject: make enum fault_flags available unconditionally Christoph Hellwig
2025-11-13 8:39 ` [PATCH 02/11] mm: improve kerneldoc comments for __alloc_pages_bulk Christoph Hellwig
2025-11-13 8:39 ` [PATCH 03/11] mempool: improve kerneldoc comments Christoph Hellwig
2025-11-13 8:39 ` [PATCH 04/11] mempool: add error injection support Christoph Hellwig
2025-11-13 8:39 ` [PATCH 05/11] mempool: factor out a mempool_adjust_gfp helper Christoph Hellwig
2025-11-13 8:39 ` [PATCH 06/11] mempool: factor out a mempool_alloc_from_pool helper Christoph Hellwig
2025-11-23 3:42 ` Hugh Dickins
2025-11-23 11:34 ` Vlastimil Babka
2025-11-23 17:49 ` Hugh Dickins
2025-11-23 21:22 ` Vlastimil Babka
2025-11-23 23:04 ` Hugh Dickins
2025-11-25 11:32 ` Vlastimil Babka [this message]
2025-11-24 6:17 ` Christoph Hellwig
2025-11-24 6:15 ` Christoph Hellwig
2025-11-25 11:34 ` Vlastimil Babka
2025-11-24 6:14 ` Christoph Hellwig
2025-11-13 8:39 ` [PATCH 07/11] mempool: add mempool_{alloc,free}_bulk Christoph Hellwig
2025-11-13 8:39 ` [PATCH 08/11] mempool: legitimize the io_schedule_timeout in mempool_alloc_from_pool Christoph Hellwig
2025-11-13 8:39 ` [PATCH 09/11] mempool: remove mempool_{init,create}_kvmalloc_pool Christoph Hellwig
2025-11-13 8:39 ` [PATCH 10/11] mempool: de-typedef Christoph Hellwig
2025-11-13 8:39 ` [PATCH 11/11] mempool: drop the file name in the top of file comment Christoph Hellwig
2025-11-13 16:12 ` mempool_alloc_bulk and various mempool improvements v3 Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6d035e1-9b29-4a3f-89bd-5f556005d07b@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=ebiggers@kernel.org \
--cc=harry.yoo@oracle.com \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=surenb@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®