From: Conor Dooley <conor.dooley@microchip.com>
To: Song Shuai <suagrfillet@gmail.com>
Cc: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<aou@eecs.berkeley.edu>, <linux-riscv@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <bjorn@kernel.org>
Subject: Re: [PATCH V2] riscv: export cpu/freq invariant to scheduler
Date: Mon, 27 Mar 2023 12:49:44 +0100 [thread overview]
Message-ID: <b6d48638-92b6-4406-b472-90d3d53b021f@spud> (raw)
In-Reply-To: <20230323123924.3032174-1-suagrfillet@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2728 bytes --]
+CC Bjorn,
On Thu, Mar 23, 2023 at 08:39:24PM +0800, Song Shuai wrote:
> RISC-V now manages CPU topology using arch_topology which provides
> CPU capacity and frequency related interfaces to access the cpu/freq
> invariant in possible heterogeneous or DVFS-enabled platforms.
>
> Here adds topology.h file to export the arch_topology interfaces for
> replacing the scheduler's constant-based cpu/freq invariant accounting.
>
> Signed-off-by: Song Shuai <suagrfillet@gmail.com>
Something in CI really, really doesn't like this patch:
https://patchwork.kernel.org/project/linux-riscv/patch/20230323123924.3032174-1-suagrfillet@gmail.com/
The CI stuff applies the patch, builds the tree, resets to HEAD~1,
builds it again, goes back to the applied patch and builds a third time.
Builds 2 and 3 are incremental.
In theory the same stuff should change between applying and removing the
patch, and therefore each of builds 2 and 3 should have the same coverage,
but that doesn't seem to be happening here.
Build 2 looks to have rebuilt almost nothing and build 3 has rebuilt the
world.
I'm gonna chalk that one down as a CI issue rather than your patch!
That said, I was wondering if you would end up submitting this patch,
given the discussion on your last one ;)
Looks to be the same as was done for arm64, so fwiw:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
> ---
> changes from V1:
> - fix the leading underscore and tidy the patch up
> ---
> arch/riscv/include/asm/topology.h | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> create mode 100644 arch/riscv/include/asm/topology.h
>
> diff --git a/arch/riscv/include/asm/topology.h b/arch/riscv/include/asm/topology.h
> new file mode 100644
> index 000000000000..727e8d163a3b
> --- /dev/null
> +++ b/arch/riscv/include/asm/topology.h
> @@ -0,0 +1,20 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _ASM_RISCV_TOPOLOGY_H
> +#define _ASM_RISCV_TOPOLOGY_H
> +
> +#include <linux/arch_topology.h>
> +
> +/* Replace task scheduler's default frequency-invariant accounting */
> +#define arch_scale_freq_tick topology_scale_freq_tick
> +#define arch_set_freq_scale topology_set_freq_scale
> +#define arch_scale_freq_capacity topology_get_freq_scale
> +#define arch_scale_freq_invariant topology_scale_freq_invariant
> +
> +/* Replace task scheduler's default cpu-invariant accounting */
> +#define arch_scale_cpu_capacity topology_get_cpu_scale
> +
> +/* Enable topology flag updates */
> +#define arch_update_cpu_topology topology_update_cpu_topology
> +
> +#include <asm-generic/topology.h>
> +#endif /* _ASM_RISCV_TOPOLOGY_H */
> --
> 2.20.1
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-03-27 11:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 12:39 Song Shuai
2023-03-23 17:24 ` Andrew Jones
2023-03-27 6:48 ` Ley Foon Tan
2023-04-19 14:22 ` Palmer Dabbelt
2023-03-27 11:49 ` Conor Dooley [this message]
2023-04-19 14:22 ` Palmer Dabbelt
2023-04-19 14:30 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6d48638-92b6-4406-b472-90d3d53b021f@spud \
--to=conor.dooley@microchip.com \
--cc=aou@eecs.berkeley.edu \
--cc=bjorn@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=suagrfillet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®