From: Andrew Lunn <andrew@lunn.ch>
To: Coia Prant <coiaprant@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
netdev@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: ethernet: stmmac: dwmac-rk: fix bulk clock leak when the PHY clock fails
Date: Wed, 23 Sep 2026 20:38:39 +0200 [thread overview]
Message-ID: <b6d534b0-8ccc-4cbd-8d13-cd0c887a3260@lunn.ch> (raw)
In-Reply-To: <CALj3r0gPjraK9wy_WbTkeYD1OK_HhSeMi8bDmk03gOVJUb825g@mail.gmail.com>
On Wed, Sep 23, 2026 at 08:31:08PM +0800, Coia Prant wrote:
> Jakub Kicinski <kuba@kernel.org> 于2026年9月23日周三 10:18写道：
> >
> > On Sun, 20 Sep 2026 01:42:23 +0800 Coia Prant wrote:
> > > if (ret)
> > > + clk_bulk_disable_unprepare(bsp_priv->num_clks,
> > > + bsp_priv->clks);
> > > return ret;
> > > + }
> >
> > Missing a bracket, EBUILD. I almost appreciate seeing a human error like
> > this these days :)
> > --
> > pw-bot: cr
>
> That's what I get for hitting send while my brain was EBUSY. Will fix
> and repost shortly.
I almost appreciate a human brain being involved this these days :-)
Andrew
next prev parent reply other threads:[~2026-09-23 18:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 17:42 Coia Prant
2026-09-19 20:44 ` Maxime Chevallier
2026-09-20 8:39 ` Lorenzo Bianconi
2026-09-20 21:58 ` Heiko Stübner
2026-09-23 2:17 ` Jakub Kicinski
2026-09-23 12:31 ` Coia Prant
2026-09-23 18:38 ` Andrew Lunn [this message]
2026-09-23 15:53 ` kernel test robot
2026-09-23 19:22 ` kernel test robot
2026-09-24 22:42 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6d534b0-8ccc-4cbd-8d13-cd0c887a3260@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=coiaprant@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=heiko@sntech.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®