From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCD6F2D8DC8 for ; Fri, 4 Jul 2025 12:40:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751632838; cv=none; b=mozsgRh40u0otdD6jddpO7iitVBW9lC7/Yovnd+vdfN+Sqhb7fhzmibYY27mXb+N/SE5rRbcXgadC98++eHrs+GCFVp4eg7Hw0xmaWLemwEH10WTzEAKeiCbrfDSpB6WWANu8h/Qjy8h8AZ22iOl5gLqYfeEr+plMsdh8+3OCYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751632838; c=relaxed/simple; bh=ywpSKk+4jgbfLnTnCraPZ4p8zS7O4zdYUvoOnznH2q0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X49ZwVNy7785UFDhWQTeP/+MsI69dFIA3qAqL3kXBqcWlSoZrAcU/0LG1bY+iJ666eMq0y5BTrTuHqxVoLrpdkcuCzCZZYxuLPVm22VwRWUfq7SVqPFhmtwqB8pGxnQTSUMEClGSWFNc9fLAU/9FHsmhONsEiaTy/j/2rb66b0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GTyQJgn2; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GTyQJgn2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751632835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ak2/Fyhw1eMRq1SFCol0klu6FdlkrQPHiLtsaCVkfas=; b=GTyQJgn2PNizJS5q1/Axpy4SwVafagXI+laeVYP5DoHcd4JAQEhOQ9UuUG/FzzyVNU2g+4 zTj7hL6HB6ay/eXU/3HsdNlOcdoNtkLpvT/Pz3rMS1E+x7f2qICo7dHeVgAt8B6OlK4lJf MnfL+45yPd/S8QjQu2fr2BA7aXqNRbE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-Mg4ojyubMc6N__N7CoGbTA-1; Fri, 04 Jul 2025 08:40:34 -0400 X-MC-Unique: Mg4ojyubMc6N__N7CoGbTA-1 X-Mimecast-MFC-AGG-ID: Mg4ojyubMc6N__N7CoGbTA_1751632834 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a3696a0d3aso424270f8f.2 for ; Fri, 04 Jul 2025 05:40:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751632833; x=1752237633; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ak2/Fyhw1eMRq1SFCol0klu6FdlkrQPHiLtsaCVkfas=; b=eUwwBulMXoPyIB0m0w9AD/Frwz87Tfw54i/4GunQp3zMskIlmJz1dv5kVZoMx1OPAU a6sESuSE74wH6wG3/TqkMTWtdOR8UmZM+O8Xmowgkki6W3kDrV8rt2/OyLNe6PJ/aM1s jfjB2IT7HrIFGeZGlT91ULqGUMrXzu8tvEJOUVQcUWd8O9FK6eoFqmV6SxQ7jgzlcc2T VQtxqw/1u0A8txeiP1F4Ple15AMEhLkBaTRlFV17p9RGV/dh/52hW56ryJJXPYd2W2pa tgzU/vMssfWWSQGynuzD06sxrIV3kK70e1WjtPnAqvIfWmlr9cB7c+S7w5jzLXa5gSKh x1BA== X-Forwarded-Encrypted: i=1; AJvYcCVHRkJzV4kQt0E5aDI/37t6BIsyw/F979rvGzzXf5trBMhP9rx/6Cm8ZzaGiQIbDr+K71bDaKcPPCRibuA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4fYqPNclVhufM/qGwstYPDlQhuHNtYW4EmcHWdkpXC0TYW5Hh jr1sW4R+gpoW521oY7GkKBzSiH3VvQe3URgdKPIDP7jy+iDhsc9euQitfhsW1dev7tZ2p3HdWSu KuXPay0PmEABRmDAr/KzpGd5JZBID+lCzZCVZTr1CKREGQ5MezV0fKw+bL9oyrohtzg== X-Gm-Gg: ASbGncvSpaknxBCRQfYK6yVJ/UPyhKQ+/Qn90ZSkUjBqWSM5F4wPpKZiG+ZmgMwEsAt tay0iNaaU9CrKlY38prvOTs8AnOnRXuDQKW9QTw1XEqnuQ88HW/ZoxkiRxHjUhZSEPGK1vJlMqZ y1SY8sIqkCyGUQ8jUnoZVFVkt9KGGOiknyNKiKX5hexkwTO7daznCj1FQjePV2TDzhrNpmmMqBD l4lNCZHiSQfAITrz0la2yd0X1taEg5PgRlKw7KPW31zYfk3FOc3df9gI9plm87neqc7sUEsu1RA 6v0fPrNxPSlWKikU+g8s0TjSs2+FW9nGwMUTMzWnH5gnJc15ZzP+casLRyyOEbnJT8PrgiJsU/X l6AKMN4mmz28aTVwLCfDni8OliYe4xH/5jgkVlmM62dEkHHw= X-Received: by 2002:a05:6000:4b1a:b0:3a8:2f65:3745 with SMTP id ffacd0b85a97d-3b4964ea6ddmr2074118f8f.51.1751632833470; Fri, 04 Jul 2025 05:40:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFIg15oUrQ2c+JETxyMOmlFtm65ehLI0srUZF8mkb9XFZQu8aUb8ZTEkw+fL1R3rCyYTNVPdA== X-Received: by 2002:a05:6000:4b1a:b0:3a8:2f65:3745 with SMTP id ffacd0b85a97d-3b4964ea6ddmr2074080f8f.51.1751632833020; Fri, 04 Jul 2025 05:40:33 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:5500:988:23f9:faa0:7232? (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454b1687196sm25507335e9.21.2025.07.04.05.40.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 05:40:32 -0700 (PDT) Message-ID: Date: Fri, 4 Jul 2025 14:40:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 01/14] mm/memory: drop highest_memmap_pfn sanity check in vm_normal_page() To: Lance Yang Cc: Oscar Salvador , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , Lance Yang References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-2-david@redhat.com> <5e5e8d79-61b1-465d-ab5a-4fa82d401215@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 03.07.25 16:44, Lance Yang wrote: > > > On 2025/7/3 20:39, David Hildenbrand wrote: >> On 03.07.25 14:34, Lance Yang wrote: >>> On Mon, Jun 23, 2025 at 10:04 PM David Hildenbrand >>> wrote: >>>> >>>> On 20.06.25 14:50, Oscar Salvador wrote: >>>>> On Tue, Jun 17, 2025 at 05:43:32PM +0200, David Hildenbrand wrote: >>>>>> In 2009, we converted a VM_BUG_ON(!pfn_valid(pfn)) to the current >>>>>> highest_memmap_pfn sanity check in commit 22b31eec63e5 ("badpage: >>>>>> vm_normal_page use print_bad_pte"), because highest_memmap_pfn was >>>>>> readily available. >>>>>> >>>>>> Nowadays, this is the last remaining highest_memmap_pfn user, and this >>>>>> sanity check is not really triggering ... frequently. >>>>>> >>>>>> Let's convert it to VM_WARN_ON_ONCE(!pfn_valid(pfn)), so we can >>>>>> simplify and get rid of highest_memmap_pfn. Checking for >>>>>> pfn_to_online_page() might be even better, but it would not handle >>>>>> ZONE_DEVICE properly. >>>>>> >>>>>> Do the same in vm_normal_page_pmd(), where we don't even report a >>>>>> problem at all ... >>>>>> >>>>>> What might be better in the future is having a runtime option like >>>>>> page-table-check to enable such checks dynamically on-demand. >>>>>> Something >>>>>> for the future. >>>>>> >>>>>> Signed-off-by: David Hildenbrand >>>>> >>>> >>>> Hi Oscar, >>>> >>>>> I'm confused, I'm missing something here. >>>>> Before this change we would return NULL if e.g: pfn > >>>>> highest_memmap_pfn, but >>>>> now we just print the warning and call pfn_to_page() anyway. >>>>> AFAIK, pfn_to_page() doesn't return NULL? >>>> >>>> You're missing that vm_normal_page_pmd() was created as a copy from >>>> vm_normal_page() [history of the sanity check above], but as we don't >>>> have (and shouldn't have ...) print_bad_pmd(), we made the code look >>>> like this would be something that can just happen. >>>> >>>> " >>>> Do the same in vm_normal_page_pmd(), where we don't even report a >>>> problem at all ... >>>> " >>>> >>>> So we made something that should never happen a runtime sanity check >>>> without ever reporting a problem ... >>> >>> IIUC, the reasoning is that because this case should never happen, we can >>> change the behavior from returning NULL to a "warn and continue" model? >> >> Well, yes. Point is, that check should have never been copy-pasted that >> way, while dropping the actual warning :) > > Ah, I see your point now. Thanks for clarifying! I'll add some of that to the patch description. Thanks! -- Cheers, David / dhildenb