mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Wilczynski <m.wilczynski@samsung.com>
To: Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Emil Renner Berthing <kernel@esmil.dk>,
	Hal Feng <hal.feng@starfivetech.com>,
	Dominique Belhachemi <db@domibel.de>, Andy Yan <andyshrk@163.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	linux-riscv@lists.infradead.org,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Icenowy Zheng <zhengxingda@iscas.ac.cn>,
	Chaoyi Chen <chaoyi.chen@rock-chips.com>,
	Joshua Peisach <jpeisach@ubuntu.com>,
	Byron Stanoszek <gandalf@winds.org>, OOHehir <oo.hehir@gmail.com>
Subject: Re: [PATCH v7 0/5] phy: Add the StarFive JH7110 Innosilicon HDMI PHY
Date: Fri, 20 Nov 2026 14:43:14 +0100	[thread overview]
Message-ID: <b6dc6c36-9ce1-49dd-bae5-245d983610bc@samsung.com> (raw)
In-Reply-To: <20261106-jh7110-inno-hdmi-phy-v7-0-d49368303800@samsung.com>



On 11/6/26 14:52, Michal Wilczynski wrote:
> This series adds the HDMI PHY driver for the StarFive JH7110 and shares
> the pre-PLL code it has in common with the Rockchip RK3328 Innosilicon
> HDMI PHY.
> 
> Up to v5 it was part of the JH7110 display series [1]. It is split out
> as Vinod suggested, so it can go through linux-phy on its own; the rest
> continues as v6 of "drm: starfive: jh7110: Enable display subsystem".
> Nothing here depends on the display series. The display series depends
> on this one: its HDMI subsystem binding references the PHY binding from
> patch 1, and it needs the PHY driver at runtime.
> 
> [1] https://lore.kernel.org/all/20260929-jh7110-clean-send-v5-0-82b4d8e3c6c7@samsung.com/
> 
> The JH7110 has the same Innosilicon PHY as the RK3328, offset by 0x100
> because it sits behind the HDMI controller in a shared register block.
> Patch 2 factors out the pre-PLL config format, table lookup,
> determine_rate, recalc_rate and the pre-PLL programming; patch 3 moves
> Rockchip onto it; patch 4 adds the JH7110 driver. Pixel clock tables,
> post-PLL and analog config stay SoC specific.
> 
> Patch 3 should be a no-op for Rockchip - same writes, same order, same
> values - and RK3228, whose pre-PLL is at different addresses, keeps its
> own register code and shares only the lookup. I have no Rockchip
> hardware, so it is build tested only (arm and riscv). A Tested-by would
> help.
> 
> Patch 5 adds a MAINTAINERS entry for the binding and the driver, as the
> other JH7110 PHY drivers have.
> 
> Testing
> =======
> 
> Tested on a VisionFive 2 v1.3B together with the display series, using
> modetest: all 42 modes the sink advertises work, with pixel clocks from
> 25.175 MHz up to 297 MHz.
> 
> Every commit builds for riscv and arm.
> 
> Changes in v7:
> - Point the binding example comment at the hdmi-subsystem binding's new
>   location in bindings/display/starfive/, where the display series moved
>   it
> - Rebased onto v7.4-rc1
> - Link to v6: https://lore.kernel.org/r/20261028-jh7110-inno-hdmi-phy-v6-0-f3379684d97e@samsung.com
> 
> Changes in v6:
> - Split out of the JH7110 display series (Vinod)
> - inno_read() returns the regmap_read() error and recalc_rate checks it,
>   instead of a failed read turning into a zero divisor (Vinod)
> - Bound the pre-PLL and post-PLL table walks with the table size instead
>   of relying on a sentinel (Vinod)
> - Lowercase hex in the JH7110 pixel clock table (Vinod)
> - New patch 5: a MAINTAINERS entry for the JH7110 HDMI PHY, moved out of
>   the display series' entry
> - Rebased onto v7.3, collected tags
> - Link to v5: https://lore.kernel.org/all/20260929-jh7110-clean-send-v5-0-82b4d8e3c6c7@samsung.com/
> 
> ---
> Michal Wilczynski (5):
>       dt-bindings: phy: Add starfive,jh7110-inno-hdmi-phy
>       phy: Add common Innosilicon HDMI PHY helpers
>       phy: rockchip: inno-hdmi: Use the common Innosilicon PHY helpers
>       phy: starfive: Add jh7110-inno-hdmi-phy driver
>       MAINTAINERS: Add StarFive JH7110 HDMI PHY entry
> 
>  .../phy/starfive,jh7110-inno-hdmi-phy.yaml         |  49 ++
>  MAINTAINERS                                        |   6 +
>  drivers/phy/Kconfig                                |   8 +
>  drivers/phy/Makefile                               |   1 +
>  drivers/phy/phy-inno-hdmi.c                        | 358 +++++++++++++
>  drivers/phy/rockchip/Kconfig                       |   1 +
>  drivers/phy/rockchip/phy-rockchip-inno-hdmi.c      | 169 +-----
>  drivers/phy/starfive/Kconfig                       |  20 +
>  drivers/phy/starfive/Makefile                      |   1 +
>  drivers/phy/starfive/phy-jh7110-inno-hdmi.c        | 587 +++++++++++++++++++++
>  include/linux/phy/inno-hdmi-phy.h                  |  88 +++
>  11 files changed, 1144 insertions(+), 144 deletions(-)
> ---
> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
> change-id: 20261028-jh7110-inno-hdmi-phy-83e5cfa643e3
> 
> Best regards,

Gentle ping on this series.

Is there anything else needed from my side ?

Best regards,
-- 
Michal Wilczynski <m.wilczynski@samsung.com>

      parent reply	other threads:[~2026-11-20 13:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20261106135504eucas1p14138c1ce829febb8bcd63c4de1f29ffb@eucas1p1.samsung.com>
2026-11-06 13:52 ` Michal Wilczynski
     [not found]   ` <CGME20261106135505eucas1p1d6f266a6f5c36359454745d176d7ed9b@eucas1p1.samsung.com>
2026-11-06 13:52     ` [PATCH v7 1/5] dt-bindings: phy: Add starfive,jh7110-inno-hdmi-phy Michal Wilczynski
     [not found]   ` <CGME20261106135506eucas1p228bf1f8e1cacdc716e6bf22b847f49d9@eucas1p2.samsung.com>
2026-11-06 13:53     ` [PATCH v7 2/5] phy: Add common Innosilicon HDMI PHY helpers Michal Wilczynski
     [not found]   ` <CGME20261106135507eucas1p2d0b9e53f934f69235757c8708b56fb45@eucas1p2.samsung.com>
2026-11-06 13:53     ` [PATCH v7 3/5] phy: rockchip: inno-hdmi: Use the common Innosilicon " Michal Wilczynski
     [not found]   ` <CGME20261106135508eucas1p27cce9d6dbb87522c9bfc0f39995c2755@eucas1p2.samsung.com>
2026-11-06 13:53     ` [PATCH v7 4/5] phy: starfive: Add jh7110-inno-hdmi-phy driver Michal Wilczynski
     [not found]   ` <CGME20261106135509eucas1p218615ae5c95c50b0f39bfb9cd86b266e@eucas1p2.samsung.com>
2026-11-06 13:53     ` [PATCH v7 5/5] MAINTAINERS: Add StarFive JH7110 HDMI PHY entry Michal Wilczynski
2026-11-20 13:43   ` Michal Wilczynski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6dc6c36-9ce1-49dd-bae5-245d983610bc@samsung.com \
    --to=m.wilczynski@samsung.com \
    --cc=andyshrk@163.com \
    --cc=chaoyi.chen@rock-chips.com \
    --cc=conor+dt@kernel.org \
    --cc=db@domibel.de \
    --cc=devicetree@vger.kernel.org \
    --cc=gandalf@winds.org \
    --cc=hal.feng@starfivetech.com \
    --cc=heiko@sntech.de \
    --cc=jpeisach@ubuntu.com \
    --cc=kernel@esmil.dk \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mani@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=oo.hehir@gmail.com \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=zhengxingda@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®