From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938798AbdAKRs6 (ORCPT ); Wed, 11 Jan 2017 12:48:58 -0500 Received: from ale.deltatee.com ([207.54.116.67]:51102 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752765AbdAKRs5 (ORCPT ); Wed, 11 Jan 2017 12:48:57 -0500 To: Greg Kroah-Hartman References: <1483407036-20697-1-git-send-email-logang@deltatee.com> <20170110215527.GD13381@kudzu.us> <1484089612.12006.11.camel@perches.com> <20170111065036.GA4111@kroah.com> Cc: Joe Perches , Jon Mason , Xiangliang Yu , Dave Jiang , Allen Hubbe , linux-ntb@googlegroups.com, linux-kernel From: Logan Gunthorpe Message-ID: Date: Wed, 11 Jan 2017 10:48:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170111065036.GA4111@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.111 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com, Allen.Hubbe@emc.com, dave.jiang@intel.com, Xiangliang.Yu@amd.com, jdmason@kudzu.us, joe@perches.com, gregkh@linuxfoundation.org X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH 0/2] Style fixes: open code obfuscating macros X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/01/17 11:50 PM, Greg Kroah-Hartman wrote: > You should be printing against the ntb struct device, as that's the > "correct" structure here, and not the PCI device at all, as that's too > far up the device chain from what the driver is supposed to be doing. Yup, agreed and thanks. My v2 patchset already makes this change. Logan