From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A04682DC79D for ; Wed, 3 Dec 2025 09:24:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764753866; cv=none; b=vF7glrBcPl8bXZ0LSRcLWO6BoBFV1pcXgFvqfdKtSDCPOeH+Gofc4ADljSV3o+FANInF42s9FoCHrXwJyXCnkWmUoWE6uNJOH0MIqZ1RcaskkrUDEbu5hxjkgdcLkZ4EaAO5UcttzSbJ3lLQf8zDUv9dlv7hC4+fh0K4xO6gNnY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764753866; c=relaxed/simple; bh=gISgXZarD9qm8hi8sOqrhr7ifIhZiCjDJpFmY8PcJvY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=D4olTmeGIvICsquEkjBQe/cWCVVc+ccbqSmD0ScgzpmE4GwhNUdywrtvwcJ8XUpgJCiC/DfvIZtNf4Gkwx8tftVME23tnzRC9W9t9yRJST6eBS9CYdtc0vLP3m3O2lFSmLO0MmdM+atFkjccOD5oXiPd5KsOtG1bChMZZ+okOEo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VwlykdpO; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VwlykdpO" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-42e2b80ab25so2037039f8f.1 for ; Wed, 03 Dec 2025 01:24:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764753863; x=1765358663; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hIq3IHSi3NCGoALJGtGBwT4WOSI8sD7pseTnOYUGDBU=; b=VwlykdpOBU7mAvpNHu3pxT18+iSR+YKm/j+NQf7Rzz/NwMEdaPFuoyFw4oqPbr2Lhj 9EPd6+xhuQ4sVCTf1VruV1jurUJSN93t10QWp7qFT/qbAfOm901sLF1q5I08f5d9JU4j hVpm3m+TmknE7k/+Ie83xAXMVyda4c6nI397ystW5bG5/nBbKfSPVltSsUouK5QbtbQ5 qlHQtyMWBaI90bkyrXrjP23k8P3AzCy54Hp0J/jATjxvxmoawEiX7PbA+Bxb9v0Ou/6x NtMvawqrApAxx1GtKpkzhyTv6csWcJ3KDfBiJLV1A2FEKPvrsLyquZMYak/OE5zKu6oq CY9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764753863; x=1765358663; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hIq3IHSi3NCGoALJGtGBwT4WOSI8sD7pseTnOYUGDBU=; b=nuzdS9wjNe2pV76qB3EVaAMDFk6pikwh6TVU1TdAle1sxApJlsnPPM+TZPD6fE6iSs EmyHZKqdevQZTIxkZ9WOg2sigw0zcuC0FJlrP7tGqCn5ki6jC7PgGh176Q5IT8gNZh46 luMsRiC21ZokdLLWY729LLr2elEslBLhAExHgJ/eKxSG/NTVoyA6ePvOWFqeXIarIpNW ZVVTu41aHPQXRu01LDOPWWX+2PKtBprRGUJWx+6/EznqEie+o25586bDXxypXS98618C J7f9RMZyxX1UTLSDbiAps3NiZNPAq2bOTeZU2smjPsMPfDcZZfsG1X+N6OclkvlGrl1d TS0w== X-Forwarded-Encrypted: i=1; AJvYcCXD3E2LKAwR/zg1a+6q3L1AUY6AESakgNs/ibRTSw19fKfwv4ttF1tl1FL/dLOS/SE0/UJUMtrsi2UlJ2I=@vger.kernel.org X-Gm-Message-State: AOJu0YyzW3UBp0QBH8sgnRP8YRGO1BBldTG1Ssr5NPzM13wteI2PyHGP dpILWmtfZoaQL/j0xi3mh4vhYoITZYZfVJbaHgTCUzg8ENuxhNOt/h3juptJAH4cw1M= X-Gm-Gg: ASbGncvraaFh2hiFUb9NJTGaAegIyHuJw43FQRc7dk1nY3fvQ4fbeDUrQeeFpdtP7AP YGjxoyGdxRCg6EdTXiUMKBSpvoyNPC/GGwopQR27tiqUopMWewrOXWskoj37LFvKLoWReJzypKh 8YloEv1ivFa7knw479c0lyGwrYaxHSmI5eP69HPcdRM6Ck0kBGF1rdfdMTFU+nkXfThjZgYElRe IUvLYIOBanzRWQo5MoEpjCruaYIgHrpFlgETmu+KvK/7SHTlAn5Ynb5ZLHD15NypnBTi8X3pX6d Sc0e8tEAWRiSUMjWBGNNOozXMGIUvOsm5KmW33n7HbN0nqoMNjuG52W38LxpT7p1xdBs5UPttkE VJmJCErIskObBGCj3SMO3jL5L1J7sDIQQjWhgoCBBTgeuFj2Jo1gIT1xMvCyakWwOMgJwqungLi kRj/F8HLtdLuTvF2t3IqB1vhh+ZXyH9d1AjvRVAEI2sawYPsVn1Lxu6UsMgA== X-Google-Smtp-Source: AGHT+IF2iU8jB8+25UI8v8StXBFRMZ8jem8wdZqu4MTeDmBwzCDt27e9WG51u5pLanJkVFwLbAoY/A== X-Received: by 2002:a05:6000:24c6:b0:42b:39ee:288e with SMTP id ffacd0b85a97d-42f7317d149mr1470532f8f.13.1764753863013; Wed, 03 Dec 2025 01:24:23 -0800 (PST) Received: from [10.255.254.100] (bba-83-110-84-117.alshamil.net.ae. [83.110.84.117]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1ca78f77sm38217963f8f.32.2025.12.03.01.24.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 01:24:22 -0800 (PST) Message-ID: Date: Wed, 3 Dec 2025 11:24:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v6 2/2] dmaengine: dw-edma: Add non-LL mode To: "Verma, Devendra" , "bhelgaas@google.com" , "mani@kernel.org" , "vkoul@kernel.org" Cc: "dmaengine@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Simek, Michal" References: <20251121113455.4029-1-devendra.verma@amd.com> <20251121113455.4029-3-devendra.verma@amd.com> From: Eugen Hristev Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/1/25 11:58, Verma, Devendra wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi All > > Could you all please review the following patch? No need to remind people, your patch will be reviewed. > > Regards, > Dev > >> -----Original Message----- >> From: Devendra K Verma >> Sent: Friday, November 21, 2025 5:05 PM >> To: bhelgaas@google.com; mani@kernel.org; vkoul@kernel.org >> Cc: dmaengine@vger.kernel.org; linux-pci@vger.kernel.org; linux- >> kernel@vger.kernel.org; Simek, Michal ; Verma, >> Devendra >> Subject: [PATCH RESEND v6 2/2] dmaengine: dw-edma: Add non-LL mode >> >> AMD MDB IP supports Linked List (LL) mode as well as non-LL mode. Is this non-LL mode some official name ? (e.g. in the datasheet or official product name ) Because having a 'bool non-LL' as false making it in a LL mode adds a double negation that is difficult to follow. >> The current code does not have the mechanisms to enable the DMA >> transactions using the non-LL mode. The following two cases are added with >> this patch: >> - When a valid physical base address is not configured via the >> Xilinx VSEC capability then the IP can still be used in non-LL >> mode. The default mode for all the DMA transactions and for all >> the DMA channels then is non-LL mode. >> - When a valid physical base address is configured but the client >> wants to use the non-LL mode for DMA transactions then also the >> flexibility is provided via the peripheral_config struct member of >> dma_slave_config. In this case the channels can be individually >> configured in non-LL mode. This use case is desirable for single >> DMA transfer of a chunk, this saves the effort of preparing the >> Link List. This particular scenario is applicable to AMD as well >> as Synopsys IP. >> >> Signed-off-by: Devendra K Verma [...]