mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonas Rebmann <jre@pengutronix.de>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Heiko Schocher <hs@denx.de>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, David Jander <david@protonic.nl>,
	kernel@pengutronix.de
Subject: Re: [PATCH v2 2/3] dt-bindings: mtd: mchp48l640 add mb85rs128ty compatible
Date: Tue, 3 Dec 2024 10:47:44 +0100	[thread overview]
Message-ID: <b6e54b27-a756-4d7a-8b51-4a65772b75e5@kernel.org> (raw)
In-Reply-To: <20241203-mb85rs128ty-v2-2-42df3e7ff147@pengutronix.de>

On 03/12/2024 10:37, Jonas Rebmann wrote:
> Add a compatible string to support Fujitsu MB85RS128TY.
> 
> Signed-off-by: Jonas Rebmann <jre@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml b/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml
> index 0ff32bd00bf6aee279fa78c624d8d47c6162f7f1..11f64056a28f98ad633265b00605ffd2c3e026c8 100644
> --- a/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml
> +++ b/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml
> @@ -16,8 +16,9 @@ description: |
>  
>  properties:
>    compatible:
> -    items:
> -      - const: microchip,48l640
> +    enum:
> +      - microchip,48l640
> +      - fujitsu,mb85rs128ty


Keep alphabetical order. That's generic rule for all compatible lists in
bindings and drivers. It's a rule for many other growing things as well,
because it helps to avoid conflicts.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

  reply	other threads:[~2024-12-03  9:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03  9:37 [PATCH v2 0/3] Add support for Fujitsu MB85RS128TY Jonas Rebmann
2024-12-03  9:37 ` [PATCH v2 1/3] mtd: mchp48l640: make WEL behaviour configurable Jonas Rebmann
2024-12-03  9:55   ` Heiko Schocher
2024-12-03  9:37 ` [PATCH v2 2/3] dt-bindings: mtd: mchp48l640 add mb85rs128ty compatible Jonas Rebmann
2024-12-03  9:47   ` Krzysztof Kozlowski [this message]
2024-12-03  9:37 ` [PATCH v2 3/3] mtd: mchp48l640: add support for Fujitsu MB85RS128TY FRAM Jonas Rebmann
2024-12-03 10:01   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6e54b27-a756-4d7a-8b51-4a65772b75e5@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=david@protonic.nl \
    --cc=devicetree@vger.kernel.org \
    --cc=hs@denx.de \
    --cc=jre@pengutronix.de \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®