From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D153226E71E for ; Fri, 19 Dec 2025 13:13:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766150038; cv=none; b=XyOPhyTaAF+HkI9Tc8v2gfKNxSB1a5P/d1wuaRTHK6N53kbt3xcHDn46UFMmsqJ/MtobhDrUyCxURNm7wf+gUfH6OCAspjEMhx39VI3sgUymUaOlLpQIhth2evqwDmXtp44EkkRGGj4gE++YKF+odx22eO+bfTbacP0j3zo19Jo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766150038; c=relaxed/simple; bh=LsZk8BtGewNpCcVNoqX/+ftW+U7rkPSJzxmPQuu1JWM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fB4X8XAJ6Ds+BA+dUERHBFJTA4tOhvr9Ho7VGhGwc+5NE/aJSgaeYLenrnRMGXYR/Iw6OkX1PUTz8qZvH0Uy7ZGDsj3oPHdzC/S7Iq5Q+gmrRfgRiDW2WbjeHmjGQcDA+8OHofbYot2OP6507e0DTjzPp6RiTVJLqTFTuxo0JcI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WUnwpwtH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=R7X1ihre; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WUnwpwtH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="R7X1ihre" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJBlapX3700746 for ; Fri, 19 Dec 2025 13:13:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DZ4cWgr492jZ4A0tRfEHTUVnW4j07Cs3++LAWhIPvXI=; b=WUnwpwtH7P1M6alv uVW54/UjP/42vHmI3DKVGc3RW6I5bzghBAxM4VbLjCStETJjqsSmitCoQV6u30WJ MtjatfsHj/t+/qO6xQ7Mkdj1Hps/wVFu6pte3Tkqp2If7EUrfxjWk4tV178mKGQu LCbTPV7FDD3Cc654EbPqzp1M5RKeA3XzIpMwe82KkAvpWmYIfP5p7GVXE0eNHddF dYg3QSpdJd3WZ7PexAAJs+ShTXUV43FjzEJNZycQfj3NHJy5mZBVZdENIXoXJTz+ HiYxVgcp1Uu6NbHkPOegxY6tHZOg+6jgw7AwJxkd4qC1tIVf71dmEWm8jWcmcJWu ToVbkw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2ejp6g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 13:13:55 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a0a4b748a0so38619995ad.1 for ; Fri, 19 Dec 2025 05:13:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766150035; x=1766754835; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DZ4cWgr492jZ4A0tRfEHTUVnW4j07Cs3++LAWhIPvXI=; b=R7X1ihreUGm5eULZtELWYJcGL14MqDGuj6/dnlmFPyPo7oxlnYAKbMC0RnR+NLumfY hv75GUGDISZ9Hdcywi+79lULamoMjxXDltSlBOeap7qq80l31PF+QkMcCdjKHF8DQvh0 XZdsCbDScKhjvAwpAZrr+EtpsgPxcJVXd8XxcUUx1p7bouuS5oINHISyjLkttboVsu0O E11llQ7gQnXX4QrgEJa7lU6Y2le4MROfz3QXXFfmgODd0ivbyUJSvYJfohEo6GxZMOcC iM7OFYlncf5yKNdLLGA1CVtzlcvs3wZIqd5oFMoG/vbJKqo5dwX6jcJboO5K/xq+qpbr 71lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766150035; x=1766754835; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DZ4cWgr492jZ4A0tRfEHTUVnW4j07Cs3++LAWhIPvXI=; b=rUubluy170q1kGJEOy3cJa2bXhgfzCfgPa2WmjnOB8A7RTKxIREPzFnV4oM5JU5YJz A5qibR08PgWD9I67mAtn4ZA2J+cgiVdMESitjsenM/4jMx8+X7sueVLeRzgqZc0w5iI3 LyXt2rsupYLCsDsPZJsF5/PNLzxKRQh24T2unHO3utuMj4mVY1CnuVUHeOKcMihkF1Kk QN+zqZdgBR+RxtFydQS2LajD8onKwkmH9kwIw5dVUKFC3eVO9621UC+lnW9m7lf+Rcy6 NqWVlF5wnL5g5VhyNHRGBy+2V9EKJma32ya2ErvhtMvtUFN1G85KNETdBZnUwlOABB3P rsQw== X-Forwarded-Encrypted: i=1; AJvYcCUAM8fTRgAKM5cKkh/RD9A7Z2aQtss/vobwlItiCVeOXQogdJW0KBYLBXmst2pq+bSKHMvwr/HmfdqdGgo=@vger.kernel.org X-Gm-Message-State: AOJu0YyVhWEil5nm+CBqMndg3P5dM2eNHAPYy6WbPx88shFXKsP/PA06 wXsKhzhs8JaFTYSmhU7aJgrDboOuIkeg+XIza48QuF52uqUrmV6GjVfReKTlNkxmg2Ju/UIr/RQ aY4E0Ro1Vb9g9NEkup/mctNt3+xFavr4T9mwlB49MlfMn1TQm1QASWYxtICJpG3jUMhY= X-Gm-Gg: AY/fxX6uhjBwYJ+jPnqKacYvCRdGIbNXmzG2H2IIGGQQLrv2SMyu2/3MI33AKAZDrO3 PWs/1JwGmu4V5PTWWQcrEVy4RkFxqY4hg6t7YVe6ExIMWT+EvhwZGPP5O0Ve9k9k3F/0NygJ89k P8lS5sakF9Hx3yXCYjB0r5cwrbLarLZbraSSO/EipD65SXZyJ6nCflT9+bkejusQfZs4UTBue0j BRWUdIPyAmiGpAg9bzdxkmeHeSEmK23o4DDGzEBSzIBRibuDCwkqC5G7oISgGaV73tmBEhIVYM5 F2yrzHtBDhH6V5BvEnmDucfIIR9ldJkGTxeZeeCFc73XK8jUEmrE3vfMzdLpco2c1fcnVEMCPIo CinSEZC06uzwunS2pYGtqymxA0U2iIW6BpGMEaiqLIA== X-Received: by 2002:a05:6a20:4325:b0:34f:afaa:125b with SMTP id adf61e73a8af0-376a94cb491mr2907456637.50.1766150034597; Fri, 19 Dec 2025 05:13:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IGYCPPY9VYTPF6C/Lkfrn8noIWAo3NlMi+7Jam2/Qm6HLPcczfWWp2MFNi11cChB7Wb8OSBCg== X-Received: by 2002:a05:6a20:4325:b0:34f:afaa:125b with SMTP id adf61e73a8af0-376a94cb491mr2907407637.50.1766150034097; Fri, 19 Dec 2025 05:13:54 -0800 (PST) Received: from [10.217.217.28] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3d4d2bbsm23264525ad.55.2025.12.19.05.13.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Dec 2025 05:13:53 -0800 (PST) Message-ID: Date: Fri, 19 Dec 2025 18:43:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V8 3/4] iio: adc: Add support for QCOM PMIC5 Gen3 ADC To: Dmitry Baryshkov Cc: jic23@kernel.org, robh@kernel.org, krzysztof.kozlowski@linaro.org, krzk+dt@kernel.org, conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org, lumag@kernel.org, konradybcio@kernel.org, daniel.lezcano@linaro.org, sboyd@kernel.org, amitk@kernel.org, thara.gopinath@gmail.com, lee@kernel.org, rafael@kernel.org, subbaraman.narayanamurthy@oss.qualcomm.com, david.collins@oss.qualcomm.com, anjelique.melendez@oss.qualcomm.com, kamal.wadhwa@oss.qualcomm.com, rui.zhang@intel.com, lukasz.luba@arm.com, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, cros-qcom-dts-watchers@chromium.org, quic_kotarake@quicinc.com, neil.armstrong@linaro.org, stephan.gerhold@linaro.org References: <20251127134036.209905-1-jishnu.prakash@oss.qualcomm.com> <20251127134036.209905-4-jishnu.prakash@oss.qualcomm.com> Content-Language: en-US From: Jishnu Prakash In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: l4H22Y8NkfSksWmfy0Q80dgul9162-Iv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDExMCBTYWx0ZWRfX6Dtdafo5X7sx PrA3oFvp/dq6G51D/I2oQbMFIaIEOrGpqo28gZbVL06Wg2XXw2f5hae4zwlQkPiC3ZeC3+0hBfF suMi38r+Fj3IxppghR3GWo6CmN8sb2O7SQTG5Kv4epArgEisBhhJekwnc7EBlRnd5vNHmVQSAMm F5l2quPOVwCSQ7i6qzazMpVBWHHNO/q5r2ogM9S3Gv/XAuculpkPA8A03EyuainI0DpLtzz92qN PiDpuO1adrCileZqKqp7W31+K+/WmpCqbwvC8qWaYChL3Bc1d83lFPAq6WBliDQwUz4ZCj+19Kr ghc/h6BGOmG4ecmg2HFG6MrXMDZnW6prwRkmf4eaAbe8G20p0A8XdXYR2QZrc1WQFUc81S7kBZw I+/ekurfac1mPL7nzHnVSd6Hxek1x9ek3SFOf5zwvaW2djBOxHYufZ7ig6EBY7iFBwiobVk/uOr l6xsU4GhWNvtjslKlGQ== X-Proofpoint-ORIG-GUID: l4H22Y8NkfSksWmfy0Q80dgul9162-Iv X-Authority-Analysis: v=2.4 cv=EabFgfmC c=1 sm=1 tr=0 ts=69454f93 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=H6YMLcam0HurB3DtvNQA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_04,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 suspectscore=0 priorityscore=1501 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190110 Hi Dmitry, On 12/6/2025 7:52 AM, Dmitry Baryshkov wrote: > On Thu, Nov 27, 2025 at 07:10:35PM +0530, Jishnu Prakash wrote: >> The ADC architecture on PMIC5 Gen3 is similar to that on PMIC5 Gen2, >> with all SW communication to ADC going through PMK8550 which >> communicates with other PMICs through PBS. >> ... >> drivers/iio/adc/Kconfig | 30 + >> drivers/iio/adc/Makefile | 2 + >> drivers/iio/adc/qcom-adc5-gen3-common.c | 107 +++ >> drivers/iio/adc/qcom-spmi-adc5-gen3.c | 767 ++++++++++++++++++ >> include/linux/iio/adc/qcom-adc5-gen3-common.h | 216 +++++ >> 5 files changed, 1122 insertions(+) >> create mode 100644 drivers/iio/adc/qcom-adc5-gen3-common.c >> create mode 100644 drivers/iio/adc/qcom-spmi-adc5-gen3.c >> create mode 100644 include/linux/iio/adc/qcom-adc5-gen3-common.h >> >> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig >> index 58a14e6833f6..da201a9a6950 100644 >> --- a/drivers/iio/adc/Kconfig >> +++ b/drivers/iio/adc/Kconfig >> @@ -1319,6 +1319,36 @@ config QCOM_SPMI_ADC5 >> To compile this driver as a module, choose M here: the module will >> be called qcom-spmi-adc5. >> >> +config QCOM_ADC5_GEN3_COMMON >> + tristate > > This Kconfig (and the module) are used only by QCOM_SPMI_ADC5_GEN3. Why > do you need to separate them? Your thermal module doesn't depend on the > common functions. > The module added with the above config has five exported functions which are all used in the thermal module. But now it looks like I have exported functions both in the common module (drivers/iio/adc/qcom-adc5-gen3-common.c) as well as in the main ADC driver file (drivers/iio/adc/qcom-spmi-adc5-gen3.c), which seems like unnecessary separation. So I can drop the separate file as you mentioned, and keep all the exported functions in the main driver file alone, in the next patch series. Thanks, Jishnu >> + >> +config QCOM_SPMI_ADC5_GEN3 >> + tristate "Qualcomm Technologies Inc. SPMI PMIC5 GEN3 ADC" >> + depends on SPMI && THERMAL >> + select REGMAP_SPMI >> + select QCOM_VADC_COMMON >> + select QCOM_ADC5_GEN3_COMMON >> + select AUXILIARY_BUS >> + help >> >