From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sameer Pujar <spujar@nvidia.com>,
broonie@kernel.org, lgirdwood@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, perex@perex.cz,
tiwai@suse.com, kuninori.morimoto.gx@renesas.com
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: Add sample format conversion
Date: Tue, 2 Aug 2022 09:29:02 +0200 [thread overview]
Message-ID: <b6e7d391-904a-170c-b398-c049ea2c8a0c@linaro.org> (raw)
In-Reply-To: <fbe773df-7a92-df52-740e-41bb2f47c1f7@nvidia.com>
On 29/07/2022 06:11, Sameer Pujar wrote:
>> diff --git a/Documentation/devicetree/bindings/sound/simple-card.yaml b/Documentation/devicetree/bindings/sound/simple-card.yaml
>> index b261d49..6decd73 100644
>> --- a/Documentation/devicetree/bindings/sound/simple-card.yaml
>> +++ b/Documentation/devicetree/bindings/sound/simple-card.yaml
>> @@ -77,6 +77,17 @@ definitions:
>> description: CPU to Codec rate channels.
>> $ref: /schemas/types.yaml#/definitions/uint32
>>
>> + convert-sample-format:
>> + description: CPU to Codec sample format.
>> + Value Format
>> + 0 S8
>> + 2 S16_LE
>> + 6 S24_LE
>> + 10 S32_LE
>> + 32 S24_3LE
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> Wait, you now put the same property in four different places. Don't you
>> have something which could be shared?
>>
> There is no shared schema between simple-card.yaml and others. I will
> have to create a new doc to share these definitions.
OK
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-02 7:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 14:26 [PATCH 0/2] DT binding for " Sameer Pujar
2022-07-27 14:26 ` [PATCH 1/2] ASoC: dt-bindings: Add " Sameer Pujar
2022-07-28 12:22 ` Krzysztof Kozlowski
2022-07-29 4:11 ` Sameer Pujar
2022-08-02 7:29 ` Krzysztof Kozlowski [this message]
2022-07-27 14:26 ` [PATCH 2/2] ASoC: simple-card-utils: Fixup DAI sample format Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6e7d391-904a-170c-b398-c049ea2c8a0c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=spujar@nvidia.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®