From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C851C001B0 for ; Tue, 27 Jun 2023 13:37:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230229AbjF0NhR (ORCPT ); Tue, 27 Jun 2023 09:37:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbjF0NhP (ORCPT ); Tue, 27 Jun 2023 09:37:15 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3C1B2962 for ; Tue, 27 Jun 2023 06:37:13 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-98e109525d6so548746166b.0 for ; Tue, 27 Jun 2023 06:37:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687873032; x=1690465032; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Zjn+m5IJNtwxVd6i0hgU1RQ6FBtfGTIs6fzcd38U4Jo=; b=fNEBITWaLLZCAFNoYkPQcaqn8qMhZVIH4tjFvICdPg7UH3NeqXNX09RHP19a29h8zL 4oAQbPXWNPZNaKyMaBoMMpnr3blZrVLVT+DPEMnbhP/nYY630gZvlRFHQf5Dt9WK1Ivv w+F57Jh2DuPGYZUOe6//JFfeQ26Zj+R3yIJY0YEd4Y1GcNSEgJU4n81O8HhrCtmV7Au8 Ng99JeM0diRKB11msr6h9cupKH9Ja0Cu00SxxaKQO+3RcJRSKiJf0hQp4SYummOo4zJD RiOuRzv6hTEdPBAq27Ayw2sN0TWu3A7VVbjCZovndTpye+j30JleNaSolsnjq9bXaDS7 TBgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687873032; x=1690465032; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Zjn+m5IJNtwxVd6i0hgU1RQ6FBtfGTIs6fzcd38U4Jo=; b=hsWQxdscBMgb2AWl3UEkKxOvL/72tjHjRWjs4W4rEyOKVPORl9ZwlZAdaZm03GJTYK MsS37LOFCCr1RoOZZATXfRZPqqbp4nYJ4Gwh4jpLuITigE1KDDuUnBRAJ6lp/rVUpwJa Lno4zx1CtmUvDcO0U2pEXNyPUynRa3B3Zr9ygh/U1Uq9+2Z9f8po/6W4u/MLjhjG1MUl Yk9T1lbAIahfz4VdLHHTYmrujahiiyRlEfGZhPRUj6amH0/EwT+pZADWYWdS9WGUEOJb ZEVVySl3kVR4ISaxyLhe9Juh/E/ZLb+6CGFZuPRY7xyHs8mAYHauwvQ8NI0Ntq9Mk63z YliQ== X-Gm-Message-State: AC+VfDwtJQszxpgUPcMX3/bpPMVsIbVmshRtpiL/l26fAR2vDCPYYkxR WfopE5c4Ppc9WK+Lf4AA6ViWpg== X-Google-Smtp-Source: ACHHUZ5KPZiM0xwFFkDm9ASG5ZrHrep9NXMTXPqfYF8cYZacARH7VH8i601pygIFhMDQpdq/gxZYxg== X-Received: by 2002:a17:907:2da6:b0:988:15f4:fdba with SMTP id gt38-20020a1709072da600b0098815f4fdbamr29369700ejc.14.1687873032258; Tue, 27 Jun 2023 06:37:12 -0700 (PDT) Received: from [10.230.170.72] (46-253-189-43.dynamic.monzoon.net. [46.253.189.43]) by smtp.gmail.com with ESMTPSA id i10-20020a170906250a00b0096a6be0b66dsm4573216ejb.208.2023.06.27.06.37.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jun 2023 06:37:11 -0700 (PDT) Message-ID: Date: Tue, 27 Jun 2023 15:37:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: Aw: Re: [PATCH v1 1/2] dt-bindings: mmc: mtk-sd: update assigned-clocks/clock-parents for mt7986 To: Frank Wunderlich Cc: Frank Wunderlich , linux-mediatek@lists.infradead.org, Chaotian Jing , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Wenbin Mei , Sam Shih , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230625191151.7808-1-linux@fw-web.de> <20230625191151.7808-2-linux@fw-web.de> <91411797-18b4-f515-d6c0-ca0f8ff39696@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/06/2023 14:09, Frank Wunderlich wrote: >> Gesendet: Dienstag, 27. Juni 2023 um 12:44 Uhr >> Von: "Krzysztof Kozlowski" >> Betreff: Re: [PATCH v1 1/2] dt-bindings: mmc: mtk-sd: update assigned-clocks/clock-parents for mt7986 >> >> On 25/06/2023 21:11, Frank Wunderlich wrote: >>> From: Frank Wunderlich >>> >>> MT7986 has 2 clock-parents so update the binding for it. >> >> You didn't test it, I think. If you do, then you will see errors from >> other trees. > > Hi, > > i tested it of course...which errors do you see? The top-level said it can be maximum 1, so raising it in allOf:if:then: should not be enough > 11 > this is basicly how i tested it (in case anything has changed): > > logfile=dtbs_arm64.log > exec 3> >(tee $logfile) > ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make DT_CHECKER_FLAGS=-m dt_binding_check 2>&3 > if [[ $? -ne 0 ]];then echo "arm64 binding check failed!";cat $logfile;exit 1;fi > ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make defconfig #dtbs_check need kernel-config > ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make -j8 DT_CHECKER_FLAGS=-m dtbs_check 2>&3 > if [[ $? -ne 0 ]];then echo "arm64 dtbs_check failed!";cat $logfile;exit 1;fi A bit over-complicated... why not running dtbs_check against the schema you changed? > > and looked into the resulting logfile for keywords like mmc like mtk-sd > > i tried running dtbs_check with passing the yaml-file, but of course all compatibles not matching this file were reported. > > ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make -j6 DT_CHECKER_FLAGS=-m dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > but this spits out many errors "failed to match any schema with compatible" because i defined only the changed one... > > maybe there is another way to check only one yaml file against all dtbs without these unrelated errors. > > pipeline in dt-bindings-patchwork is clean too > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230625191151.7808-2-linux@fw-web.de/ Maybe that binding just fails to apply to DTS because of missing or not correct compatibles. > >> Anyway, I don't understand why defining it in the first place. Just drop >> the assigned-clock* from the binding. > > as it was defined (not looked where it was used) i only used the soc-specific branch to update the MaxItems...just to not break anything. After that the message i got before was fixed > > arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: mmc@11230000: assigned-clocks: [[4, 35], [4, 34]] is too long > arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: mmc@11230000: assigned-clock-parents: [[5, 6], [4, 18]] is too long > > but if the right way is to drop the MaxItems from generic (or the property itself - where is it taken from then?). The only > include i see is Documentation/devicetree/bindings/mmc/mmc-controller.yaml and there the assigned-clock* is not defined. And the The way is to entirely drop assigned-clocks. I don't think there are much benefits of having them in the bindings. Maybe if specific rates are required, then yes - device cannot work with other rates and you can verify it with dtbs_check. But otherwise it is like adding values of 'reg' or 'interrupts'. Plus some board might require third item and then what? Best regards, Krzysztof