From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EEE2280A4C for ; Tue, 6 May 2025 13:14:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746537278; cv=none; b=PMzDO2v/lFuIq93Z4ycpoDTJnNX44XPi9v5RL11SlGpaN+fLLecl5wjim1um71zD0Q6B/BPzKlBRyHyiNLl5WQtDd1MTriKVxnpu+XPJc1vXGALZ2T6vo5C4YH+j1EZqfZYGi/jeBkidWC3jpht16mAdzHliM9fLb7tSdDJHX7A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746537278; c=relaxed/simple; bh=0lVpTpURlEeanuAjIbJkgLatYhwU//vfEa0K/jV5aS0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AA+qObo3UZ0NoxNv2gHyGrzlxMKFiDa/LbLQdnE7FtW7nQTjXsfBXQNqXm6R0WffYePfUAkjrYYwGT++tUEF8vGDqj+2p3P14CEn9omde2egpXoj6U7Q+dbAajPn8Sgc1V9785O/S3KrqEVV9LmvtwGNmYXG2MSzAV2g3+a3aAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=q/2zNfjc; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="q/2zNfjc" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-391324ef4a0so278380f8f.2 for ; Tue, 06 May 2025 06:14:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746537275; x=1747142075; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=c7cAReDyTT7KLErUElBQxOzZHmwxniNtnYOivuVBS5A=; b=q/2zNfjc70SIpUneFOzPYV1t2XG6zmtVT3baUYmSLLQZ/9q2QPDkjiC4gk6Tm3ef2R MCZAzNufjisTVKcO24XaQa0r3WVyQE/qb/EI+OYmKjnU02tzkc0wrD2CxbBa6PNGA7ru XV23/Agxmktz5htrLQv7qdOrAwpGQGt1fr49vXvFk/wwCyq107/0UAVId7a8y5A3wQpk yBxf9b0CGAKPj5CWepsLUETapQgvGEKKKHVoYMi5xJLMctp6KTp5OB00gRGQs+5gI0Ok HysYyaMHjukc9OhHeW4+Yj2pbv+GfgB8Yx97f3sYxG/ivdYjD3lbIdQO/dafJjHvGoE3 QIdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746537275; x=1747142075; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c7cAReDyTT7KLErUElBQxOzZHmwxniNtnYOivuVBS5A=; b=J9I3mVetUNjE+lVsPyk7I1jeNj9bq9+ZPmiA3JoQP7MRXh+bqEDyDN73Dqy24WlV1g PDyn8EEDON4FYvssfhyOdtiDyM+wkq44g9Yq2Vz62QWKnsLVq4p5cb8db+tJ6eg7R9V9 z5z3dhzn+RfEI7oar1UHCwaptzHdfDm71Bi/Drx/XiEXBlHxYydYuR1gd00yBjbotOc4 acykazi88dKctsH8kXEZZzzTloMFgk3jXBSmpMCUtXcEhMa6B6amCFvGo4XutAtVqdKZ Zv4OZTIsJkF24kUh1j+FTQHLIOncew3priMCIjsWaRHsk/3YVF9S6N/vxUbhOZqSX55z 84CA== X-Forwarded-Encrypted: i=1; AJvYcCUnr8yhb78y3Rcl2jtgeBaCyhCUNCuaLKmIwAm36WgdhSGJyM2fkwfrUI+rYPWhznh6DskQLz/fIvnUy4E=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6F6qKnqKSRkHTLRCgXozxnEehBReABMDtJdj3eFIQG7RNbKqr Fj3olamQeRF2qWawPDd1qR2jfLhSDNdJZ6WvmZPNdlKvbAmYkvljseiGWY8cPWs= X-Gm-Gg: ASbGnct1vO9H45+cnzMCsam1Zp60KZ/rJTJuFOIW3V3Va2PURjga9fgvGcfsqIpvXgI iYzPyDT14pkYAM0ii0hjTIjc3BlFfSAvNb/WJmVWSM+AU60MITSW51Hy/kBhE21zPnvfedafqCl UmN6wSbAiAn88adQP7BMiyxS/hQGmGiQvbr/2vltV5Fh1jnLM+LnXnRvkxffaDO2TAQKGyhtqtA ZG23EjU8fIx+j6UcADhX+FDeWIHXZJyvpGaemWF05QcMdTR8Iyzggte1pIDzp9v9zhfg38K9aB2 gbo7ae9t2zQ1jNB2jFT+WDpvKc61Qgk9W3u9Ms/X6NDJuWqm7v8vmC2UUSbGHngdP9NSjw== X-Google-Smtp-Source: AGHT+IHUYyISjmDireWFtDYjhqWAUlSvfGhfXOGmsTZqVCqhQoczfJap3uTQfjwXsBjjug1VXr6i9w== X-Received: by 2002:a05:6000:144d:b0:39f:6a9:40bf with SMTP id ffacd0b85a97d-3a099aee68emr4577556f8f.10.1746537274675; Tue, 06 May 2025 06:14:34 -0700 (PDT) Received: from [192.168.1.28] ([178.197.207.88]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099ae3403sm13578819f8f.28.2025.05.06.06.14.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 May 2025 06:14:33 -0700 (PDT) Message-ID: Date: Tue, 6 May 2025 15:14:32 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: defconfig: Build STMMAC Ethernet driver into the kernel for NFS boot To: Geert Uytterhoeven Cc: Prabhakar , Catalin Marinas , Will Deacon , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Biju Das , Fabrizio Castro , Lad Prabhakar , Arnd Bergmann References: <20250506104731.111876-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <3a11ba8a-a9f4-4829-8bcd-56f1702bee8f@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+AhsD BQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmgXUEoF CRaWdJoACgkQG5NDfTtBYpudig/+Inb3Kjx1B7w2IpPKmpCT20QQQstx14Wi+rh2FcnV6+/9 tyHtYwdirraBGGerrNY1c14MX0Tsmzqu9NyZ43heQB2uJuQb35rmI4dn1G+ZH0BD7cwR+M9m lSV9YlF7z3Ycz2zHjxL1QXBVvwJRyE0sCIoe+0O9AW9Xj8L/dmvmRfDdtRhYVGyU7fze+lsH 1pXaq9fdef8QsAETCg5q0zxD+VS+OoZFx4ZtFqvzmhCs0eFvM7gNqiyczeVGUciVlO3+1ZUn eqQnxTXnqfJHptZTtK05uXGBwxjTHJrlSKnDslhZNkzv4JfTQhmERyx8BPHDkzpuPjfZ5Jp3 INcYsxgttyeDS4prv+XWlT7DUjIzcKih0tFDoW5/k6OZeFPba5PATHO78rcWFcduN8xB23B4 WFQAt5jpsP7/ngKQR9drMXfQGcEmqBq+aoVHobwOfEJTErdku05zjFmm1VnD55CzFJvG7Ll9 OsRfZD/1MKbl0k39NiRuf8IYFOxVCKrMSgnqED1eacLgj3AWnmfPlyB3Xka0FimVu5Q7r1H/ 9CCfHiOjjPsTAjE+Woh+/8Q0IyHzr+2sCe4g9w2tlsMQJhixykXC1KvzqMdUYKuE00CT+wdK nXj0hlNnThRfcA9VPYzKlx3W6GLlyB6umd6WBGGKyiOmOcPqUK3GIvnLzfTXR5DOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92Vcmzn/jaEBcq yT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbThLsSN1AuyP8wF KChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH5lSCjhP4VXiG q5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpFc1D/9NV/zIWB G1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzePt/SvC0RhQXNj XKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60RtThnhKc2kLI zd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7qVT41xdJ6KqQM NGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZv+PKIVf+zFKu h0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1qwom6QbU06ltb vJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHpcwzYbmi/Et7T 2+47PN9NZAOyb771QoVr8A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 06/05/2025 14:42, Geert Uytterhoeven wrote: > Hi Krzysztof, > > CC arnd > > On Tue, 6 May 2025 at 12:52, Krzysztof Kozlowski > wrote: >> On 06/05/2025 12:47, Prabhakar wrote: >>> From: Lad Prabhakar >>> >>> Enable `CONFIG_STMMAC_ETH` as built-in (`y`) instead of a module (`m`) to >>> ensure the Ethernet driver is available early in the boot process. This >>> is necessary for platforms mounting the root filesystem via NFS, as the >>> driver must be available before the root filesystem is accessed. >>> >>> Signed-off-by: Lad Prabhakar >> >> Same comments as for previous patches like this (even the same?): you >> are supposed to use initramfs for your arm74 boards. Even armv7 boards >> use initramfs, so network driver does not have to be built in. > > Are we? When has that policy changed? Why are lots of network drivers > still built-in? Making network drivers built-in for systems where I would be happy to make them modules, but it is different thing to accept new patch like that than change existing workflow. > development is done using nfsroot has always been acceptable for the > arm64 defconfig before. For things not critical for booting, modular > is indeed the preferred way. And this is not critical for booting. System boots perfectly fine, all critical SoCs are working, serial is working, clocks/interconnects kick in, kernel mounts initramfs and you can probe the network/USB/storage to mount rootfs. > > arm64/defconfig is for development and testing, not for production > (which famous kernel developer said that before?) And we all for testing use initramfs, don't we? I really do not understand the problem being solved here - all of our setups are supposed to have initramfs already. My simple, private CI even has it, so if such little fella like me is able to use initramfs, I am sure that SoC vendor can adjust their CI as well. > >> For example all of our setups use it thus we do not have to populate all >> other vendors with our own drivers. >> >> Sorry, but I am strongly against such change. Kernel is already way too > > The kernel will grow without this (it will just take a few more weeks ;-), > so that is IMHO not a good argument. I meant, kernel built out of defconfig. Yes, it will grow and my comments are, hopefully, slowing that growth so I can still work with kernel defconfig. Otherwise why Renesas usecase of defconfig - built in modules, because initramfs is too difficult (???) - is more important than my usecase of small defconfig for my development? And there is a consensus: use initramfs, just like we all are supposed to use since years. > >> big and with KASAN it does not fit to boot partitions in some of the >> devices (and I cannot change the boot partition size, at least not >> without big effort). > > arm64/defconfig does not have KASAN enabled? Does not have, but I want to be able to toggle KASAN and boot the kernel, without going through 1000 kernel options which I could disable or toggle to module to get the kernel fit into boot partition. > >> Nacked-by: Krzysztof Kozlowski > > Doh... Sorry that it feels harsh. I do not create the policy, but lack of my words of objection are then used again in many discussions, e.g. via "someone added patch like this, so I can add as well". I won't feel offended if you take the patch with my Nacked tag. Best regards, Krzysztof