From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2C8D3B7B91 for ; Thu, 26 Mar 2026 09:13:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774516381; cv=none; b=TW2N36tRq+ZLYTfIp5pjwFenM94mQ8z5y7tn23H4b486Mr0NX6Ila/VIl0paP1tTHS6+7prHOvlXq2RZ/BufIALbvCrE5RDJlRD/N/xURBWMIx5IXOzLhRxGtPcHRjcE8qAgTXQCx5w5Ihu+2unJET6jMBH3L0OVcdm3zjuIdo0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774516381; c=relaxed/simple; bh=ORsgovw9/k2NND7nAMRCj0B9MoxyZlpT8v8tN5eWsIk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Tc2LO8i6kPCJiExWZpK3fA5vlEB4pVeEyK+6j0BSqEoxV9Ur5SYUotorCSpWSpD4Vz9ctuzvJwWdwm3WndOUPbDeQwk9k7F/x+vc48SqCVtzNLk6X4XsRRmFz8C7RpDw3Yi7ybrfLvdopqwkrtzZ+YUJGQNIZumtNY7xo09pEv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QMOZGBmF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YiKxU82u; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QMOZGBmF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YiKxU82u" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62Q6x3Ex1060842 for ; Thu, 26 Mar 2026 09:12:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lLH2vp3omnzVgPghVQJ26xXtRhk3RZK9WfsJL6kRllM=; b=QMOZGBmFvZEC5bkz r27hgpUh7ljumj1WAgCJ/19uW995EAqX9OSP9eKyigBE23N7XNyQb//nNy7F7WIA hS2ZDfQnwTVOTV2+g3tr5s0a2A6ZOjzfGG7jugJsHSv1XOiDGfQ8A1CJORuG+1Ms yNeymG1Js0sClCzeZOMxXyoKwPiQISFwe8fwhImmUrcZe+fjkk3rrXwM+3yI+6GQ hUYu/CmZyskUF4vvJ8Ce/3vSoQOu1gU0Hcy30HPLY7t5iV1Cq+pkhnlQjuX6pTFx EGiaT9TvpXlB4cVS+0Ia22MXUe5C3ie2X47MdgX/8lZ42gqwMyU+V3zX+KmideKe P3X2CA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d4qkssyna-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Mar 2026 09:12:59 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-354bc535546so878498a91.3 for ; Thu, 26 Mar 2026 02:12:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774516378; x=1775121178; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lLH2vp3omnzVgPghVQJ26xXtRhk3RZK9WfsJL6kRllM=; b=YiKxU82u3sr+tJG53DBRYw/TE8oCDBj7JoLpDimdIZFIxDPGIbroXR2iu6GEPa7nXA isP6MBJFQm9R6e7vMGh81cmPSiQlPVCLEKoQI9NGyYLLYeSPPapKj2gZ6NVfEXCfOwxt mnUk1YDYKkBahC15rW4reh3c7ad9WHrTVG94K+AGfHQtIoF7xVnyUX6LMDsTut17mXW8 7qT62e3A4cJFykqy4eD3sYZLqhkz72w4pU7cFFgAy2IavhIaAsmXksBsobTXQmP1/hGK 9N1ysZf+kqgAayzooZzmDdV3xvZulJTnZhw0Th5hyPNWHCBjAAiP1C8h1Sc28ww9IyOG Z2Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774516378; x=1775121178; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lLH2vp3omnzVgPghVQJ26xXtRhk3RZK9WfsJL6kRllM=; b=YcZt9Uflv4mvbEIiAkW8WCo4N3oJJaiXC1blySnRcTpnTq+PvUMAGj3kwD9wsj+hyN w542u2s4GYNDwjyav4ojX5Mbz2I4qrMbdQa74cdXDWUEV4RH4fP8TNx3zRLBDGIg/SRX 1d9ySLH6Zdne1OYDXQY40eBEecj6zvk07AapquZ72Y7Lbv+gYmcK4qk5hJlyhwwCleBg 7dXYNoQo/8RAMkmXEUPrEbyU/S4Og9o551D8vOJah9QcIguqiZ8gwOhnjggcN1rOHUrm 4ge+hFFlseaYIXQjEuqUADmVwJxXRClOdHw2hVU5bn1f2UsAMPTezR4IiHDiLCorHWsr TDbQ== X-Forwarded-Encrypted: i=1; AJvYcCUIRZehA1pC2HU4Ptdcg1mKNvyUziuebhal2M2l9mzwANaktvmpNktB+4yBrpAAA7n/utAmv/500bmN4Jg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9BnOJsuga48XmDW2WTNsH7aAyHKS5EzTIvlH/UPOyPPyGe61w YbULNWfBxDm0DfpOPh+nR3i9dQYSiJHoCTDIdftvXZduIRSGw0WXdEWHEBra2LETPkZQch8rxHz 08xvwBEaAqIVY1n8QtzDEEFiewwziitw5iJMscMfDvRScaJoZDiJAJj9pZTiJrsxCPJY= X-Gm-Gg: ATEYQzwm2f2PwgtsG0HnoKrZyGrg74P0h/ohdNI7guRRPoXQdW3I+JkRuSiWEJmHfOV Ol4igVy2jqZi1/zuP6XgOYHfmya3A8WKO9m8txI+nM1siJZYqnbQe6lO3INYqz0R7OXyTmhGx2A HxUxgg9UU01rfftBjRYoCb12loaNkVtC+96raC1eecLrlLNfhruJFiLX+wvBnsgAtXfZIdXCVOB JyKRxZk8Hu1hnHIbeougaHIPch33tiA0QS8hWepk6HT8hei0DzOQA16FAnYaTNxNVSSKDDa1Dpo WPpAQLXYeCeN1ZPUQByIoudocfQ8GS/GoxB+d4lPOHkicc/a3YTRIIfaFYJ+uRh1APQaoUObOUT xBm9skqn4ts4ys/pMLF1X/I2/tU5XSeMg/M6MRLieG+W7UGUg+I9G93tj5lzP3LBB4aG5ncnAFO foOgyFWs3wlFdIvtBV X-Received: by 2002:a17:90b:2885:b0:35a:18b1:c245 with SMTP id 98e67ed59e1d1-35c0dc5e3d6mr6418215a91.3.1774516378554; Thu, 26 Mar 2026 02:12:58 -0700 (PDT) X-Received: by 2002:a17:90b:2885:b0:35a:18b1:c245 with SMTP id 98e67ed59e1d1-35c0dc5e3d6mr6418192a91.3.1774516378061; Thu, 26 Mar 2026 02:12:58 -0700 (PDT) Received: from [10.133.33.234] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c22d09429sm962388a91.17.2026.03.26.02.12.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 02:12:57 -0700 (PDT) Message-ID: Date: Thu, 26 Mar 2026 17:12:52 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/2] cpufreq: Add boost_freq_req QoS request To: Viresh Kumar Cc: Pierre Gondois , linux-kernel@vger.kernel.org, Lifeng Zheng , Huang Rui , "Gautham R. Shenoy" , Mario Limonciello , Perry Yuan , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, zhongqiu.han@oss.qualcomm.com References: <20260325165255.386576-1-pierre.gondois@arm.com> <20260325165255.386576-3-pierre.gondois@arm.com> Content-Language: en-US From: Zhongqiu Han In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI2MDA2NiBTYWx0ZWRfXxFw4B1OMZhhD ltA727pKfsJ2nkuvGYJM0o2+GMzZxpJjnKbitx0ywZl1OEy3OhexVpg/rOjq9NoWEAGcAQG10Zf Ck9wlSuVjWyprzROR5RnIRZ5tYT0JHjCM315JIQ4Vj8b0aNJSQWT6bsTUx8ZUuNWrBnGa2iFYit 6t0wE/NWA0TkS5832DLyNxIlO4kyUlvcW2wnmkEGB00yzYgoBRPjOL3enU7tA8QoJ9HxNimHjhY dKzTKm3DbRnGtc5XoD5BGjV9DplGn7ilG0b6hD91gW9hI+N5V1jY4bAcfvh1w03UQuZRDpagp+W nhCfEkOs6YKcoBBUCUTZNoGH4OcgQrD3v5bedGGhUpIuuGoMrBtpAlGpGHP0Tx0W7XXwvFpcPH+ rjURgJJdiOn1yj7ZjP6uJqWc3uirkUVzP2ORfdymQ2xmgUt147bCYonTKsa1HPY7yoUv5csmCRG BzR5WoIeUlaAmFxTung== X-Proofpoint-ORIG-GUID: CrBcC0oJJjBMRHzoHoXB0bd1n0IccwWA X-Authority-Analysis: v=2.4 cv=eOMeTXp1 c=1 sm=1 tr=0 ts=69c4f89b cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=fWU4K67CW6VPo46kpwYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: CrBcC0oJJjBMRHzoHoXB0bd1n0IccwWA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_02,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 malwarescore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603260066 On 3/26/2026 4:50 PM, Viresh Kumar wrote: > On 26-03-26, 16:18, Zhongqiu Han wrote: >> Would it be reasonable to add a NULL check for policy->boost_freq_req in >> policy_set_boost() before calling freq_qos_update_request(), even though >> callers already check policy->boost_supported? Thanks > > Not required. policy_set_boost() should only be called if boost is supported. > Got it, thanks — no NULL check needed since boost_supported is the precondition. -- Thx and BRs, Zhongqiu Han