From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13888C77B79 for ; Sun, 16 Apr 2023 08:41:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230048AbjDPIls (ORCPT ); Sun, 16 Apr 2023 04:41:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229615AbjDPIlq (ORCPT ); Sun, 16 Apr 2023 04:41:46 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18439D8 for ; Sun, 16 Apr 2023 01:41:45 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id vc20so1584960ejc.10 for ; Sun, 16 Apr 2023 01:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681634503; x=1684226503; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=z38YOwonjh+CuGoHVNF1HUAwyUw8JsKrwMe04nmWqWU=; b=XtL7I8EJa4TnDjPqg/bkL7het+eZwnY7c+vq/oR2ufKb0V0wVxGLOZPHOCrhLp/MLY nQac8gaM2+kSZzQMExRz5WmhDKRKEwtQDMuzGoYCzPz/ABG/m/RmWD00gis9vZyn+8fI QqfIJA1OfwTSEDH8Bq/9e8CvppGUejeR5PnKTUicmjUqpEph6LPByXk8FWl5s8v4s1TQ B7kUj9Y+8d3E5VtFUDtzmuZodOqOXYGrSPGTsqj32s0E9JYBgn77+s5Hw0bLi8Dkbr4m QUHb0zcNiDhtcKAHF/IUpNbEohIY694N/DlEvVye1C4+PFpvEFln0yhFvsL2wu4AoNIC 1J5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681634503; x=1684226503; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z38YOwonjh+CuGoHVNF1HUAwyUw8JsKrwMe04nmWqWU=; b=UZoewN4MazG84qqat3AfKTwR3Bjf6xRJYbEnWGzaWqUFoW19mlnin/+Fp856zLiRK4 UJHM0wvMIgYWRApKCT+rrJF990H4lzJeu4Cg4U26+RxBmpvF5b8qbdIRS3yTp66X1ATN JCGoH4ZV5PI/fKofMeqElcOv92EPVku2Oiw75B4Y/bQDPTK2jDQnRXuHDqUQ1NEb0K6V 8ZCjGqZ9DJniaw1BRM05wj485P47LDnrVGAFCATptgwqJ3y2XiByqAff0fytlnqW84tA DIJtc2Ly49A1QwWf5kOSINVpGstwWb1VAzyx2sttAGlBtSK0PVzkvveOjLDxPt/70suY ejDg== X-Gm-Message-State: AAQBX9et6TERqZFhp3L93C6jWM3ewPfj2pwgOcBfAGYuvvQUaI+/A6TD PNueBqnTNV3myiq71AYIhcQw6Q== X-Google-Smtp-Source: AKy350Zi0A5LLp8sg5agw1LU2VkgNVdoV04TQ1cymNV6El5KTnF+4ocfEanZIQeGs02EIhPW/yxFvw== X-Received: by 2002:a17:907:9010:b0:94e:bc04:1e19 with SMTP id ay16-20020a170907901000b0094ebc041e19mr2881822ejc.71.1681634503524; Sun, 16 Apr 2023 01:41:43 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:29dd:ded4:3ccc:83db? ([2a02:810d:15c0:828:29dd:ded4:3ccc:83db]) by smtp.gmail.com with ESMTPSA id hu14-20020a170907a08e00b0094f2d38896esm1498033ejc.65.2023.04.16.01.41.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Apr 2023 01:41:43 -0700 (PDT) Message-ID: Date: Sun, 16 Apr 2023 10:41:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 0/5] Add support for Focaltech FTS Touchscreen Content-Language: en-US To: Joel Selvaraj , Caleb Connolly , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Henrik Rydberg , Arnd Bergmann , Robert Jarzmik , Jeff LaBundy , Markuss Broks , Jean Delvare , Max Krummenacher , Chris Morgan , Job Noorman , Alistair Francis , Hans de Goede , Maxime Ripard Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20230415020222.216232-1-joelselvaraj.oss@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230415020222.216232-1-joelselvaraj.oss@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/04/2023 04:02, Joel Selvaraj wrote: > Changes in v3:(Suggested by Krzysztof Kozlowski and Konrad Dybcio) > -------------- > - dts: removed the invalid "input-enable" property > - dts: replace interrupts with interrupts-extended > - dts: removed redundant dma configuration > - dts: reorder pinctrl and pinctrl-names > - bindings: moved unevaluatedProperties after required > - bindings: make interrupts a required property (new change from my end) > - bindings: update example based on dts changes > > I have made the interrupts a required property in the bindings as the driver > will not function without an interrupt. Because of this new change, I have not Driver does not really matter for the bindings. The BSD driver for example might function without an interrupt, so why requiring it? The reason for requiring or not is in the hardware and how it works. Best regards, Krzysztof