From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C1F7314B78 for ; Mon, 3 Nov 2025 16:03:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762185831; cv=none; b=s5DRwK1F6R2iT3lnbqsUzNDpPnBs+JL1/wU4ViZZyo8OONkyWKUfZwBQJ2NS+9hf+sHSOCsZipNmDePQp2EwU2nK5dvdAmJkFFXipWSt2qvcrTPu41DaMmcxqiIeo9m6iAqa//9m6VNLdr1Yw9r70pABci2HsHPsXw1fZc6vfqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762185831; c=relaxed/simple; bh=W3vMDeaXnHo1OZjfJ7ogXCVgomGfM6sVhl807GF4qFQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dre9h6B5yVDwLsIo6qS3D5QkqV2Kx16IUkYOnAe4djxgr/KH71PyP0cxRVHuBYvgOWrL/foczkpA9cW+YjebBfAuTPlChm8bsMcjR7hRwuOVoBT7/GMunZLG9W05q/1Rne6/7BjGpow06OEkPxT0ALFSkaIuN1XLZzO7/4cflK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=i4Xnsm0v; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=taCqwNzw; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="i4Xnsm0v"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="taCqwNzw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762185828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lAB1nRPhZgw2D2F/txfufevKSsNDcd09VLHZkiGFvSY=; b=i4Xnsm0vx46j28gDyhryibvkXiqHewn8CK+/phFK5De/BLooQKa/ovWEn7EVMSqMFDs/bb B5qGAJCRSze3s5TrxQ9vnCQvFj5Lb6KYkl3qpj45ZdGrBAV0+CsahIFJbbMAfzFFpk1f6h OHkfyHTQjN7M/MMjMSPWLKv/8shijnI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-408-_50qIX7kNVy1gKvWjeMWHQ-1; Mon, 03 Nov 2025 11:03:46 -0500 X-MC-Unique: _50qIX7kNVy1gKvWjeMWHQ-1 X-Mimecast-MFC-AGG-ID: _50qIX7kNVy1gKvWjeMWHQ_1762185826 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-477171bbf51so24501555e9.3 for ; Mon, 03 Nov 2025 08:03:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1762185826; x=1762790626; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=lAB1nRPhZgw2D2F/txfufevKSsNDcd09VLHZkiGFvSY=; b=taCqwNzwBgQQGcFKeViFmoWuWppOz1wR2vdQ3NSNgpwOtff3+cbkf2Ar9bsv7Cv0FS tCIs16cLEFIVUAnq9A2vGRYkwh96FDY7+7EJ0hDE0oSXZwJIHjN1uXyEMsWJwd3Al/Y5 1xS6eVKF3qtn3UjGUSBHt6BBvWPgs7OxYvLRISpV4QlCQ0xQUZAGjAju5SP3032RThmY OiohCibU9VDgWNKArnBxozq/Ua/PxjLgxLp/QvY6gaLbiDU6obj5rDZvUIvEnM0sK+kC h3fJJ4CrMOJ201ndQVVpAKgRNmK+Vi9m87eya25kWQM05LIJ0kNq5D3zJ3tIlDzc7IX6 u+rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762185826; x=1762790626; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lAB1nRPhZgw2D2F/txfufevKSsNDcd09VLHZkiGFvSY=; b=uZBl2rOG3DaKa0K0/KrhCzXWAxFrVqzcj+9QLUd8InyrBpdkcCDIICiGu0JL9/93Jm Xvbd3TX6Xm7qEXuU8TcWHm7yFgmVSqLR0w9SxekFNUa+LOmDBEK1GHC4VxfQSEJrWEnk OJi1e3QDda5EzCsJkmY4FTf8gJviWHoRRlDuQqaMdxJhMb6pwGwOfxEXmsnwRiTcXhE6 tdYIstL2/G1QjqFUz+RPqStg89/Odbg56/ZsMekyTUnd2MyXwjFGeFCFm+4u1/y87dDT AMEHQ2YtO0WnISMCvSttItCKMkc2556w+ZoHMS1AGjfL+nRyrZ4o+VU/5Usg/YewmmR9 vWlQ== X-Gm-Message-State: AOJu0YwqUfwv+uhns/Gv6IZeacFUHEh6+zt1w/9vJKhve9QnIYoPulDL fE0rnnDxWfiLb5P3m/QJZ4hN5fvmoit31HVAA5+588CGfzqC+Vm9CmFUJ6nBw3KZgc7s7Ul+LLs tQ+g3mDDbE8ef7NkCRZKQDoiUK2cAH6L2Spw9cPi923IPBGsW/9sX3cW+S72GLF7XWA== X-Gm-Gg: ASbGncvP6XOunlW5zyw+/XaFa+rCFOXYODO4BnaJhKClFMwJSxiNktJqirhhM5WQzlI WSV7NJ2xqE4YTqNTwdkie7LDGs/Kzf68/8oepXTDJfHqW3nZlqi9kQGrOQ+A2YR05Am3bqo0HUa BQoBWw8IlMkOp4/Nhi32TUvFFDISQbyZkUN5mXM35Gs6iQYe6L7ZvEHNn7gAoowwhU/BNx9IeNB Qsh0r5U8rn7DXY0Z/+M52jYuGLr3v6VaGmvAa56Ednb1Gfgq/FchD+GcDFVS3qVnwQxRJiQJcE+ JX09g805nW+gXu1lkMj3ZIJ7/plgzIFqiKiW6v6PZyb1XqHb9zudXxz4Te8/i6rwOfq08v51QuC 31NKvWs2cnEZ9Dp1tau+/jJC/zGsTM62aqcusK0/tMcAexK+eEiDIhsIk+yMe11pyHjHmCJF2Rc +gID5s/+tT+RF/Zhe/87rZw1LoqCA= X-Received: by 2002:a05:600d:831c:b0:477:542a:7ed1 with SMTP id 5b1f17b1804b1-477542a7ee4mr3985045e9.19.1762185825553; Mon, 03 Nov 2025 08:03:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IE5tyJHb+sues0m+7ZNZilqyo2L9Cho1JQDhJMCuFOgAOZW6Lsc8SY3FhL38SgCM772181+5A== X-Received: by 2002:a05:600d:831c:b0:477:542a:7ed1 with SMTP id 5b1f17b1804b1-477542a7ee4mr3984625e9.19.1762185825048; Mon, 03 Nov 2025 08:03:45 -0800 (PST) Received: from ?IPV6:2003:d8:2f3f:4b00:ee13:8c22:5cc5:d169? (p200300d82f3f4b00ee138c225cc5d169.dip0.t-ipconnect.de. [2003:d8:2f3f:4b00:ee13:8c22:5cc5:d169]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4773c48daa0sm167032215e9.3.2025.11.03.08.03.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Nov 2025 08:03:44 -0800 (PST) Message-ID: Date: Mon, 3 Nov 2025 17:03:42 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 08/12] arm64: mm: replace TIF_LAZY_MMU with in_lazy_mmu_mode() To: Kevin Brodsky , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Alexander Gordeev , Andreas Larsson , Andrew Morton , Boris Ostrovsky , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dave Hansen , "David S. Miller" , David Woodhouse , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Juergen Gross , "Liam R. Howlett" , Lorenzo Stoakes , Madhavan Srinivasan , Michael Ellerman , Michal Hocko , Mike Rapoport , Nicholas Piggin , Peter Zijlstra , Ryan Roberts , Suren Baghdasaryan , Thomas Gleixner , Vlastimil Babka , Will Deacon , Yeoreum Yun , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org References: <20251029100909.3381140-1-kevin.brodsky@arm.com> <20251029100909.3381140-9-kevin.brodsky@arm.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20251029100909.3381140-9-kevin.brodsky@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29.10.25 11:09, Kevin Brodsky wrote: > The generic lazy_mmu layer now tracks whether a task is in lazy MMU > mode. As a result we no longer need a TIF flag for that purpose - > let's use the new in_lazy_mmu_mode() helper instead. > > Signed-off-by: Kevin Brodsky > --- > arch/arm64/include/asm/pgtable.h | 16 +++------------- > arch/arm64/include/asm/thread_info.h | 3 +-- > 2 files changed, 4 insertions(+), 15 deletions(-) > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 535435248923..61ca88f94551 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -62,30 +62,21 @@ static inline void emit_pte_barriers(void) > > static inline void queue_pte_barriers(void) > { > - unsigned long flags; > - > if (in_interrupt()) { > emit_pte_barriers(); > return; > } > > - flags = read_thread_flags(); > - > - if (flags & BIT(TIF_LAZY_MMU)) { > - /* Avoid the atomic op if already set. */ > - if (!(flags & BIT(TIF_LAZY_MMU_PENDING))) > - set_thread_flag(TIF_LAZY_MMU_PENDING); > - } else { > + if (in_lazy_mmu_mode()) > + test_and_set_thread_flag(TIF_LAZY_MMU_PENDING); You likely don't want a test_and_set here, which would do a test_and_set_bit() -- an atomic rmw. You only want to avoid the atomic write if already set. So keep the current /* Avoid the atomic op if already set. */ if (!(flags & BIT(TIF_LAZY_MMU_PENDING))) set_thread_flag(TIF_LAZY_MMU_PENDING); -- Cheers David