From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AAA8C432BE for ; Fri, 13 Aug 2021 23:27:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E56A60F00 for ; Fri, 13 Aug 2021 23:27:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235679AbhHMX1d (ORCPT ); Fri, 13 Aug 2021 19:27:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55062 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235530AbhHMX1c (ORCPT ); Fri, 13 Aug 2021 19:27:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628897225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2ltnXqs72PoZJlgVvtR4opPys8udAwLGgtjNFBrBB1U=; b=OMOhNqTHrbuCyF1r8T4eR9ZaB0SzGzXisQwV6dlvQRl4x8eponwPQ3Uo1P3l5Ma+IYEoOn MybE3QQ2ZpbCNwZyCYpp1yNjmNKn5cCQ3w8geo+sLWfs0CgxaXxpdufhEZisytRmpIUzRL VAIEnFBT58QEeqpvUZBa/605gaDQ+ZM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-197-ND25mHrfP1-lAr2yra8cfg-1; Fri, 13 Aug 2021 19:27:04 -0400 X-MC-Unique: ND25mHrfP1-lAr2yra8cfg-1 Received: by mail-wm1-f71.google.com with SMTP id u14-20020a7bcb0e0000b0290248831d46e4so2207954wmj.6 for ; Fri, 13 Aug 2021 16:27:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2ltnXqs72PoZJlgVvtR4opPys8udAwLGgtjNFBrBB1U=; b=M/D4IZuBfns5AO3HQM5phc5bTRSKJFbestbW7TRG/w89oWe4kU0U8zN0LmYgXW4Vvu CRVN+1imvyXUWRu5cm+IF647KeCZh7qpKPZ30U1yej3uw1NI0ZCns5nyPoF/KVWmZFos n2X/Q6YqtZ1htS/0XLLHnYD9fOG2LsUCzntLWnyfZeFLVI2HLq0s4azpLK1nGIaUeqOl k0BO62EP4NZOg6jsrlocRcxBh+ebdLZ22mUBOJVVYSdZQfRQT4GxIiXaQF0msrIRIj7V 6FeRIIi6sRtR6+Y94Nh5DTbuQuL5XcbemWh6aTyMJsHYrANfuwe44ZaeJAZBRJob/kbO I9IA== X-Gm-Message-State: AOAM533eQ4zAjKf32hEJY8QFW95gZEJFwmyPCUHOWYSrNEGWMKNLBLcX P105NyjYIKLqwZ9Uw/OMfxqdUKAAG52/6UcVlFWKkPOEvEOqXcniVKaCh4c8e8wYVpc1bDGcQ/E wrHWBG1n2tcJMM0wUu3M2i4Abn3NwwGyXQBQWqKOFyzBbZ/6DSymfmutWZFXg3pGf85pJO/SOwe Q1 X-Received: by 2002:a05:600c:1483:: with SMTP id c3mr4574075wmh.131.1628897222512; Fri, 13 Aug 2021 16:27:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0xDBu7qLTuycfsdJlyJRztUYK2z+Cba+NWhlTJD00FCnM/bVqlz1ZvzqvrtswSGYJMSQejg== X-Received: by 2002:a05:600c:1483:: with SMTP id c3mr4574048wmh.131.1628897222249; Fri, 13 Aug 2021 16:27:02 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id q17sm2712042wrr.91.2021.08.13.16.27.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Aug 2021 16:27:01 -0700 (PDT) Subject: Re: [PATCH -next 1/2] selftests: Fix vm_handle_exception undefined error To: Shuah Khan , Chen Lifu , shuah@kernel.org, bgardon@google.com, wangyanan55@huawei.com, axelrasmussen@google.com, drjones@redhat.com, seanjc@google.com, vkuznets@redhat.com, dwmw@amazon.co.uk, joao.m.martins@oracle.com, yangyingliang@huawei.com, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210709063741.355325-1-chenlifu@huawei.com> From: Paolo Bonzini Message-ID: Date: Sat, 14 Aug 2021 01:26:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/08/21 19:01, Shuah Khan wrote: > On 7/9/21 12:37 AM, Chen Lifu wrote: >> Compile setftests on x86_64 occurs following error: >> make -C tools/testing/selftests >> ... >> >> x86_64/hyperv_features.c:618:2: warning: implicit declaration of >> function ‘vm_handle_exception’ [-Wimplicit-function-declaration] >>    618 |  vm_handle_exception(vm, GP_VECTOR, guest_gp_handler); >> /usr/bin/ld: /tmp/cclOnpml.o: in function `main': >> tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined >> reference to `vm_handle_exception' >> collect2: error: ld returned 1 exit status >> >> The reason is that commit b78f4a596692 ("KVM: selftests: Rename >> vm_handle_exception") >> renamed "vm_handle_exception" function to >> "vm_install_exception_handler" function. >> >> Fix it by replacing "vm_handle_exception" with >> "vm_install_exception_handler" >> in corresponding selftests files. >> >> Signed-off-by: Chen Lifu >> --- >>   tools/testing/selftests/kvm/x86_64/hyperv_features.c | 2 +- >>   tools/testing/selftests/kvm/x86_64/mmu_role_test.c   | 2 +- >>   2 files changed, 2 insertions(+), 2 deletions(-) >> > > > Please include kvm in the commit summary. I think it is not getting > the right attention because of the summary line. The same patch was already committed: commit f8f0edabcc09fafd695ed2adc0eb825104e35d5c Author: Marc Zyngier Date: Thu Jul 1 08:19:28 2021 +0100 KVM: selftests: x86: Address missing vm_install_exception_handler conversions Commit b78f4a59669 ("KVM: selftests: Rename vm_handle_exception") raced with a couple of new x86 tests, missing two vm_handle_exception to vm_install_exception_handler conversions. Help the two broken tests to catch up with the new world. Cc: Andrew Jones CC: Ricardo Koller Cc: Paolo Bonzini Signed-off-by: Marc Zyngier Message-Id: <20210701071928.2971053-1-maz@kernel.org> Reviewed-by: Andrew Jones Reviewed-by: Ricardo Koller Signed-off-by: Paolo Bonzini For the other patch, returning 0 is going to cause issues elsewhere in the tests. Either the test is failed immediately, or all callers must be examined carefully. Paolo